While digging through the mcu functions, I came across some deficits I
introduced with the initial driver submission, so trying to make that
a bit nicer with this series.


I struggled a bit with the ordering of qnap_mcu_write error-check
and conversion to guard(mutex). Converting to guard before the
error check would need dropping the ret variable, just to re-add it
one patch later - to not cause unused variable warning.

Additionally the error handling could be considered a fix, so makes
sense to have in front.


Heiko Stuebner (4):
  mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header
  mfd: qnap-mcu: handle errors returned from qnap_mcu_write
  mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec
  mfd: qnap-mcu: improve structure in qnap_mcu_exec

 drivers/mfd/qnap-mcu.c       | 30 +++++++++++++++---------------
 include/linux/mfd/qnap-mcu.h |  2 ++
 2 files changed, 17 insertions(+), 15 deletions(-)

-- 
2.47.2

On Mon, 04 Aug 2025 15:07:22 +0200, Heiko Stuebner wrote:
> While digging through the mcu functions, I came across some deficits I
> introduced with the initial driver submission, so trying to make that
> a bit nicer with this series.
> 
> 
> I struggled a bit with the ordering of qnap_mcu_write error-check
> and conversion to guard(mutex). Converting to guard before the
> error check would need dropping the ret variable, just to re-add it
> one patch later - to not cause unused variable warning.
> 
> [...]

Applied, thanks!

[1/4] mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header
      commit: f7ef7c03d8599a0d86b2a05929da73358cd56dcf
[2/4] mfd: qnap-mcu: handle errors returned from qnap_mcu_write
      commit: 3d02c538ec5337b66750d83ce6f861aef263fbff
[3/4] mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec
      commit: 5fd101541c6d0f0ad3b14d86dfcf9347c3f3bffd
[4/4] mfd: qnap-mcu: improve structure in qnap_mcu_exec
      commit: 6cdb0fbe090be966432db041d5650907a4dceac4

--
Lee Jones [李琼斯]

On Tue, 02 Sep 2025, Lee Jones wrote:

> On Mon, 04 Aug 2025 15:07:22 +0200, Heiko Stuebner wrote:
> > While digging through the mcu functions, I came across some deficits I
> > introduced with the initial driver submission, so trying to make that
> > a bit nicer with this series.
> > 
> > 
> > I struggled a bit with the ordering of qnap_mcu_write error-check
> > and conversion to guard(mutex). Converting to guard before the
> > error check would need dropping the ret variable, just to re-add it
> > one patch later - to not cause unused variable warning.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/4] mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header
>       commit: f7ef7c03d8599a0d86b2a05929da73358cd56dcf
> [2/4] mfd: qnap-mcu: handle errors returned from qnap_mcu_write
>       commit: 3d02c538ec5337b66750d83ce6f861aef263fbff
> [3/4] mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec
>       commit: 5fd101541c6d0f0ad3b14d86dfcf9347c3f3bffd
> [4/4] mfd: qnap-mcu: improve structure in qnap_mcu_exec
>       commit: 6cdb0fbe090be966432db041d5650907a4dceac4

I fixed some issues in the commit messages for you pertaining to
spelling mistakes and expected format.  Please not that in future, MFD
and LED (the submissions I've seen from you recently) take a capitalised
word as the start of the subject description.

-- 
Lee Jones [李琼斯]