maple_tree: Remove redundant __GFP_NOWARN

[PATCH] maple_tree: Remove redundant __GFP_NOWARN

Posted by Qianfeng Rong 2 months ago

Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
made GFP_NOWAIT implicitly include __GFP_NOWARN.

Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
up these redundant flags across subsystems.

No functional changes.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
 lib/maple_tree.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index b4ee2d29d7a9..38fb68c08291 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -1344,11 +1344,11 @@ static void mas_node_count_gfp(struct ma_state *mas, int count, gfp_t gfp)
  * @mas: The maple state
  * @count: The number of nodes needed
  *
- * Note: Uses GFP_NOWAIT | __GFP_NOWARN for gfp flags.
+ * Note: Uses GFP_NOWAIT for gfp flags.
  */
 static void mas_node_count(struct ma_state *mas, int count)
 {
-	return mas_node_count_gfp(mas, count, GFP_NOWAIT | __GFP_NOWARN);
+	return mas_node_count_gfp(mas, count, GFP_NOWAIT);
 }
 
 /*
-- 
2.34.1

Re: [PATCH] maple_tree: Remove redundant __GFP_NOWARN

Posted by Wei Yang 2 months ago

On Mon, Aug 04, 2025 at 08:56:57PM +0800, Qianfeng Rong wrote:
>Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
>made GFP_NOWAIT implicitly include __GFP_NOWARN.
>
>Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
>(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
>up these redundant flags across subsystems.
>
>No functional changes.
>
>Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>

LGTM.

Reviewed-by: Wei Yang <richard.weiyang@gmail.com>

-- 
Wei Yang
Help you, Help me

Re: [PATCH] maple_tree: Remove redundant __GFP_NOWARN

Posted by Liam R. Howlett 1 month, 4 weeks ago

* Qianfeng Rong <rongqianfeng@vivo.com> [250804 08:57]:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
> made GFP_NOWAIT implicitly include __GFP_NOWARN.
> 
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
> (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
> up these redundant flags across subsystems.
> 
> No functional changes.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  lib/maple_tree.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index b4ee2d29d7a9..38fb68c08291 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1344,11 +1344,11 @@ static void mas_node_count_gfp(struct ma_state *mas, int count, gfp_t gfp)
>   * @mas: The maple state
>   * @count: The number of nodes needed
>   *
> - * Note: Uses GFP_NOWAIT | __GFP_NOWARN for gfp flags.
> + * Note: Uses GFP_NOWAIT for gfp flags.
>   */
>  static void mas_node_count(struct ma_state *mas, int count)
>  {
> -	return mas_node_count_gfp(mas, count, GFP_NOWAIT | __GFP_NOWARN);
> +	return mas_node_count_gfp(mas, count, GFP_NOWAIT);
>  }
>  
>  /*
> -- 
> 2.34.1
>