qnap-mcu: add support for the status LEDs

[PATCH v2 0/2] qnap-mcu: add support for the status LEDs

Posted by Heiko Stuebner 2 months ago

Add the status LED controlled via the MCU and clean up the usb LED
a tiny bit.

changes in v2:
- add patch to clarify the command "area" of the usb status LED
- captilze LED in text areas (Lee)
- use 100 chars to prevent some line breaks (Lee)
- added the newly found state for "both on"
- don't forward declare struct, instead just point both LEDs to
  the red one, to allow resolving the parent struct and shared
  setter functions


Heiko Stuebner (2):
  leds: qnap-mcu: fix state numbering for usb LED
  leds: qnap-mcu: add support for the red and green status LEDs

 drivers/leds/leds-qnap-mcu.c | 175 ++++++++++++++++++++++++++++++++++-
 1 file changed, 170 insertions(+), 5 deletions(-)

-- 
2.47.2

Re: [PATCH v2 0/2] qnap-mcu: add support for the status LEDs

Posted by Lee Jones 1 month ago

On Mon, 04 Aug 2025 13:49:47 +0200, Heiko Stuebner wrote:
> Add the status LED controlled via the MCU and clean up the usb LED
> a tiny bit.
> 
> changes in v2:
> - add patch to clarify the command "area" of the usb status LED
> - captilze LED in text areas (Lee)
> - use 100 chars to prevent some line breaks (Lee)
> - added the newly found state for "both on"
> - don't forward declare struct, instead just point both LEDs to
>   the red one, to allow resolving the parent struct and shared
>   setter functions
> 
> [...]

Applied, thanks!

[1/2] leds: qnap-mcu: fix state numbering for usb LED
      commit: fe4ffdbab4bb3cda1d72b93f7d2c3f7ea3df415d
[2/2] leds: qnap-mcu: add support for the red and green status LEDs
      commit: c2d5d8f247049e22ef0afe8188cf8a6430144a17

--
Lee Jones [李琼斯]