Add thermal management support for sama7d65

[PATCH 03/15] dt-bindings: microchip-otpc: update dt node example

Posted by Varshini Rajendran 2 months ago

Update the example binding according to the new driver implementation.

Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
 .../devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
index cc25f2927682..e9059dce85ef 100644
--- a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
+++ b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
@@ -42,9 +42,8 @@ examples:
         reg = <0xe8c00000 0xec>;
         #address-cells = <1>;
         #size-cells = <1>;
-
-        temperature_calib: calib@1 {
-            reg = <OTP_PKT(1) 76>;
+        temperature_calib: calib@41435354 {
+            reg = <0x41435354 0x4c>;        /* Temp calib data packet TAG */
         };
     };
 
-- 
2.34.1

Re: [PATCH 03/15] dt-bindings: microchip-otpc: update dt node example

Posted by Krzysztof Kozlowski 2 months ago

On Mon, Aug 04, 2025 at 03:32:07PM +0530, Varshini Rajendran wrote:
> Update the example binding according to the new driver implementation.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
>  .../devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml    | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> index cc25f2927682..e9059dce85ef 100644
> --- a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> @@ -42,9 +42,8 @@ examples:
>          reg = <0xe8c00000 0xec>;
>          #address-cells = <1>;
>          #size-cells = <1>;
> -
> -        temperature_calib: calib@1 {
> -            reg = <OTP_PKT(1) 76>;
> +        temperature_calib: calib@41435354 {

1. You did not clean up the header.
2. I looked briefly on your driver and it seems it changes the ABI
breaking users.

Best regards,
Krzysztof