[PATCH V2 1/2] dt-bindings: interconnect: Add OSM L3 compatible for QCS615 SoC

Raviteja Laggyshetty posted 2 patches 2 months ago
There is a newer version of this series
[PATCH V2 1/2] dt-bindings: interconnect: Add OSM L3 compatible for QCS615 SoC
Posted by Raviteja Laggyshetty 2 months ago
Add Operation State Manager (OSM) L3 interconnect provider binding for
QCS615 SoC. As the OSM hardware in QCS615 and SM8150 are same,
added a family-level compatible for SM8150 SoC. This shared fallback
compatible allows grouping of SoCs with similar hardware, reducing
the need to explicitly list each variant in the driver match table.

Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
---
 .../devicetree/bindings/interconnect/qcom,osm-l3.yaml        | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
index ab5a921c3495..4b9b98fbe8f2 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
@@ -41,6 +41,11 @@ properties:
               - qcom,qcs8300-epss-l3
           - const: qcom,sa8775p-epss-l3
           - const: qcom,epss-l3
+      - items:
+          - enum:
+              - qcom,qcs615-osm-l3
+          - const: qcom,sm8150-osm-l3
+          - const: qcom,osm-l3
 
   reg:
     maxItems: 1
-- 
2.43.0
Re: [PATCH V2 1/2] dt-bindings: interconnect: Add OSM L3 compatible for QCS615 SoC
Posted by Krzysztof Kozlowski 2 months ago
On 04/08/2025 08:15, Raviteja Laggyshetty wrote:
> Add Operation State Manager (OSM) L3 interconnect provider binding for
> QCS615 SoC. As the OSM hardware in QCS615 and SM8150 are same,
> added a family-level compatible for SM8150 SoC. This shared fallback
> compatible allows grouping of SoCs with similar hardware, reducing
> the need to explicitly list each variant in the driver match table.

Drop last sentence, it is completely redundant. Do not explain to us how
DT works. We all know that.

> 
> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/interconnect/qcom,osm-l3.yaml        | 5 +++++
>  1 file changed, 5 insertions(+)
No, slow down, this conflicts with other patch and makes your entry
duplicated. Just squash both commits.

Best regards,
Krzysztof
Re: [PATCH V2 1/2] dt-bindings: interconnect: Add OSM L3 compatible for QCS615 SoC
Posted by Raviteja Laggyshetty 1 month, 2 weeks ago

On 8/4/2025 11:56 AM, Krzysztof Kozlowski wrote:
> On 04/08/2025 08:15, Raviteja Laggyshetty wrote:
>> Add Operation State Manager (OSM) L3 interconnect provider binding for
>> QCS615 SoC. As the OSM hardware in QCS615 and SM8150 are same,
>> added a family-level compatible for SM8150 SoC. This shared fallback
>> compatible allows grouping of SoCs with similar hardware, reducing
>> the need to explicitly list each variant in the driver match table.
> 
> Drop last sentence, it is completely redundant. Do not explain to us how
> DT works. We all know that.
> 
Sure, Will drop the fallback explanation in next revision.>>
>> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>
>> ---
>>  .../devicetree/bindings/interconnect/qcom,osm-l3.yaml        | 5 +++++
>>  1 file changed, 5 insertions(+)
> No, slow down, this conflicts with other patch and makes your entry
> duplicated. Just squash both commits.
> 
The conflicting patch 
https://lore.kernel.org/all/20250711102540.143-2-raviteja.laggyshetty@oss.qualcomm.com/
got picked into v6.17-rc1.

Thanks,
Raviteja

> Best regards,
> Krzysztof
Re: [PATCH V2 1/2] dt-bindings: interconnect: Add OSM L3 compatible for QCS615 SoC
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 18/08/2025 11:12, Raviteja Laggyshetty wrote:
>>>  .../devicetree/bindings/interconnect/qcom,osm-l3.yaml        | 5 +++++
>>>  1 file changed, 5 insertions(+)
>> No, slow down, this conflicts with other patch and makes your entry
>> duplicated. Just squash both commits.
>>
> The conflicting patch 
> https://lore.kernel.org/all/20250711102540.143-2-raviteja.laggyshetty@oss.qualcomm.com/
> got picked into v6.17-rc1.

Then why you could not rebase on next if you sent it afterwards? You are
not making the process easier for us.

Best regards,
Krzysztof