.../bindings/media/qcom,sm8750-iris.yaml | 186 +++++++++++++++++++++ .../platform/qcom/iris/iris_platform_common.h | 6 +- .../media/platform/qcom/iris/iris_platform_gen2.c | 68 ++++++++ .../platform/qcom/iris/iris_platform_sm8750.h | 22 +++ drivers/media/platform/qcom/iris/iris_probe.c | 4 + drivers/media/platform/qcom/iris/iris_vpu2.c | 2 + drivers/media/platform/qcom/iris/iris_vpu3x.c | 150 +++++++++++++++++ drivers/media/platform/qcom/iris/iris_vpu_common.c | 12 +- drivers/media/platform/qcom/iris/iris_vpu_common.h | 6 + 9 files changed, 451 insertions(+), 5 deletions(-)
Changes in v2:
- Unify power-off sequence with SM8650 and re-use existing callbacks.
- Drop incorrect WRAPPER_CORE_POWER_CONTROL and unused
controller_resets.
- Rename FW to qcom/vpu/vpu35_p4.mbn.
- DT binding: correct typo + Rb tag.
- Link to v1: https://lore.kernel.org/r/20250714-sm8750-iris-v1-0-3006293a5bc7@linaro.org
Firmware:
=========
Mot yet released, AFAIK. Will be hopefully released later by Qualcomm.
DTS for reference was posted here:
https://lore.kernel.org/all/20250714-b4-sm8750-iris-dts-v1-0-93629b246d2e@linaro.org/
Description:
============
Add support for SM8750 Iris codec with major differences against
previous generation SM8650.
DTS will follow up separately (depends on other DTS patches so cannot be
merged as is).
v4l2-compliance report:
v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t
v4l2-compliance SHA: 4aee01a02792 2023-12-12 21:40:38
Compliance test for iris_driver device /dev/video0:
Driver Info:
Driver name : iris_driver
Card type : Iris Decoder
Bus info : platform:aa00000.video-codec
Driver version : 6.16.0
Capabilities : 0x84204000
Video Memory-to-Memory Multiplanar
Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04204000
Video Memory-to-Memory Multiplanar
Streaming
Extended Pix Format
Detected Stateful Decoder
Required ioctls:
test VIDIOC_QUERYCAP: OK
test invalid ioctls: OK
Allow for multiple opens:
test second /dev/video0 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK
Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
test VIDIOC_LOG_STATUS: OK (Not Supported)
Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0
Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_ENUMAUDOUT: OK (Not Supported)
test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0
Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
test VIDIOC_G/S_EDID: OK (Not Supported)
Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
Standard Controls: 10 Private Controls: 0
Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK
test Composing: OK
test Scaling: OK (Not Supported)
Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
test VIDIOC_G_ENC_INDEX: OK (Not Supported)
test VIDIOC_(TRY_)DECODER_CMD: OK
Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
test CREATE_BUFS maximum buffers: OK
test VIDIOC_EXPBUF: OK
test Requests: OK (Not Supported)
Total for iris_driver device /dev/video0: 46, Succeeded: 46, Failed: 0, Warnings: 0
Best regards,
Krzysztof
---
Krzysztof Kozlowski (3):
media: dt-bindings: qcom,sm8550-iris: Add SM8750 video codec
media: iris: Split power on per variants
media: iris: Add support for SM8750 (VPU v3.5)
.../bindings/media/qcom,sm8750-iris.yaml | 186 +++++++++++++++++++++
.../platform/qcom/iris/iris_platform_common.h | 6 +-
.../media/platform/qcom/iris/iris_platform_gen2.c | 68 ++++++++
.../platform/qcom/iris/iris_platform_sm8750.h | 22 +++
drivers/media/platform/qcom/iris/iris_probe.c | 4 +
drivers/media/platform/qcom/iris/iris_vpu2.c | 2 +
drivers/media/platform/qcom/iris/iris_vpu3x.c | 150 +++++++++++++++++
drivers/media/platform/qcom/iris/iris_vpu_common.c | 12 +-
drivers/media/platform/qcom/iris/iris_vpu_common.h | 6 +
9 files changed, 451 insertions(+), 5 deletions(-)
---
base-commit: 709a73d51f11d75ee2aee4f690e4ecd8bc8e9bf3
change-id: 20250714-sm8750-iris-444d7214c903
prerequisite-message-id: <20250702134158.210966-2-krzysztof.kozlowski@linaro.org>
prerequisite-patch-id: 1658ac2fc03eb4b33a236c2dfc2a053249068354
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
On 8/4/2025 7:07 PM, Krzysztof Kozlowski wrote: > Changes in v2: > - Unify power-off sequence with SM8650 and re-use existing callbacks. > - Drop incorrect WRAPPER_CORE_POWER_CONTROL and unused > controller_resets. > - Rename FW to qcom/vpu/vpu35_p4.mbn. > - DT binding: correct typo + Rb tag. > - Link to v1: https://lore.kernel.org/r/20250714-sm8750-iris-v1-0-3006293a5bc7@linaro.org > > Firmware: > ========= > Mot yet released, AFAIK. Will be hopefully released later by Qualcomm. Its released here: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom?id=530f283206034b20ed791ef379f4394ca21fe63d > > DTS for reference was posted here: > https://lore.kernel.org/all/20250714-b4-sm8750-iris-dts-v1-0-93629b246d2e@linaro.org/ > > Description: > ============ > Add support for SM8750 Iris codec with major differences against > previous generation SM8650. > > DTS will follow up separately (depends on other DTS patches so cannot be > merged as is). > > v4l2-compliance report: > > v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t > v4l2-compliance SHA: 4aee01a02792 2023-12-12 21:40:38 > Thank you for running the v4l2 compliance tests with your patches. While these tests are helpful for verifying API compliance, they do not cover the actual functional aspects of the new SOC support being added. Please run a decoder use-case using either v4l2-ctl or GStreamer (GST) and add the results in this cover letter. Thanks, Dikshita
On 12/08/2025 09:52, Dikshita Agarwal wrote: >> >> v4l2-compliance report: >> >> v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t >> v4l2-compliance SHA: 4aee01a02792 2023-12-12 21:40:38 >> > > Thank you for running the v4l2 compliance tests with your patches. While > these tests are helpful for verifying API compliance, they do not cover the > actual functional aspects of the new SOC support being added. > > Please run a decoder use-case using either v4l2-ctl or GStreamer (GST) and > add the results in this cover letter. You did not provide such details on your submission: https://lore.kernel.org/all/20250704-iris-video-encoder-v1-0-b6ce24e273cf@quicinc.com/ so asking others of this is just unfair and unjustified obstacle. If you have technical comments, then share. If you are just making fake obstacles to stop some patchset then refrain from commenting. Unless you want statement like: All patches have been tested with v4l2-compliance, v4l2-ctl and Gstreamer on SM8750. Then I can give you such statement, just like you did for your patchset: All patches have been tested with v4l2-compliance, v4l2-ctl and Gstreamer on SM8750. Best regards, Krzysztof
On 8/12/2025 1:29 PM, Krzysztof Kozlowski wrote: > On 12/08/2025 09:52, Dikshita Agarwal wrote: >>> >>> v4l2-compliance report: >>> >>> v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t >>> v4l2-compliance SHA: 4aee01a02792 2023-12-12 21:40:38 >>> >> >> Thank you for running the v4l2 compliance tests with your patches. While >> these tests are helpful for verifying API compliance, they do not cover the >> actual functional aspects of the new SOC support being added. >> >> Please run a decoder use-case using either v4l2-ctl or GStreamer (GST) and >> add the results in this cover letter. > You did not provide such details on your submission: > https://lore.kernel.org/all/20250704-iris-video-encoder-v1-0-b6ce24e273cf@quicinc.com/ I have mentioned in my series that I have used both v4l2-ctl and GStreamer (GST) for encoder testing, in addition to running v4l2-compliance. That is what I am asking you to do as well. Your cover letter only mentions v4l2-compliance, which does not verify the actual functionality of the driver. As a maintainer, I believe it is my responsibility to ensure that anyone enabling support for any SoC with this driver has tested its basic functionality. Please note, my intention is not to block anyone’s patches. To clarify, I am not asking you to provide any test reports. If you have already tested this series with v4l2-ctl or GST, please just mention it in your cover letter. Thanks, Dikshita > > so asking others of this is just unfair and unjustified obstacle. If you > have technical comments, then share. If you are just making fake > obstacles to stop some patchset then refrain from commenting. > > Unless you want statement like: > > > All patches have been tested with v4l2-compliance, v4l2-ctl and > Gstreamer on SM8750. > > Then I can give you such statement, just like you did for your patchset: > > All patches have been tested with v4l2-compliance, v4l2-ctl and > Gstreamer on SM8750. > > Best regards, > Krzysztof
On 12/08/2025 11:28, Dikshita Agarwal wrote: > As a maintainer, I believe it is my responsibility to ensure that anyone > enabling support for any SoC with this driver has tested its basic > functionality. Please note, my intention is not to block anyone’s patches. > > To clarify, I am not asking you to provide any test reports. If you have > already tested this series with v4l2-ctl or GST, please just mention it in > your cover letter. > > Thanks, > Dikshita >> >> so asking others of this is just unfair and unjustified obstacle. If you >> have technical comments, then share. If you are just making fake >> obstacles to stop some patchset then refrain from commenting. >> >> Unless you want statement like: >> >> >> All patches have been tested with v4l2-compliance, v4l2-ctl and >> Gstreamer on SM8750. >> >> Then I can give you such statement, just like you did for your patchset: >> >> All patches have been tested with v4l2-compliance, v4l2-ctl and >> Gstreamer on SM8750. I gave you the answer here. Best regards, Krzysztof
On 8/12/2025 3:06 PM, Krzysztof Kozlowski wrote: > On 12/08/2025 11:28, Dikshita Agarwal wrote: >> As a maintainer, I believe it is my responsibility to ensure that anyone >> enabling support for any SoC with this driver has tested its basic >> functionality. Please note, my intention is not to block anyone’s patches. >> >> To clarify, I am not asking you to provide any test reports. If you have >> already tested this series with v4l2-ctl or GST, please just mention it in >> your cover letter. >> >> Thanks, >> Dikshita >>> >>> so asking others of this is just unfair and unjustified obstacle. If you >>> have technical comments, then share. If you are just making fake >>> obstacles to stop some patchset then refrain from commenting. >>> >>> Unless you want statement like: >>> >>> >>> All patches have been tested with v4l2-compliance, v4l2-ctl and >>> Gstreamer on SM8750. >>> >>> Then I can give you such statement, just like you did for your patchset: >>> >>> All patches have been tested with v4l2-compliance, v4l2-ctl and >>> Gstreamer on SM8750. > > I gave you the answer here. Sure, Add this info in the cover letter for the next revision. Thanks, Dikshita > > Best regards, > Krzysztof
© 2016 - 2025 Red Hat, Inc.