[PATCH 63/65] media: ipu6: isys: Don't set V4L2_FL_USES_V4L2_FH manually

Jacopo Mondi posted 65 patches 2 months ago
[PATCH 63/65] media: ipu6: isys: Don't set V4L2_FL_USES_V4L2_FH manually
Posted by Jacopo Mondi 2 months ago
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant
to be set manually by drivers. Drop it from the ipu6-isys driver.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
index 24a2ef93474cc400f64eb1d50bc760ee66124d1b..f3f3bc0615e5dc698be5c479dfed8ef2eb49cbfb 100644
--- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
@@ -1306,7 +1306,6 @@ int ipu6_isys_video_init(struct ipu6_isys_video *av)
 	__ipu6_isys_vidioc_try_fmt_meta_cap(av, &format_meta);
 	av->meta_fmt = format_meta.fmt.meta;
 
-	set_bit(V4L2_FL_USES_V4L2_FH, &av->vdev.flags);
 	video_set_drvdata(&av->vdev, av);
 
 	ret = video_register_device(&av->vdev, VFL_TYPE_VIDEO, -1);

-- 
2.49.0
Re: [PATCH 63/65] media: ipu6: isys: Don't set V4L2_FL_USES_V4L2_FH manually
Posted by Sakari Ailus 1 month, 4 weeks ago
On Sat, Aug 02, 2025 at 11:23:25AM +0200, Jacopo Mondi wrote:
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant
> to be set manually by drivers. Drop it from the ipu6-isys driver.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
RE: [PATCH 63/65] media: ipu6: isys: Don't set V4L2_FL_USES_V4L2_FH manually
Posted by Cao, Bingbu 1 month, 4 weeks ago
Jacopo,

>-----Original Message-----
>From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>Sent: Saturday, August 2, 2025 5:23 PM
>To: Mauro Carvalho Chehab <mchehab@kernel.org>; Devarsh Thakkar
><devarsht@ti.com>; Benoit Parrot <bparrot@ti.com>; Hans Verkuil
><hverkuil@kernel.org>; Mike Isely <isely@pobox.com>; Laurent Pinchart
><laurent.pinchart@ideasonboard.com>; Hans de Goede <hansg@kernel.org>;
>Parthiban Veerasooran <parthiban.veerasooran@microchip.com>; Christian
>Gromm <christian.gromm@microchip.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; Alex Shi <alexs@kernel.org>; Yanteng Si
><si.yanteng@linux.dev>; Dongliang Mu <dzm91@hust.edu.cn>; Jonathan
>Corbet <corbet@lwn.net>; Tomasz Figa <tfiga@chromium.org>; Marek
>Szyprowski <m.szyprowski@samsung.com>; Andy Walls
><awalls@md.metrocast.net>; Michael Tretter <m.tretter@pengutronix.de>;
>Pengutronix Kernel Team <kernel@pengutronix.de>; Bin Liu
><bin.liu@mediatek.com>; Matthias Brugger <matthias.bgg@gmail.com>;
>AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>;
>Dmitry Osipenko <digetx@gmail.com>; Thierry Reding
><thierry.reding@gmail.com>; Jonathan Hunter <jonathanh@nvidia.com>;
>Mirela Rabulea <mirela.rabulea@nxp.com>; Shawn Guo
><shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Fabio
>Estevam <festevam@gmail.com>; Kieran Bingham
><kieran.bingham+renesas@ideasonboard.com>; Michal Simek
><michal.simek@amd.com>; Ming Qian <ming.qian@nxp.com>; Zhou Peng
><eagle.zhou@nxp.com>; Xavier Roumegue <xavier.roumegue@oss.nxp.com>;
>Philipp Zabel <p.zabel@pengutronix.de>; Vikash Garodia
><quic_vgarodia@quicinc.com>; Dikshita Agarwal
><quic_dikshita@quicinc.com>; Abhinav Kumar <abhinav.kumar@linux.dev>;
>Bryan O'Donoghue <bryan.odonoghue@linaro.org>; Sylwester Nawrocki
><sylvester.nawrocki@gmail.com>; Jernej Skrabec
><jernej.skrabec@gmail.com>; Chen-Yu Tsai <wens@csie.org>; Samuel
>Holland <samuel@sholland.org>; Daniel Almeida
><daniel.almeida@collabora.com>; Neil Armstrong
><neil.armstrong@linaro.org>; Kevin Hilman <khilman@baylibre.com>;
>Jerome Brunet <jbrunet@baylibre.com>; Martin Blumenstingl
><martin.blumenstingl@googlemail.com>; Nas Chung
><nas.chung@chipsnmedia.com>; Jackson Lee <jackson.lee@chipsnmedia.com>;
>Minghsiu Tsai <minghsiu.tsai@mediatek.com>; Houlong Wei
><houlong.wei@mediatek.com>; Andrew-CT Chen <andrew-
>ct.chen@mediatek.com>; Tiffany Lin <tiffany.lin@mediatek.com>; Yunfei
>Dong <yunfei.dong@mediatek.com>; Geert Uytterhoeven
><geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; Mikhail
>Ulyanov <mikhail.ulyanov@cogentembedded.com>; Jacob Chen <jacob-
>chen@iotwrt.com>; Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>;
>Heiko Stuebner <heiko@sntech.de>; Detlev Casanova
><detlev.casanova@collabora.com>; Krzysztof Kozlowski <krzk@kernel.org>;
>Alim Akhtar <alim.akhtar@samsung.com>; Sylwester Nawrocki
><s.nawrocki@samsung.com>; Łukasz Stelmach <l.stelmach@samsung.com>;
>Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>; Jacek Anaszewski
><jacek.anaszewski@gmail.com>; Hajda, Andrzej <andrzej.hajda@intel.com>;
>Fabien Dessenne <fabien.dessenne@foss.st.com>; Hugues Fruchet
><hugues.fruchet@foss.st.com>; Jean-Christophe Trotin <jean-
>christophe.trotin@foss.st.com>; Maxime Coquelin
><mcoquelin.stm32@gmail.com>; Alexandre Torgue
><alexandre.torgue@foss.st.com>; Nicolas Dufresne
><nicolas.dufresne@collabora.com>; Benjamin Gaignard
><benjamin.gaignard@collabora.com>; Steve Longerbeam
><slongerbeam@gmail.com>; Maxime Ripard <mripard@kernel.org>; Paul
>Kocialkowski <paulk@sys-base.io>; Niklas Söderlund
><niklas.soderlund@ragnatech.se>; Robert Foss <rfoss@kernel.org>; Todor
>Tomov <todor.too@gmail.com>; Vladimir Zapolskiy
><vladimir.zapolskiy@linaro.org>; Corentin Labbe <clabbe@baylibre.com>;
>Sakari Ailus <sakari.ailus@linux.intel.com>; Cao, Bingbu
><bingbu.cao@intel.com>; Qiu, Tian Shu <tian.shu.qiu@intel.com>;
>Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
>Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
>staging@lists.linux.dev; linux-doc@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org; linux-mediatek@lists.infradead.org; linux-
>tegra@vger.kernel.org; imx@lists.linux.dev; linux-renesas-
>soc@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux-samsung-
>soc@vger.kernel.org; linux-sunxi@lists.linux.dev; linux-
>usb@vger.kernel.org; linux-amlogic@lists.infradead.org; linux-
>rockchip@lists.infradead.org; linux-stm32@st-md-mailman.stormreply.com;
>mjpeg-users@lists.sourceforge.net; Jacopo Mondi
><jacopo.mondi@ideasonboard.com>
>Subject: [PATCH 63/65] media: ipu6: isys: Don't set
>V4L2_FL_USES_V4L2_FH manually
>
>From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant
>to be set manually by drivers. Drop it from the ipu6-isys driver.
>
>Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>---
> drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>index
>24a2ef93474cc400f64eb1d50bc760ee66124d1b..f3f3bc0615e5dc698be5c479dfed8
>ef2eb49cbfb 100644
>--- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>+++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
>@@ -1306,7 +1306,6 @@ int ipu6_isys_video_init(struct ipu6_isys_video
>*av)
> 	__ipu6_isys_vidioc_try_fmt_meta_cap(av, &format_meta);
> 	av->meta_fmt = format_meta.fmt.meta;
>
>-	set_bit(V4L2_FL_USES_V4L2_FH, &av->vdev.flags);
> 	video_set_drvdata(&av->vdev, av);
>
> 	ret = video_register_device(&av->vdev, VFL_TYPE_VIDEO, -1);
>
>--
>2.49.0

Thanks for the patch.

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>