accel/rocket: Fix build errors and sparse warning

[PATCH 0/2] accel/rocket: Fix build errors and sparse warning

Posted by Brigham Campbell 2 months ago

Fix two build errors in rockchip NPU support code which were caused by
the integration of recent changes in the drm subsystem.

Fix a sparse warning regarding an undeclared const, rocket_pm_ops.

I tested these changes by enabling DRM_ACCEL_ROCKET and recompiling with
`make C=2`.

Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
---
Brigham Campbell (2):
      accel/rocket: Fix Rockchip NPU compilation
      accel/rocket: Fix undeclared const rocket_pm_ops

 drivers/accel/rocket/rocket_drv.h | 2 ++
 drivers/accel/rocket/rocket_job.c | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
---
base-commit: 01ac6e4e53b6351df42c97d217b0d2dbeef5c917
change-id: 20250802-fix-rockchip-npu-build-ca759ba8da06

Best regards,
-- 
Brigham Campbell <me@brighamcampbell.com>

Re: [PATCH 0/2] accel/rocket: Fix build errors and sparse warning

Posted by Tomeu Vizoso 2 months ago

Hi Brigham,

thanks for the fixes. Will pick them up. Hope you don't mind if I
change the subject of the first patch to something a bit more
specific, such as:

accel/rocket: Adapt to changes in drm/sched API

Regards,

Tomeu

On Sat, Aug 2, 2025 at 9:25 PM Brigham Campbell <me@brighamcampbell.com> wrote:
>
> Fix two build errors in rockchip NPU support code which were caused by
> the integration of recent changes in the drm subsystem.
>
> Fix a sparse warning regarding an undeclared const, rocket_pm_ops.
>
> I tested these changes by enabling DRM_ACCEL_ROCKET and recompiling with
> `make C=2`.
>
> Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
> ---
> Brigham Campbell (2):
>       accel/rocket: Fix Rockchip NPU compilation
>       accel/rocket: Fix undeclared const rocket_pm_ops
>
>  drivers/accel/rocket/rocket_drv.h | 2 ++
>  drivers/accel/rocket/rocket_job.c | 4 ++--
>  2 files changed, 4 insertions(+), 2 deletions(-)
> ---
> base-commit: 01ac6e4e53b6351df42c97d217b0d2dbeef5c917
> change-id: 20250802-fix-rockchip-npu-build-ca759ba8da06
>
> Best regards,
> --
> Brigham Campbell <me@brighamcampbell.com>
>

Re: [PATCH 0/2] accel/rocket: Fix build errors and sparse warning

Posted by Brigham Campbell 2 months ago

On Sun Aug 3, 2025 at 9:33 AM MDT, Tomeu Vizoso wrote:
> thanks for the fixes. Will pick them up. Hope you don't mind if I
> change the subject of the first patch to something a bit more
> specific, such as:
>
> accel/rocket: Adapt to changes in drm/sched API

No, I don't mind at all. Go ahead and use your editorial discretion with
the shortlogs and commit messages. I'll put more thought into the patch
subject next time.

Thanks,
Brigham