dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

[PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

Posted by Rob Herring (Arm) 2 months ago

An interrupt-controller node which is the parent provider for
"interrupt-map" needs an "#address-cells" property. This fixes
"interrupt_map" warnings in new dtc.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
PCI maintainers, Please ack, I'll take this with the dtc update for 
6.18.

 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml    | 1 +
 .../devicetree/bindings/pci/marvell,armada-3700-pcie.yaml     | 4 ++++
 .../devicetree/bindings/pci/marvell,kirkwood-pcie.yaml        | 3 +++
 .../devicetree/bindings/pci/socionext,uniphier-pcie.yaml      | 4 ++++
 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 3 +++
 5 files changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
index 5434c144d2ec..18e7981241b5 100644
--- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
@@ -108,6 +108,7 @@ examples:
     #include <dt-bindings/interrupt-controller/arm-gic.h>
 
     gic: interrupt-controller {
+        #address-cells = <0>;
         interrupt-controller;
         #interrupt-cells = <3>;
     };
diff --git a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
index 68090b3ca419..8403c79634ed 100644
--- a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
@@ -42,6 +42,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
@@ -92,6 +95,7 @@ examples:
             reset-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
 
             pcie_intc: interrupt-controller {
+                #address-cells = <0>;
                 interrupt-controller;
                 #interrupt-cells = <1>;
             };
diff --git a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
index 7be695320ddf..3d68bfbe6feb 100644
--- a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
@@ -101,6 +101,9 @@ patternProperties:
         additionalProperties: false
 
         properties:
+          '#address-cells':
+            const: 0
+
           interrupt-controller: true
 
           '#interrupt-cells':
diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
index 638b99db0433..c07b0ed51613 100644
--- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
@@ -56,6 +56,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
@@ -109,6 +112,7 @@ examples:
                         <0 0 0  4  &pcie_intc 3>;
 
         pcie_intc: interrupt-controller {
+            #address-cells = <0>;
             interrupt-controller;
             #interrupt-cells = <1>;
             interrupt-parent = <&gic>;
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 69b499c96c71..c704099f134b 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -99,6 +99,9 @@ properties:
     additionalProperties: false
 
     properties:
+      '#address-cells':
+        const: 0
+
       interrupt-controller: true
 
       '#interrupt-cells':
-- 
2.47.2

Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

Posted by Bjorn Helgaas 2 months ago

On Fri, Aug 01, 2025 at 03:07:27PM -0500, Rob Herring (Arm) wrote:
> An interrupt-controller node which is the parent provider for
> "interrupt-map" needs an "#address-cells" property. This fixes
> "interrupt_map" warnings in new dtc.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---
> PCI maintainers, Please ack, I'll take this with the dtc update for 
> 6.18.
> 
>  Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml    | 1 +
>  .../devicetree/bindings/pci/marvell,armada-3700-pcie.yaml     | 4 ++++
>  .../devicetree/bindings/pci/marvell,kirkwood-pcie.yaml        | 3 +++
>  .../devicetree/bindings/pci/socionext,uniphier-pcie.yaml      | 4 ++++
>  Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml  | 3 +++
>  5 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> index 5434c144d2ec..18e7981241b5 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
> @@ -108,6 +108,7 @@ examples:
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>  
>      gic: interrupt-controller {
> +        #address-cells = <0>;
>          interrupt-controller;
>          #interrupt-cells = <3>;
>      };
> diff --git a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> index 68090b3ca419..8403c79634ed 100644
> --- a/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/marvell,armada-3700-pcie.yaml
> @@ -42,6 +42,9 @@ properties:
>      additionalProperties: false
>  
>      properties:
> +      '#address-cells':
> +        const: 0
> +
>        interrupt-controller: true
>  
>        '#interrupt-cells':
> @@ -92,6 +95,7 @@ examples:
>              reset-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
>  
>              pcie_intc: interrupt-controller {
> +                #address-cells = <0>;
>                  interrupt-controller;
>                  #interrupt-cells = <1>;
>              };
> diff --git a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> index 7be695320ddf..3d68bfbe6feb 100644
> --- a/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/marvell,kirkwood-pcie.yaml
> @@ -101,6 +101,9 @@ patternProperties:
>          additionalProperties: false
>  
>          properties:
> +          '#address-cells':
> +            const: 0
> +
>            interrupt-controller: true
>  
>            '#interrupt-cells':
> diff --git a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> index 638b99db0433..c07b0ed51613 100644
> --- a/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/socionext,uniphier-pcie.yaml
> @@ -56,6 +56,9 @@ properties:
>      additionalProperties: false
>  
>      properties:
> +      '#address-cells':
> +        const: 0
> +
>        interrupt-controller: true
>  
>        '#interrupt-cells':
> @@ -109,6 +112,7 @@ examples:
>                          <0 0 0  4  &pcie_intc 3>;
>  
>          pcie_intc: interrupt-controller {
> +            #address-cells = <0>;
>              interrupt-controller;
>              #interrupt-cells = <1>;
>              interrupt-parent = <&gic>;
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 69b499c96c71..c704099f134b 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -99,6 +99,9 @@ properties:
>      additionalProperties: false
>  
>      properties:
> +      '#address-cells':
> +        const: 0
> +
>        interrupt-controller: true
>  
>        '#interrupt-cells':
> -- 
> 2.47.2
>

Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

Posted by Manivannan Sadhasivam 1 month, 3 weeks ago

On Fri, 01 Aug 2025 15:07:27 -0500, Rob Herring (Arm) wrote:
> An interrupt-controller node which is the parent provider for
> "interrupt-map" needs an "#address-cells" property. This fixes
> "interrupt_map" warnings in new dtc.
> 
> 

Applied, thanks!

[1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
      commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56

Best regards,
-- 
Manivannan Sadhasivam <mani@kernel.org>

Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

Posted by Rob Herring 1 month, 3 weeks ago

On Mon, Aug 11, 2025 at 5:46 AM Manivannan Sadhasivam
<manivannan.sadhasivam@oss.qualcomm.com> wrote:
>
>
> On Fri, 01 Aug 2025 15:07:27 -0500, Rob Herring (Arm) wrote:
> > An interrupt-controller node which is the parent provider for
> > "interrupt-map" needs an "#address-cells" property. This fixes
> > "interrupt_map" warnings in new dtc.
> >
> >
>
> Applied, thanks!
>
> [1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
>       commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56

Please read the commit message.

I've already applied this to my tree.

Rob

Re: [PATCH] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers

Posted by Manivannan Sadhasivam 1 month, 3 weeks ago

On Mon, Aug 11, 2025 at 08:07:31AM GMT, Rob Herring wrote:
> On Mon, Aug 11, 2025 at 5:46 AM Manivannan Sadhasivam
> <manivannan.sadhasivam@oss.qualcomm.com> wrote:
> >
> >
> > On Fri, 01 Aug 2025 15:07:27 -0500, Rob Herring (Arm) wrote:
> > > An interrupt-controller node which is the parent provider for
> > > "interrupt-map" needs an "#address-cells" property. This fixes
> > > "interrupt_map" warnings in new dtc.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [1/1] dt-bindings: PCI: Add missing "#address-cells" to interrupt controllers
> >       commit: ddb81c5c911227f0c2ef4cc94a106ebfb3cb2d56
> 
> Please read the commit message.
> 
> I've already applied this to my tree.
> 

Sorry, didn't notice it. Dropped the patch from PCI tree now.

- Mani

-- 
மணிவண்ணன் சதாசிவம்