[v2] staging: rtl8723bs: get rid of os_dep/mlme_linux.c

[PATCH v2 0/8] staging: rtl8723bs: get rid of os_dep/mlme_linux.c

Michael Straube posted 8 patches 2 months ago

Diff against v1
Download series mbox

drivers/staging/rtl8723bs/Makefile            |   1 -
drivers/staging/rtl8723bs/core/rtw_mlme.c     | 151 ++++++++++++++-
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |   9 +
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c  |   2 +-
drivers/staging/rtl8723bs/include/drv_types.h |   1 -
.../staging/rtl8723bs/include/mlme_osdep.h    |  19 --
drivers/staging/rtl8723bs/include/rtw_mlme.h  |   1 +
.../staging/rtl8723bs/include/rtw_mlme_ext.h  |   2 -
drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 179 ------------------
9 files changed, 155 insertions(+), 210 deletions(-)
delete mode 100644 drivers/staging/rtl8723bs/include/mlme_osdep.h
delete mode 100644 drivers/staging/rtl8723bs/os_dep/mlme_linux.c

Expand all Fold all

[PATCH v2 0/8] staging: rtl8723bs: get rid of os_dep/mlme_linux.c

Posted by Michael Straube 2 months ago

This series moves/merges the functions/functionality of os_dep/mlme_linux.c
into the corresponding parts of the driver in the core directory to reduce
"os dependent" code.

The patches have been compile-tested only due to lack of hardware.

v1 -> v2: added back accidently removed tabs in patch 3/8

Michael Straube (8):
  staging: rtl8723bs: remove wrapper rtw_os_indicate_scan_done
  staging: rtl8723bs: move init_mlme_ext_timer to core/rtw_mlme_ext.c
  staging: rtl8723bs: move rtw_init_mlme_timer to core/rtw_mlme.c
  staging: rtl8723bs: remove wrapper init_addba_retry_timer
  staging: rtl8723bs: merge rtw_os_indicate_connect into
    rtw_indicate_connect
  staging: rtl8723bs: merge rtw_os_indicate_disconnect into
    rtw_indicate_disconnect
  staging: rtl8723bs: move rtw_report_sec_ie to core/rtw_mlme.c
  staging: rtl8723bs: move rtw_reset_securitypriv to core/rtw_mlme.c

 drivers/staging/rtl8723bs/Makefile            |   1 -
 drivers/staging/rtl8723bs/core/rtw_mlme.c     | 151 ++++++++++++++-
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |   9 +
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c  |   2 +-
 drivers/staging/rtl8723bs/include/drv_types.h |   1 -
 .../staging/rtl8723bs/include/mlme_osdep.h    |  19 --
 drivers/staging/rtl8723bs/include/rtw_mlme.h  |   1 +
 .../staging/rtl8723bs/include/rtw_mlme_ext.h  |   2 -
 drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 179 ------------------
 9 files changed, 155 insertions(+), 210 deletions(-)
 delete mode 100644 drivers/staging/rtl8723bs/include/mlme_osdep.h
 delete mode 100644 drivers/staging/rtl8723bs/os_dep/mlme_linux.c

-- 
2.50.1

Re: [PATCH v2 0/8] staging: rtl8723bs: get rid of os_dep/mlme_linux.c

Posted by Hans de Goede 2 months ago

Hi Michael,

On 1-Aug-25 10:31 AM, Michael Straube wrote:
> This series moves/merges the functions/functionality of os_dep/mlme_linux.c
> into the corresponding parts of the driver in the core directory to reduce
> "os dependent" code.
> 
> The patches have been compile-tested only due to lack of hardware.
> 
> v1 -> v2: added back accidently removed tabs in patch 3/8
> 
> Michael Straube (8):
>   staging: rtl8723bs: remove wrapper rtw_os_indicate_scan_done
>   staging: rtl8723bs: move init_mlme_ext_timer to core/rtw_mlme_ext.c
>   staging: rtl8723bs: move rtw_init_mlme_timer to core/rtw_mlme.c
>   staging: rtl8723bs: remove wrapper init_addba_retry_timer
>   staging: rtl8723bs: merge rtw_os_indicate_connect into
>     rtw_indicate_connect
>   staging: rtl8723bs: merge rtw_os_indicate_disconnect into
>     rtw_indicate_disconnect
>   staging: rtl8723bs: move rtw_report_sec_ie to core/rtw_mlme.c
>   staging: rtl8723bs: move rtw_reset_securitypriv to core/rtw_mlme.c

Thank you for your continued work on improving the rtl8723bs driver.

I've given these patches a test-spin on a tablet with
a rtl8723bs wifi module (on top of your previous patches).

The patches work and they look good to me:

Tested-by: Hans de Goede <hansg@kernel.org>
Reviewed-by: Hans de Goede <hansg@kernel.org>

for the series.

Regards,

Hans