Rename drm_writeback_connector_init_with_encoder() to
drm_writeback_connector_init() and adapt its interface to follow
drmm_writeback_connector_init().
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/gpu/drm/drm_writeback.c | 14 +++++++-------
include/drm/drm_writeback.h | 10 +++++-----
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
index 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b0595322e2202a0cf9865 100644
--- a/drivers/gpu/drm/drm_writeback.c
+++ b/drivers/gpu/drm/drm_writeback.c
@@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_device *dev,
}
/**
- * drm_writeback_connector_init_with_encoder - Initialize a writeback connector with
+ * drm_writeback_connector_init - Initialize a writeback connector with
* a custom encoder
*
* @dev: DRM device
@@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_device *dev,
*
* Returns: 0 on success, or a negative error code
*/
-int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
- struct drm_writeback_connector *wb_connector,
- struct drm_encoder *enc,
- const struct drm_connector_funcs *con_funcs,
- const u32 *formats, int n_formats)
+int drm_writeback_connector_init(struct drm_device *dev,
+ struct drm_writeback_connector *wb_connector,
+ const struct drm_connector_funcs *con_funcs,
+ struct drm_encoder *enc,
+ const u32 *formats, int n_formats)
{
struct drm_connector *connector = &wb_connector->base;
int ret;
@@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
return ret;
}
-EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder);
+EXPORT_SYMBOL(drm_writeback_connector_init);
/**
* drm_writeback_connector_cleanup - Cleanup the writeback connector
diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
index 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc11f9e841316d21b 100644
--- a/include/drm/drm_writeback.h
+++ b/include/drm/drm_writeback.h
@@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *connector)
return container_of(connector, struct drm_writeback_connector, base);
}
-int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
- struct drm_writeback_connector *wb_connector,
- struct drm_encoder *enc,
- const struct drm_connector_funcs *con_funcs, const u32 *formats,
- int n_formats);
+int drm_writeback_connector_init(struct drm_device *dev,
+ struct drm_writeback_connector *wb_connector,
+ const struct drm_connector_funcs *con_funcs,
+ struct drm_encoder *enc,
+ const u32 *formats, int n_formats);
int drmm_writeback_connector_init(struct drm_device *dev,
struct drm_writeback_connector *wb_connector,
--
2.39.5
Le 01/08/2025 à 15:51, Dmitry Baryshkov a écrit :
> Rename drm_writeback_connector_init_with_encoder() to
> drm_writeback_connector_init() and adapt its interface to follow
> drmm_writeback_connector_init().
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> drivers/gpu/drm/drm_writeback.c | 14 +++++++-------
> include/drm/drm_writeback.h | 10 +++++-----
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
> index 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b0595322e2202a0cf9865 100644
> --- a/drivers/gpu/drm/drm_writeback.c
> +++ b/drivers/gpu/drm/drm_writeback.c
> @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_device *dev,
> }
>
> /**
> - * drm_writeback_connector_init_with_encoder - Initialize a writeback connector with
> + * drm_writeback_connector_init - Initialize a writeback connector with
> * a custom encoder
If I understood correctly your series you want to reduce the usage of
non-drmm writeback, so maybe we can add a comment to direct poeple to
drmm variant to avoid new usage of this API?
With or without this:
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> *
> * @dev: DRM device
> @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_device *dev,
> *
> * Returns: 0 on success, or a negative error code
> */
> -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> - struct drm_writeback_connector *wb_connector,
> - struct drm_encoder *enc,
> - const struct drm_connector_funcs *con_funcs,
> - const u32 *formats, int n_formats)
> +int drm_writeback_connector_init(struct drm_device *dev,
> + struct drm_writeback_connector *wb_connector,
> + const struct drm_connector_funcs *con_funcs,
> + struct drm_encoder *enc,
> + const u32 *formats, int n_formats)
> {
> struct drm_connector *connector = &wb_connector->base;
> int ret;
> @@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
>
> return ret;
> }
> -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder);
> +EXPORT_SYMBOL(drm_writeback_connector_init);
>
> /**
> * drm_writeback_connector_cleanup - Cleanup the writeback connector
> diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
> index 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc11f9e841316d21b 100644
> --- a/include/drm/drm_writeback.h
> +++ b/include/drm/drm_writeback.h
> @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *connector)
> return container_of(connector, struct drm_writeback_connector, base);
> }
>
> -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> - struct drm_writeback_connector *wb_connector,
> - struct drm_encoder *enc,
> - const struct drm_connector_funcs *con_funcs, const u32 *formats,
> - int n_formats);
> +int drm_writeback_connector_init(struct drm_device *dev,
> + struct drm_writeback_connector *wb_connector,
> + const struct drm_connector_funcs *con_funcs,
> + struct drm_encoder *enc,
> + const u32 *formats, int n_formats);
>
> int drmm_writeback_connector_init(struct drm_device *dev,
> struct drm_writeback_connector *wb_connector,
>
--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
> Subject: Re: [PATCH 8/8] drm: writeback: rename
> drm_writeback_connector_init_with_encoder()
Same here drm/writeback
Regards,
Suraj Kandpal
>
>
>
> Le 01/08/2025 à 15:51, Dmitry Baryshkov a écrit :
> > Rename drm_writeback_connector_init_with_encoder() to
> > drm_writeback_connector_init() and adapt its interface to follow
> > drmm_writeback_connector_init().
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
> > drivers/gpu/drm/drm_writeback.c | 14 +++++++-------
> > include/drm/drm_writeback.h | 10 +++++-----
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_writeback.c
> > b/drivers/gpu/drm/drm_writeback.c index
> >
> 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b05953
> 22e
> > 2202a0cf9865 100644
> > --- a/drivers/gpu/drm/drm_writeback.c
> > +++ b/drivers/gpu/drm/drm_writeback.c
> > @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> > }
> >
> > /**
> > - * drm_writeback_connector_init_with_encoder - Initialize a writeback
> > connector with
> > + * drm_writeback_connector_init - Initialize a writeback connector
> > + with
> > * a custom encoder
>
> If I understood correctly your series you want to reduce the usage of non-
> drmm writeback, so maybe we can add a comment to direct poeple to drmm
> variant to avoid new usage of this API?
>
> With or without this:
>
> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
>
> > *
> > * @dev: DRM device
> > @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> > *
> > * Returns: 0 on success, or a negative error code
> > */
> > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > - struct drm_writeback_connector
> *wb_connector,
> > - struct drm_encoder *enc,
> > - const struct drm_connector_funcs
> *con_funcs,
> > - const u32 *formats, int n_formats)
> > +int drm_writeback_connector_init(struct drm_device *dev,
> > + struct drm_writeback_connector
> *wb_connector,
> > + const struct drm_connector_funcs
> *con_funcs,
> > + struct drm_encoder *enc,
> > + const u32 *formats, int n_formats)
> > {
> > struct drm_connector *connector = &wb_connector->base;
> > int ret;
> > @@ -284,7 +284,7 @@ int
> > drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> >
> > return ret;
> > }
> > -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder);
> > +EXPORT_SYMBOL(drm_writeback_connector_init);
> >
> > /**
> > * drm_writeback_connector_cleanup - Cleanup the writeback connector
> > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
> > index
> >
> 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc1
> 1f
> > 9e841316d21b 100644
> > --- a/include/drm/drm_writeback.h
> > +++ b/include/drm/drm_writeback.h
> > @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct
> drm_connector *connector)
> > return container_of(connector, struct drm_writeback_connector, base);
> > }
> >
> > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > - struct drm_writeback_connector
> *wb_connector,
> > - struct drm_encoder *enc,
> > - const struct drm_connector_funcs
> *con_funcs, const u32 *formats,
> > - int n_formats);
> > +int drm_writeback_connector_init(struct drm_device *dev,
> > + struct drm_writeback_connector
> *wb_connector,
> > + const struct drm_connector_funcs
> *con_funcs,
> > + struct drm_encoder *enc,
> > + const u32 *formats, int n_formats);
> >
> > int drmm_writeback_connector_init(struct drm_device *dev,
> > struct drm_writeback_connector
> *wb_connector,
> >
>
> --
> Louis Chauvet, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> > ---
> > drivers/gpu/drm/drm_writeback.c | 14 +++++++-------
> > include/drm/drm_writeback.h | 10 +++++-----
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_writeback.c
> > b/drivers/gpu/drm/drm_writeback.c index
> >
> 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b05953
> 22e
> > 2202a0cf9865 100644
> > --- a/drivers/gpu/drm/drm_writeback.c
> > +++ b/drivers/gpu/drm/drm_writeback.c
> > @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> > }
> >
> > /**
> > - * drm_writeback_connector_init_with_encoder - Initialize a writeback
> > connector with
> > + * drm_writeback_connector_init - Initialize a writeback connector
> > + with
> > * a custom encoder
>
> If I understood correctly your series you want to reduce the usage of non-
> drmm writeback, so maybe we can add a comment to direct poeple to drmm
> variant to avoid new usage of this API?
>
> With or without this:
>
> Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
>
> > *
> > * @dev: DRM device
> > @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct
> drm_device *dev,
> > *
> > * Returns: 0 on success, or a negative error code
> > */
> > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > - struct drm_writeback_connector
> *wb_connector,
> > - struct drm_encoder *enc,
> > - const struct drm_connector_funcs
> *con_funcs,
> > - const u32 *formats, int n_formats)
> > +int drm_writeback_connector_init(struct drm_device *dev,
> > + struct drm_writeback_connector
> *wb_connector,
> > + const struct drm_connector_funcs
> *con_funcs,
> > + struct drm_encoder *enc,
> > + const u32 *formats, int n_formats)
> > {
> > struct drm_connector *connector = &wb_connector->base;
> > int ret;
> > @@ -284,7 +284,7 @@ int
> > drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> >
> > return ret;
> > }
> > -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder);
> > +EXPORT_SYMBOL(drm_writeback_connector_init);
> >
> > /**
> > * drm_writeback_connector_cleanup - Cleanup the writeback connector
> > diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h
> > index
> >
> 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc1
> 1f
> > 9e841316d21b 100644
> > --- a/include/drm/drm_writeback.h
> > +++ b/include/drm/drm_writeback.h
> > @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct
> drm_connector *connector)
> > return container_of(connector, struct drm_writeback_connector, base);
> > }
> >
> > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > - struct drm_writeback_connector
> *wb_connector,
> > - struct drm_encoder *enc,
> > - const struct drm_connector_funcs
> *con_funcs, const u32 *formats,
> > - int n_formats);
> > +int drm_writeback_connector_init(struct drm_device *dev,
> > + struct drm_writeback_connector
> *wb_connector,
> > + const struct drm_connector_funcs
> *con_funcs,
> > + struct drm_encoder *enc,
> > + const u32 *formats, int n_formats);
> >
> > int drmm_writeback_connector_init(struct drm_device *dev,
> > struct drm_writeback_connector
> *wb_connector,
> >
>
> --
> Louis Chauvet, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> -----Original Message-----
> From: Kandpal, Suraj
> Sent: Friday, August 8, 2025 10:35 AM
> To: Louis Chauvet <louis.chauvet@bootlin.com>; Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com>; Jani Nikula
> <jani.nikula@linux.intel.com>; Harry Wentland <harry.wentland@amd.com>;
> Leo Li <sunpeng.li@amd.com>; Rodrigo Siqueira <siqueira@igalia.com>; Alex
> Deucher <alexander.deucher@amd.com>; Christian König
> <christian.koenig@amd.com>; David Airlie <airlied@gmail.com>; Simona Vetter
> <simona@ffwll.ch>; Liviu Dudau <liviu.dudau@arm.com>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>;
> Thomas Zimmermann <tzimmermann@suse.de>; Rob Clark
> <robin.clark@oss.qualcomm.com>; Dmitry Baryshkov <lumag@kernel.org>;
> Abhinav Kumar <abhinav.kumar@linux.dev>; Jessica Zhang
> <jessica.zhang@oss.qualcomm.com>; Sean Paul <sean@poorly.run>; Marijn
> Suijten <marijn.suijten@somainline.org>; Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com>; Tomi Valkeinen
> <tomi.valkeinen+renesas@ideasonboard.com>; Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>; Geert Uytterhoeven
> <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>;
> Dave Stevenson <dave.stevenson@raspberrypi.com>; Maíra Canal
> <mcanal@igalia.com>; Raspberry Pi Kernel Maintenance <kernel-
> list@raspberrypi.com>
> Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org;
> freedreno@lists.freedesktop.org; linux-renesas-soc@vger.kernel.org
> Subject: RE: [PATCH 8/8] drm: writeback: rename
> drm_writeback_connector_init_with_encoder()
>
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
> LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
One thing I noticed was after the Rename both drm_writeback_connector_init
And drmm_writeback_connector_init have identical comments both allowing custom encoders
To be used now is that what we were aiming for with the only difference being the
ret = drmm_add_action_or_reset(dev, drm_writeback_connector_cleanup,
wb_connector);
call ?
Regards,
Suraj Kandpal
>
> > > ---
> > > drivers/gpu/drm/drm_writeback.c | 14 +++++++-------
> > > include/drm/drm_writeback.h | 10 +++++-----
> > > 2 files changed, 12 insertions(+), 12 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/drm_writeback.c
> > > b/drivers/gpu/drm/drm_writeback.c index
> > >
> >
> 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b05953
> > 22e
> > > 2202a0cf9865 100644
> > > --- a/drivers/gpu/drm/drm_writeback.c
> > > +++ b/drivers/gpu/drm/drm_writeback.c
> > > @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct
> > drm_device *dev,
> > > }
> > >
> > > /**
> > > - * drm_writeback_connector_init_with_encoder - Initialize a
> > > writeback connector with
> > > + * drm_writeback_connector_init - Initialize a writeback connector
> > > + with
> > > * a custom encoder
> >
> > If I understood correctly your series you want to reduce the usage of
> > non- drmm writeback, so maybe we can add a comment to direct poeple to
> > drmm variant to avoid new usage of this API?
> >
> > With or without this:
> >
> > Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> >
> > > *
> > > * @dev: DRM device
> > > @@ -263,11 +263,11 @@ static int
> > > __drm_writeback_connector_init(struct
> > drm_device *dev,
> > > *
> > > * Returns: 0 on success, or a negative error code
> > > */
> > > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > > - struct drm_writeback_connector
> > *wb_connector,
> > > - struct drm_encoder *enc,
> > > - const struct drm_connector_funcs
> > *con_funcs,
> > > - const u32 *formats, int n_formats)
> > > +int drm_writeback_connector_init(struct drm_device *dev,
> > > + struct drm_writeback_connector
> > *wb_connector,
> > > + const struct drm_connector_funcs
> > *con_funcs,
> > > + struct drm_encoder *enc,
> > > + const u32 *formats, int n_formats)
> > > {
> > > struct drm_connector *connector = &wb_connector->base;
> > > int ret;
> > > @@ -284,7 +284,7 @@ int
> > > drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > >
> > > return ret;
> > > }
> > > -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder);
> > > +EXPORT_SYMBOL(drm_writeback_connector_init);
> > >
> > > /**
> > > * drm_writeback_connector_cleanup - Cleanup the writeback
> > > connector diff --git a/include/drm/drm_writeback.h
> > > b/include/drm/drm_writeback.h index
> > >
> >
> 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc1
> > 1f
> > > 9e841316d21b 100644
> > > --- a/include/drm/drm_writeback.h
> > > +++ b/include/drm/drm_writeback.h
> > > @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct
> > drm_connector *connector)
> > > return container_of(connector, struct drm_writeback_connector, base);
> > > }
> > >
> > > -int drm_writeback_connector_init_with_encoder(struct drm_device *dev,
> > > - struct drm_writeback_connector
> > *wb_connector,
> > > - struct drm_encoder *enc,
> > > - const struct drm_connector_funcs
> > *con_funcs, const u32 *formats,
> > > - int n_formats);
> > > +int drm_writeback_connector_init(struct drm_device *dev,
> > > + struct drm_writeback_connector
> > *wb_connector,
> > > + const struct drm_connector_funcs
> > *con_funcs,
> > > + struct drm_encoder *enc,
> > > + const u32 *formats, int n_formats);
> > >
> > > int drmm_writeback_connector_init(struct drm_device *dev,
> > > struct drm_writeback_connector
> > *wb_connector,
> > >
> >
> > --
> > Louis Chauvet, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
On Fri, Aug 08, 2025 at 05:24:19AM +0000, Kandpal, Suraj wrote: > > > > -----Original Message----- > > From: Kandpal, Suraj > > Sent: Friday, August 8, 2025 10:35 AM [...] > > Subject: RE: [PATCH 8/8] drm: writeback: rename > > drm_writeback_connector_init_with_encoder() Please fix your email setup to not include this splats. > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > > > > LGTM, > > Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com> > > One thing I noticed was after the Rename both drm_writeback_connector_init > And drmm_writeback_connector_init have identical comments both allowing custom encoders > To be used now is that what we were aiming for with the only difference being the > ret = drmm_add_action_or_reset(dev, drm_writeback_connector_cleanup, > wb_connector); > call ? No, there is also a difference in drm_connector_init() vs drmm_connector_init(). -- With best wishes Dmitry
© 2016 - 2025 Red Hat, Inc.