[PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property

Julien Massot posted 9 patches 2 months ago
There is a newer version of this series
[PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
Posted by Julien Massot 2 months ago
The mt8183-mfgcfg node uses a power domain in its device tree node.
To prevent schema validation warnings, add the optional `power-domains`
property to the binding schema for mediatek syscon clocks.

Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 Documentation/devicetree/bindings/clock/mediatek,syscon.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
index a86a64893c675ac134af609b3a49242565db6ad8..1011bc46cfcb97b90b86019e95a7e4bc8a819342 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
@@ -76,6 +76,9 @@ properties:
           - const: mediatek,mt2701-vdecsys
           - const: syscon
 
+  power-domains:
+    maxItems: 1
+
   reg:
     maxItems: 1
 

-- 
2.50.1
Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
Posted by Rob Herring (Arm) 2 months ago
On Fri, 01 Aug 2025 13:18:03 +0200, Julien Massot wrote:
> The mt8183-mfgcfg node uses a power domain in its device tree node.
> To prevent schema validation warnings, add the optional `power-domains`
> property to the binding schema for mediatek syscon clocks.
> 
> Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
>  Documentation/devicetree/bindings/clock/mediatek,syscon.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
Posted by AngeloGioacchino Del Regno 2 months ago
Il 01/08/25 13:18, Julien Massot ha scritto:
> The mt8183-mfgcfg node uses a power domain in its device tree node.
> To prevent schema validation warnings, add the optional `power-domains`
> property to the binding schema for mediatek syscon clocks.
> 
> Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>

Is MT8183 the only one?

if:
   properties:
     compatible:
       contains:
         - const: mediatek,mt8183-mfgcfg
         ^^^^^^^(if it's not just mt8183, this should be an enum)

then:
   properties:
     power-domains: true
else:
   properties:
     power-domains: false

(check if the above is correct, don't blindly trust what I wrote! :P)

after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

(if it's not only mt8183, keep the R-b on this commit regardless)

Cheers,
Angelo

> ---
>   Documentation/devicetree/bindings/clock/mediatek,syscon.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
> index a86a64893c675ac134af609b3a49242565db6ad8..1011bc46cfcb97b90b86019e95a7e4bc8a819342 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
> @@ -76,6 +76,9 @@ properties:
>             - const: mediatek,mt2701-vdecsys
>             - const: syscon
>   
> +  power-domains:
> +    maxItems: 1
> +
>     reg:
>       maxItems: 1
>   
>
Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
Posted by Julien Massot 1 month, 2 weeks ago
Hi Angelo,

On Mon, 2025-08-04 at 09:59 +0200, AngeloGioacchino Del Regno wrote:
> Il 01/08/25 13:18, Julien Massot ha scritto:
> > The mt8183-mfgcfg node uses a power domain in its device tree node.
> > To prevent schema validation warnings, add the optional `power-domains`
> > property to the binding schema for mediatek syscon clocks.
> > 
> > Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> 
> Is MT8183 the only one?
> 
> if:
>    properties:
>      compatible:
>        contains:
>          - const: mediatek,mt8183-mfgcfg
>          ^^^^^^^(if it's not just mt8183, this should be an enum)
> 
> then:
>    properties:
>      power-domains: true
> else:
>    properties:
>      power-domains: false
> 
> (check if the above is correct, don't blindly trust what I wrote! :P)
> 
> 
Verified on my side 'mediatek,mt8183-mfgcfg' is the only one with a power-domain
property.
I will add the if/else and disable the power-domains property for other compatible
as suggested.

> 
> after which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> (if it's not only mt8183, keep the R-b on this commit regardless)
Thanks,

Julien