thunderbolt: HMAC fix and cleanup

[PATCH 0/2] thunderbolt: HMAC fix and cleanup

Eric Biggers posted 2 patches 2 months ago

Download series mbox

drivers/thunderbolt/Kconfig  |  4 ++--
drivers/thunderbolt/domain.c | 45 ++++++------------------------------
2 files changed, 9 insertions(+), 40 deletions(-)

Expand all Fold all

[PATCH 0/2] thunderbolt: HMAC fix and cleanup

Posted by Eric Biggers 2 months ago

Patch 1 fixes the HMAC comparison in the thunderbolt driver to be
constant-time.

Patch 2 simplifies the HMAC computation in the thunderbolt driver by
using the library API instead of crypto_shash.  Note that this depends
on the HMAC-SHA256 library API that was merged for v6.17-rc1.

Eric Biggers (2):
  thunderbolt: Compare HMAC values in constant time
  thunderbolt: Use HMAC-SHA256 library instead of crypto_shash

 drivers/thunderbolt/Kconfig  |  4 ++--
 drivers/thunderbolt/domain.c | 45 ++++++------------------------------
 2 files changed, 9 insertions(+), 40 deletions(-)


base-commit: d6084bb815c453de27af8071a23163a711586a6c
-- 
2.50.1

Re: [PATCH 0/2] thunderbolt: HMAC fix and cleanup

Posted by Mika Westerberg 1 month, 3 weeks ago

On Thu, Jul 31, 2025 at 12:25:43PM -0700, Eric Biggers wrote:
> Patch 1 fixes the HMAC comparison in the thunderbolt driver to be
> constant-time.
> 
> Patch 2 simplifies the HMAC computation in the thunderbolt driver by
> using the library API instead of crypto_shash.  Note that this depends
> on the HMAC-SHA256 library API that was merged for v6.17-rc1.
> 
> Eric Biggers (2):
>   thunderbolt: Compare HMAC values in constant time
>   thunderbolt: Use HMAC-SHA256 library instead of crypto_shash

Both applied to thunderbolt.git/next, thanks!