[PATCH] afs: Remove erroneous seq |= 1 in volume lookup loop

lirongqing posted 1 patch 2 months ago
There is a newer version of this series
fs/afs/callback.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] afs: Remove erroneous seq |= 1 in volume lookup loop
Posted by lirongqing 2 months ago
From: Li RongQing <lirongqing@baidu.com>

The seq |= 1 operation is incorrect here because seq has been
increased at start, it will be odd in next iteration and cause
lock operation

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 fs/afs/callback.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/afs/callback.c b/fs/afs/callback.c
index 69e1dd5..2c0d274 100644
--- a/fs/afs/callback.c
+++ b/fs/afs/callback.c
@@ -140,7 +140,6 @@ static struct afs_volume *afs_lookup_volume_rcu(struct afs_cell *cell,
 			break;
 		if (!need_seqretry(&cell->volume_lock, seq))
 			break;
-		seq |= 1; /* Want a lock next time */
 	}
 
 	done_seqretry(&cell->volume_lock, seq);
-- 
2.9.4