net: wireless: rt2x00: fix CRC_CCITT dependency

[PATCH] net: wireless: rt2x00: fix CRC_CCITT dependency

Posted by Arnd Bergmann 2 months ago

From: Arnd Bergmann <arnd@arndb.de>

Compile-testing this driver on Arm platforms shows a link failure
when the CRC functions are not part of the kernel:

x86_64-linux-ld: drivers/net/wireless/ralink/rt2x00/rt2800lib.o: in function `rt2800_check_firmware':
rt2800lib.c:(.text+0x20e5): undefined reference to `crc_ccitt'

Move the select statement to the correct Kconfig symbol to match
the call site.

Fixes: 311b05e235cf ("wifi: rt2x00: add COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/ralink/rt2x00/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/Kconfig b/drivers/net/wireless/ralink/rt2x00/Kconfig
index d66fc839c3ce..17f063fc0b57 100644
--- a/drivers/net/wireless/ralink/rt2x00/Kconfig
+++ b/drivers/net/wireless/ralink/rt2x00/Kconfig
@@ -66,7 +66,6 @@ config RT2800PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select RT2X00_LIB_CRYPTO
-	select CRC_CCITT
 	select EEPROM_93CX6
 	help
 	  This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
@@ -142,7 +141,6 @@ config RT2800USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	select RT2X00_LIB_CRYPTO
-	select CRC_CCITT
 	help
 	  This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
 	  Supported chips: RT2770, RT2870 & RT3070, RT3071 & RT3072
@@ -217,6 +215,7 @@ config RT2800SOC
 
 config RT2800_LIB
 	tristate
+	select CRC_CCITT
 
 config RT2800_LIB_MMIO
 	tristate
-- 
2.39.5

Re: [PATCH] net: wireless: rt2x00: fix CRC_CCITT dependency

Posted by Stanislaw Gruszka 2 months ago

On Thu, Jul 31, 2025 at 09:58:33AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing this driver on Arm platforms shows a link failure
> when the CRC functions are not part of the kernel:
> 
> x86_64-linux-ld: drivers/net/wireless/ralink/rt2x00/rt2800lib.o: in function `rt2800_check_firmware':
> rt2800lib.c:(.text+0x20e5): undefined reference to `crc_ccitt'
> 
> Move the select statement to the correct Kconfig symbol to match
> the call site.
> 
> Fixes: 311b05e235cf ("wifi: rt2x00: add COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
>  drivers/net/wireless/ralink/rt2x00/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/Kconfig b/drivers/net/wireless/ralink/rt2x00/Kconfig
> index d66fc839c3ce..17f063fc0b57 100644
> --- a/drivers/net/wireless/ralink/rt2x00/Kconfig
> +++ b/drivers/net/wireless/ralink/rt2x00/Kconfig
> @@ -66,7 +66,6 @@ config RT2800PCI
>  	select RT2X00_LIB_PCI
>  	select RT2X00_LIB_FIRMWARE
>  	select RT2X00_LIB_CRYPTO
> -	select CRC_CCITT
>  	select EEPROM_93CX6
>  	help
>  	  This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
> @@ -142,7 +141,6 @@ config RT2800USB
>  	select RT2X00_LIB_USB
>  	select RT2X00_LIB_FIRMWARE
>  	select RT2X00_LIB_CRYPTO
> -	select CRC_CCITT
>  	help
>  	  This adds support for rt27xx/rt28xx/rt30xx wireless chipset family.
>  	  Supported chips: RT2770, RT2870 & RT3070, RT3071 & RT3072
> @@ -217,6 +215,7 @@ config RT2800SOC
>  
>  config RT2800_LIB
>  	tristate
> +	select CRC_CCITT
>  
>  config RT2800_LIB_MMIO
>  	tristate
> -- 
> 2.39.5
>

Re: [PATCH] net: wireless: rt2x00: fix CRC_CCITT dependency

Posted by Sergio Paracuellos 2 months ago

On Thu, Jul 31, 2025 at 9:58 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing this driver on Arm platforms shows a link failure
> when the CRC functions are not part of the kernel:
>
> x86_64-linux-ld: drivers/net/wireless/ralink/rt2x00/rt2800lib.o: in function `rt2800_check_firmware':
> rt2800lib.c:(.text+0x20e5): undefined reference to `crc_ccitt'
>
> Move the select statement to the correct Kconfig symbol to match
> the call site.
>
> Fixes: 311b05e235cf ("wifi: rt2x00: add COMPILE_TEST")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/wireless/ralink/rt2x00/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>