[PATCH v4 0/3] drm/panel: novatek-nt35560: Fix bug and clean up

Brigham Campbell posted 3 patches 2 months ago
drivers/gpu/drm/drm_mipi_dsi.c                |  37 ++++
drivers/gpu/drm/panel/panel-novatek-nt35560.c | 198 ++++++------------
include/drm/drm_mipi_dsi.h                    |  35 ++++
3 files changed, 132 insertions(+), 138 deletions(-)
[PATCH v4 0/3] drm/panel: novatek-nt35560: Fix bug and clean up
Posted by Brigham Campbell 2 months ago
Fix bug in novatek-nt35560 driver's nt35560_set_brightness() which
causes the driver to incorrectly report that it "failed to disable
display backlight".

Add mipi_dsi_dcs_read_multi() to drm_mipi_dsi.c for improved error
handling in drivers which use mipi_dsi_dcs_read() multiple times in a
row. Add mipi_dsi_dcs_write_var_seq_multi() and
mipi_dsi_generic_write_var_seq_multi() to drm_mipi_dsi.h to allow
drivers to more conveniently construct MIPI payloads at runtime.

Clean up novatek-nt35560 driver to use "multi" variants of MIPI.

Changes to v4:
 - Replace "non-static" in kerneldoc comment with "non-constant"

Changes to v3:
 - Fix incorrect Fixes tag. The bug was introduced by an earlier commit.
 - Minor formatting improvements.

Changes to v2:
 - Separate bug fix into its own commit for backporting.
 - Add var_seq_multi() variants of MIPI write macros for sending
   non-static MIPI messages.
 - Minor formatting improvements.

Brigham Campbell (3):
  drm/panel: novatek-nt35560: Fix invalid return value
  drm: Add MIPI read_multi func and two write macros
  drm/panel: novatek-nt35560: Clean up driver

 drivers/gpu/drm/drm_mipi_dsi.c                |  37 ++++
 drivers/gpu/drm/panel/panel-novatek-nt35560.c | 198 ++++++------------
 include/drm/drm_mipi_dsi.h                    |  35 ++++
 3 files changed, 132 insertions(+), 138 deletions(-)


base-commit: 33f8f321e7aa7715ce19560801ee5223ba8b9a7d
-- 
2.50.1
Re: [PATCH v4 0/3] drm/panel: novatek-nt35560: Fix bug and clean up
Posted by Neil Armstrong 2 months ago
Hi,

On Wed, 30 Jul 2025 21:23:40 -0600, Brigham Campbell wrote:
> Fix bug in novatek-nt35560 driver's nt35560_set_brightness() which
> causes the driver to incorrectly report that it "failed to disable
> display backlight".
> 
> Add mipi_dsi_dcs_read_multi() to drm_mipi_dsi.c for improved error
> handling in drivers which use mipi_dsi_dcs_read() multiple times in a
> row. Add mipi_dsi_dcs_write_var_seq_multi() and
> mipi_dsi_generic_write_var_seq_multi() to drm_mipi_dsi.h to allow
> drivers to more conveniently construct MIPI payloads at runtime.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/3] drm/panel: novatek-nt35560: Fix invalid return value
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/125459e19ec654924e472f3ff5aeea40358dbebf
[2/3] drm: Add MIPI read_multi func and two write macros
      (no commit info)
[3/3] drm/panel: novatek-nt35560: Clean up driver
      (no commit info)

-- 
Neil