selftests/mm: Fix typos and improve output messages

[PATCH] selftests/mm: Fix typos and improve output messages

Posted by Swaraj Gaikwad 2 months ago

From: Swaraj-1925 <swarajgaikwad1925@gmail.com>

Fixed spelling and grammar issues in test output messages
to improve readability.

Signed-off-by: swarajgaikwad1925@gmail.com
---
 tools/testing/selftests/mm/Makefile | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
index ae6f994d3add..96985c545d16 100644
--- a/tools/testing/selftests/mm/Makefile
+++ b/tools/testing/selftests/mm/Makefile
@@ -48,10 +48,10 @@ ifneq (,$(wildcard $(KDIR)/Module.symvers))
 ifneq (,$(wildcard $(KDIR)/include/linux/page_frag_cache.h))
 TEST_GEN_MODS_DIR := page_frag
 else
-PAGE_FRAG_WARNING = "missing page_frag_cache.h, please use a newer kernel"
+PAGE_FRAG_WARNING = "Missing page_frag_cache.h, Please use a newer kernel"
 endif
 else
-PAGE_FRAG_WARNING = "missing Module.symvers, please have the kernel built first"
+PAGE_FRAG_WARNING = "Missing Module.symvers, Please build the kernel first"
 endif
 
 TEST_GEN_FILES = cow
@@ -202,8 +202,8 @@ ifeq ($(CAN_BUILD_I386)$(CAN_BUILD_X86_64),01)
 all: warn_32bit_failure
 
 warn_32bit_failure:
-	@echo "Warning: you seem to have a broken 32-bit build" 2>&1;		\
-	echo  "environment. This will reduce test coverage of 64-bit" 2>&1;	\
+	@echo "Warning: you seem to have a broken 32-bit build environment." 2>&1;		\
+	echo  "This will reduce test coverage of 64-bit" 2>&1;	\
 	echo  "kernels. If you are using a Debian-like distribution," 2>&1;	\
 	echo  "try:"; 2>&1;							\
 	echo  "";								\
-- 
2.50.1

Re: [PATCH] selftests/mm: Fix typos and improve output messages

Posted by Andrew Morton 2 months ago

On Thu, 31 Jul 2025 00:02:51 +0000 Swaraj Gaikwad <swarajgaikwad1925@gmail.com> wrote:

> From: Swaraj-1925 <swarajgaikwad1925@gmail.com>

We prefer that real names be used, please.

> Fixed spelling and grammar issues in test output messages
> to improve readability.
> 
> Signed-off-by: swarajgaikwad1925@gmail.com

Ditto.

> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -48,10 +48,10 @@ ifneq (,$(wildcard $(KDIR)/Module.symvers))
>  ifneq (,$(wildcard $(KDIR)/include/linux/page_frag_cache.h))
>  TEST_GEN_MODS_DIR := page_frag
>  else
> -PAGE_FRAG_WARNING = "missing page_frag_cache.h, please use a newer kernel"
> +PAGE_FRAG_WARNING = "Missing page_frag_cache.h, Please use a newer kernel"

A capital letter after a comma is incorrect.

>  endif
>  else
> -PAGE_FRAG_WARNING = "missing Module.symvers, please have the kernel built first"
> +PAGE_FRAG_WARNING = "Missing Module.symvers, Please build the kernel first"
>  endif
>  
>  TEST_GEN_FILES = cow
> @@ -202,8 +202,8 @@ ifeq ($(CAN_BUILD_I386)$(CAN_BUILD_X86_64),01)
>  all: warn_32bit_failure
>  
>  warn_32bit_failure:
> -	@echo "Warning: you seem to have a broken 32-bit build" 2>&1;		\
> -	echo  "environment. This will reduce test coverage of 64-bit" 2>&1;	\
> +	@echo "Warning: you seem to have a broken 32-bit build environment." 2>&1;		\
> +	echo  "This will reduce test coverage of 64-bit" 2>&1;	\
>  	echo  "kernels. If you are using a Debian-like distribution," 2>&1;	\
>  	echo  "try:"; 2>&1;							\
>  	echo  "";								\

Overall, this patch is hitting the too-trivial-to-merge threshold, sorry.