mtd: map: add back asm/barrier.h inclusion

[PATCH] mtd: map: add back asm/barrier.h inclusion

Posted by Arnd Bergmann 2 months, 1 week ago

From: Arnd Bergmann <arnd@arndb.de>

The mb() macro is used in this header:

In file included from include/linux/mtd/qinfo.h:5,
                 from include/linux/mtd/pfow.h:8,
                 from drivers/mtd/lpddr/lpddr_cmds.c:14:
include/linux/mtd/map.h: In function 'inline_map_write':
include/linux/mtd/map.h:428:9: error: implicit declaration of function 'mb' [-Wimplicit-function-declaration]

Fixes: 56eb7c13b97c ("mtd: map: Don't use "proxy" headers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/mtd/map.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h
index 288ef765a44e..75b0b2abc880 100644
--- a/include/linux/mtd/map.h
+++ b/include/linux/mtd/map.h
@@ -14,6 +14,7 @@
 #include <linux/string.h>
 #include <linux/types.h>
 #include <linux/unaligned.h>
+#include <asm/barrier.h>
 
 struct device_node;
 struct module;
-- 
2.39.5

Re: [PATCH] mtd: map: add back asm/barrier.h inclusion

Posted by Andy Shevchenko 2 months ago

On Wed, Jul 30, 2025 at 03:59:24PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The mb() macro is used in this header:
> 
> In file included from include/linux/mtd/qinfo.h:5,
>                  from include/linux/mtd/pfow.h:8,
>                  from drivers/mtd/lpddr/lpddr_cmds.c:14:
> include/linux/mtd/map.h: In function 'inline_map_write':
> include/linux/mtd/map.h:428:9: error: implicit declaration of function 'mb' [-Wimplicit-function-declaration]

Oops, thanks!
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] mtd: map: add back asm/barrier.h inclusion

Posted by Miquel Raynal 1 month ago

On Wed, 30 Jul 2025 15:59:24 +0200, Arnd Bergmann wrote:
> The mb() macro is used in this header:
> 
> In file included from include/linux/mtd/qinfo.h:5,
>                  from include/linux/mtd/pfow.h:8,
>                  from drivers/mtd/lpddr/lpddr_cmds.c:14:
> include/linux/mtd/map.h: In function 'inline_map_write':
> include/linux/mtd/map.h:428:9: error: implicit declaration of function 'mb' [-Wimplicit-function-declaration]
> 
> [...]

Applied to mtd/next, thanks!

[1/1] mtd: map: add back asm/barrier.h inclusion
      commit: 6538d039c524304a00b8fac651982fdf1fe24cc3

Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl