arm64: dts: qcom: qcm2290: Add TCSR download mode address

[PATCH] arm64: dts: qcom: qcm2290: Add TCSR download mode address

Posted by Sumit Garg 2 months, 1 week ago

From: Sumit Garg <sumit.garg@oss.qualcomm.com>

Allow configuration of download mode via qcom_scm driver via specifying
download mode register address in the TCSR space. It is especially useful
for a clean watchdog reset without entry into download mode.

The problem remained un-noticed until now since error reporting for
missing download mode configuration feature was explicitly suppressed.

Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/qcm2290.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
index f49ac1c1f8a3..08eadec59882 100644
--- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
@@ -154,6 +154,7 @@ scm: scm {
 			compatible = "qcom,scm-qcm2290", "qcom,scm";
 			clocks = <&rpmcc RPM_SMD_CE1_CLK>;
 			clock-names = "core";
+			qcom,dload-mode = <&tcsr_regs 0x13000>;
 			#reset-cells = <1>;
 			interconnects = <&system_noc MASTER_CRYPTO_CORE0 RPM_ALWAYS_TAG
 					 &bimc SLAVE_EBI1 RPM_ALWAYS_TAG>;
-- 
2.48.1

Re: [PATCH] arm64: dts: qcom: qcm2290: Add TCSR download mode address

Posted by Bjorn Andersson 1 month, 3 weeks ago

On Wed, 30 Jul 2025 18:52:30 +0530, Sumit Garg wrote:
> Allow configuration of download mode via qcom_scm driver via specifying
> download mode register address in the TCSR space. It is especially useful
> for a clean watchdog reset without entry into download mode.
> 
> The problem remained un-noticed until now since error reporting for
> missing download mode configuration feature was explicitly suppressed.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: qcm2290: Add TCSR download mode address
      commit: dc231840dca64793da7a80ff156fa1d99584f3ea

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: qcm2290: Add TCSR download mode address

Posted by Konrad Dybcio 2 months, 1 week ago

On 7/30/25 3:22 PM, Sumit Garg wrote:
> From: Sumit Garg <sumit.garg@oss.qualcomm.com>
> 
> Allow configuration of download mode via qcom_scm driver via specifying
> download mode register address in the TCSR space. It is especially useful
> for a clean watchdog reset without entry into download mode.
> 
> The problem remained un-noticed until now since error reporting for
> missing download mode configuration feature was explicitly suppressed.
> 
> Signed-off-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm2290.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> index f49ac1c1f8a3..08eadec59882 100644
> --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi
> @@ -154,6 +154,7 @@ scm: scm {
>  			compatible = "qcom,scm-qcm2290", "qcom,scm";
>  			clocks = <&rpmcc RPM_SMD_CE1_CLK>;
>  			clock-names = "core";
> +			qcom,dload-mode = <&tcsr_regs 0x13000>;

Can confirm it's the right addr

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad