Fix broken `srctree/` links and warn about them

[PATCH 0/3] Fix broken `srctree/` links and warn about them

Posted by Miguel Ojeda 2 months, 1 week ago

This fixes a handful of broken links and introduces a warning to
prevent them from happening in the future.

Relatedly, we could also perhaps check the other side of the links, but
perhaps there are cases we want to customize. Alternatively, we could
also in the future introduce custom syntax for these that avoids
repetition or a fancier preprocessing step.

Miguel Ojeda (3):
  rust: block: fix `srctree/` links
  rust: drm: fix `srctree/` links
  rust: warn if `srctree/` links do not exist

 rust/Makefile                    | 6 ++++++
 rust/kernel/block/mq/gen_disk.rs | 2 +-
 rust/kernel/drm/device.rs        | 2 +-
 rust/kernel/drm/driver.rs        | 2 +-
 rust/kernel/drm/file.rs          | 2 +-
 rust/kernel/drm/gem/mod.rs       | 2 +-
 rust/kernel/drm/ioctl.rs         | 2 +-
 7 files changed, 12 insertions(+), 6 deletions(-)

--
2.50.1

Re: [PATCH 0/3] Fix broken `srctree/` links and warn about them

Posted by Miguel Ojeda 3 weeks, 6 days ago

On Wed, Jul 30, 2025 at 3:07 PM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> This fixes a handful of broken links and introduces a warning to
> prevent them from happening in the future.

Applied to `rust-next` -- thanks everyone!

I added Cc: stable@vger.kernel.org on the fixes.

Andreas/Boqun: if you don't want the block fix, please shout!

Cheers,
Miguel

Re: [PATCH 0/3] Fix broken `srctree/` links and warn about them

Posted by Daniel Almeida 2 months, 1 week ago

Hi Miguel, this is indeed nice!

> On 30 Jul 2025, at 10:07, Miguel Ojeda <ojeda@kernel.org> wrote:
> 
> This fixes a handful of broken links and introduces a warning to
> prevent them from happening in the future.
> 
> Relatedly, we could also perhaps check the other side of the links, but
> perhaps there are cases we want to customize. Alternatively, we could
> also in the future introduce custom syntax for these that avoids
> repetition or a fancier preprocessing step.
> 
> Miguel Ojeda (3):
>  rust: block: fix `srctree/` links
>  rust: drm: fix `srctree/` links
>  rust: warn if `srctree/` links do not exist
> 
> rust/Makefile                    | 6 ++++++
> rust/kernel/block/mq/gen_disk.rs | 2 +-
> rust/kernel/drm/device.rs        | 2 +-
> rust/kernel/drm/driver.rs        | 2 +-
> rust/kernel/drm/file.rs          | 2 +-
> rust/kernel/drm/gem/mod.rs       | 2 +-
> rust/kernel/drm/ioctl.rs         | 2 +-
> 7 files changed, 12 insertions(+), 6 deletions(-)
> 
> —
> 2.50.1

Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>

Patch 3 alone indeed produces the following warnings:

warning: srctree/ link to include/linux/blk_mq.h does not exist
warning: srctree/ link to include/linux/drm/drm_device.h does not exist
warning: srctree/ link to include/linux/drm/drm_ioctl.h does not exist
warning: srctree/ link to include/linux/drm/drm_file.h does not exist
warning: srctree/ link to include/linux/drm/drm_drv.h does not exist
warning: srctree/ link to include/linux/drm/drm_gem.h does not exist

So you can add my Tested-by for that one.

Cheers,
— Daniel