[PATCH v2] LoongArch: vDSO: remove -nostdlib complier flag

Wentao Guan posted 1 patch 2 months, 1 week ago
arch/loongarch/vdso/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] LoongArch: vDSO: remove -nostdlib complier flag
Posted by Wentao Guan 2 months, 1 week ago
Since $(LD) is directly used, hence -nostdlib is unneeded,
MIPS has removed this, we should remove it too.
bdbf2038fbf4 ("MIPS: VDSO: remove -nostdlib compiler flag").

In fact, other architectures also use $(LD).
fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO")
691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to link VDSO")
2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO")
2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")

Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn>
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

------
Changes in v2:
	- apply commit msg edit suggestion by Yanteng Si
------
---
 arch/loongarch/vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
index ccd2c5e135c6..d8316f993482 100644
--- a/arch/loongarch/vdso/Makefile
+++ b/arch/loongarch/vdso/Makefile
@@ -36,7 +36,7 @@ endif
 
 # VDSO linker flags.
 ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
-	$(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared --build-id -T
+	$(filter -E%,$(KBUILD_CFLAGS)) -shared --build-id -T
 
 #
 # Shared build commands.
-- 
2.20.1
Re: [PATCH v2] LoongArch: vDSO: remove -nostdlib complier flag
Posted by Huacai Chen 2 months ago
Applied, thanks.

Huacai

On Wed, Jul 30, 2025 at 4:35 PM Wentao Guan <guanwentao@uniontech.com> wrote:
>
> Since $(LD) is directly used, hence -nostdlib is unneeded,
> MIPS has removed this, we should remove it too.
> bdbf2038fbf4 ("MIPS: VDSO: remove -nostdlib compiler flag").
>
> In fact, other architectures also use $(LD).
> fe00e50b2db8 ("ARM: 8858/1: vdso: use $(LD) instead of $(CC) to link VDSO")
> 691efbedc60d ("arm64: vdso: use $(LD) instead of $(CC) to link VDSO")
> 2ff906994b6c ("MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO")
> 2b2a25845d53 ("s390/vdso: Use $(LD) instead of $(CC) to link vDSO")
>
> Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn>
> Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
>
> ------
> Changes in v2:
>         - apply commit msg edit suggestion by Yanteng Si
> ------
> ---
>  arch/loongarch/vdso/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefile
> index ccd2c5e135c6..d8316f993482 100644
> --- a/arch/loongarch/vdso/Makefile
> +++ b/arch/loongarch/vdso/Makefile
> @@ -36,7 +36,7 @@ endif
>
>  # VDSO linker flags.
>  ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \
> -       $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared --build-id -T
> +       $(filter -E%,$(KBUILD_CFLAGS)) -shared --build-id -T
>
>  #
>  # Shared build commands.
> --
> 2.20.1
>