[PATCH v2 18/20] clocksource/drivers/vf-pit: Rename the VF PIT to NXP PIT

Daniel Lezcano posted 20 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH v2 18/20] clocksource/drivers/vf-pit: Rename the VF PIT to NXP PIT
Posted by Daniel Lezcano 2 months, 1 week ago
The PIT acronym stands for Periodic Interrupt Timer which is found on
different NXP platforms not only on the Vybrid Family. Change the name
to be more generic for the NXP platforms in general. That will be
consistent with the NXP STM driver naming convention.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig                             | 9 ++++++---
 drivers/clocksource/Makefile                            | 2 +-
 drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} | 0
 3 files changed, 7 insertions(+), 4 deletions(-)
 rename drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} (100%)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 6f7d371904df..0fd662f67d29 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -474,11 +474,14 @@ config FSL_FTM_TIMER
 	help
 	  Support for Freescale FlexTimer Module (FTM) timer.
 
-config VF_PIT_TIMER
-	bool "Vybrid Family Programmable timer" if COMPILE_TEST
+config NXP_PIT_TIMER
+	bool "NXP Periodic Interrupt Timer" if COMPILE_TEST
 	select CLKSRC_MMIO
 	help
-	  Support for Periodic Interrupt Timer on Freescale Vybrid Family SoCs.
+	  Support for Periodic Interrupt Timer on Freescale / NXP
+	  SoCs. This periodic timer is found on the Vybrid Family and
+	  the Automotive S32G2/3 platforms. It contains 4 channels
+	  where two can be coupled to form a 64 bits channel.
 
 config SYS_SUPPORTS_SH_CMT
 	bool
diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index 205bf3b0a8f3..77a0f08eb43b 100644
--- a/drivers/clocksource/Makefile
+++ b/drivers/clocksource/Makefile
@@ -49,7 +49,7 @@ obj-$(CONFIG_CLKSRC_LPC32XX)	+= timer-lpc32xx.o
 obj-$(CONFIG_CLKSRC_MPS2)	+= mps2-timer.o
 obj-$(CONFIG_CLKSRC_SAMSUNG_PWM)	+= samsung_pwm_timer.o
 obj-$(CONFIG_FSL_FTM_TIMER)	+= timer-fsl-ftm.o
-obj-$(CONFIG_VF_PIT_TIMER)	+= timer-vf-pit.o
+obj-$(CONFIG_NXP_PIT_TIMER)	+= timer-nxp-pit.o
 obj-$(CONFIG_CLKSRC_QCOM)	+= timer-qcom.o
 obj-$(CONFIG_MTK_TIMER)		+= timer-mediatek.o
 obj-$(CONFIG_MTK_CPUX_TIMER)	+= timer-mediatek-cpux.o
diff --git a/drivers/clocksource/timer-vf-pit.c b/drivers/clocksource/timer-nxp-pit.c
similarity index 100%
rename from drivers/clocksource/timer-vf-pit.c
rename to drivers/clocksource/timer-nxp-pit.c
-- 
2.43.0
Re: [PATCH v2 18/20] clocksource/drivers/vf-pit: Rename the VF PIT to NXP PIT
Posted by Ghennadi Procopciuc 2 months ago
On 7/30/2025 11:27 AM, Daniel Lezcano wrote:
> The PIT acronym stands for Periodic Interrupt Timer which is found on
> different NXP platforms not only on the Vybrid Family. Change the name
> to be more generic for the NXP platforms in general. That will be
> consistent with the NXP STM driver naming convention.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/clocksource/Kconfig                             | 9 ++++++---
>  drivers/clocksource/Makefile                            | 2 +-
>  drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} | 0
>  3 files changed, 7 insertions(+), 4 deletions(-)
>  rename drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} (100%)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 6f7d371904df..0fd662f67d29 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -474,11 +474,14 @@ config FSL_FTM_TIMER
>  	help
>  	  Support for Freescale FlexTimer Module (FTM) timer.
>  
> -config VF_PIT_TIMER
> -	bool "Vybrid Family Programmable timer" if COMPILE_TEST
> +config NXP_PIT_TIMER
> +	bool "NXP Periodic Interrupt Timer" if COMPILE_TEST
>  	select CLKSRC_MMIO
>  	help
> -	  Support for Periodic Interrupt Timer on Freescale Vybrid Family SoCs.
> +	  Support for Periodic Interrupt Timer on Freescale / NXP
> +	  SoCs. This periodic timer is found on the Vybrid Family and
> +	  the Automotive S32G2/3 platforms. It contains 4 channels
> +	  where two can be coupled to form a 64 bits channel.

Checkpatch:
WARNING: please write a help paragraph that fully describes the config
symbol with at least 4 lines
#29: FILE: drivers/clocksource/Kconfig:477:
+config NXP_PIT_TIMER
+       bool "NXP Periodic Interrupt Timer" if COMPILE_TEST
        select CLKSRC_MMIO
        help
+         Support for Periodic Interrupt Timer on Freescale / NXP
+         Support for Periodic Interrupt Timer on Freescale / NXP
+         SoCs. This periodic timer is found on the Vybrid Family and
+         the Automotive S32G2/3 platforms. It contains 4 channels
+         where two can be coupled to form a 64 bits channel.


total: 0 errors, 2 warnings, 0 checks, 25 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or
--fix-inplace.

Commit 1e9876740925 ("clocksource/drivers/vf-pit: Rename the VF PIT to
NXP PIT") has style problems, please review.

-- 
Regards,
Ghennadi
Re: [PATCH v2 18/20] clocksource/drivers/vf-pit: Rename the VF PIT to NXP PIT
Posted by Daniel Lezcano 2 months ago
On 01/08/2025 09:35, Ghennadi Procopciuc wrote:
> On 7/30/2025 11:27 AM, Daniel Lezcano wrote:
>> The PIT acronym stands for Periodic Interrupt Timer which is found on
>> different NXP platforms not only on the Vybrid Family. Change the name
>> to be more generic for the NXP platforms in general. That will be
>> consistent with the NXP STM driver naming convention.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>>   drivers/clocksource/Kconfig                             | 9 ++++++---
>>   drivers/clocksource/Makefile                            | 2 +-
>>   drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} | 0
>>   3 files changed, 7 insertions(+), 4 deletions(-)
>>   rename drivers/clocksource/{timer-vf-pit.c => timer-nxp-pit.c} (100%)
>>
>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>> index 6f7d371904df..0fd662f67d29 100644
>> --- a/drivers/clocksource/Kconfig
>> +++ b/drivers/clocksource/Kconfig
>> @@ -474,11 +474,14 @@ config FSL_FTM_TIMER
>>   	help
>>   	  Support for Freescale FlexTimer Module (FTM) timer.
>>   
>> -config VF_PIT_TIMER
>> -	bool "Vybrid Family Programmable timer" if COMPILE_TEST
>> +config NXP_PIT_TIMER
>> +	bool "NXP Periodic Interrupt Timer" if COMPILE_TEST
>>   	select CLKSRC_MMIO
>>   	help
>> -	  Support for Periodic Interrupt Timer on Freescale Vybrid Family SoCs.
>> +	  Support for Periodic Interrupt Timer on Freescale / NXP
>> +	  SoCs. This periodic timer is found on the Vybrid Family and
>> +	  the Automotive S32G2/3 platforms. It contains 4 channels
>> +	  where two can be coupled to form a 64 bits channel.
> 
> Checkpatch:
> WARNING: please write a help paragraph that fully describes the config
> symbol with at least 4 lines

Sounds like a false positive.

> #29: FILE: drivers/clocksource/Kconfig:477:
> +config NXP_PIT_TIMER
> +       bool "NXP Periodic Interrupt Timer" if COMPILE_TEST
>          select CLKSRC_MMIO
>          help
> +         Support for Periodic Interrupt Timer on Freescale / NXP
> +         Support for Periodic Interrupt Timer on Freescale / NXP
> +         SoCs. This periodic timer is found on the Vybrid Family and
> +         the Automotive S32G2/3 platforms. It contains 4 channels
> +         where two can be coupled to form a 64 bits channel.
> 
> 
> total: 0 errors, 2 warnings, 0 checks, 25 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>        mechanically convert to the typical style using --fix or
> --fix-inplace.
> 
> Commit 1e9876740925 ("clocksource/drivers/vf-pit: Rename the VF PIT to
> NXP PIT") has style problems, please review.
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog