[PATCH RFC 5/6] spi: geni-qcom: Hint GENI protocol ID to GPI DMA

Konrad Dybcio posted 6 patches 2 months, 1 week ago
[PATCH RFC 5/6] spi: geni-qcom: Hint GENI protocol ID to GPI DMA
Posted by Konrad Dybcio 2 months, 1 week ago
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

With the API in place, request the correct protocol ID with the GPI DMA
to avoid having to hardcode this obvious information in the device
tree.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/spi/spi-geni-qcom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c
index 768d7482102adec9b7178077724dc3976a2760c8..0ea157ac06e12012e1a36218bf3a4058a9db6048 100644
--- a/drivers/spi/spi-geni-qcom.c
+++ b/drivers/spi/spi-geni-qcom.c
@@ -623,14 +623,14 @@ static int spi_geni_grab_gpi_chan(struct spi_geni_master *mas)
 {
 	int ret;
 
-	mas->tx = dma_request_chan(mas->dev, "tx");
+	mas->tx = dma_request_chan_w_data(mas->dev, "tx", (void *)GENI_SE_SPI);
 	if (IS_ERR(mas->tx)) {
 		ret = dev_err_probe(mas->dev, PTR_ERR(mas->tx),
 				    "Failed to get tx DMA ch\n");
 		goto err_tx;
 	}
 
-	mas->rx = dma_request_chan(mas->dev, "rx");
+	mas->rx = dma_request_chan_w_data(mas->dev, "rx", (void *)GENI_SE_SPI);
 	if (IS_ERR(mas->rx)) {
 		ret = dev_err_probe(mas->dev, PTR_ERR(mas->rx),
 				    "Failed to get rx DMA ch\n");

-- 
2.50.1
Re: [PATCH RFC 5/6] spi: geni-qcom: Hint GENI protocol ID to GPI DMA
Posted by Mark Brown 2 months, 1 week ago
On Wed, Jul 30, 2025 at 11:33:32AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> With the API in place, request the correct protocol ID with the GPI DMA
> to avoid having to hardcode this obvious information in the device
> tree.

Acked-by: Mark Brown <broonie@kernel.org>