[v2] Add watchdog driver support for RZ/T2H and RZ/N2H SoCs

[PATCH v2 6/9] watchdog: rzv2h_wdt: Make reset controller optional

Posted by Prabhakar 2 months, 1 week ago

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Use devm_reset_control_get_optional_exclusive() instead of
devm_reset_control_get_exclusive() to allow the driver to operate
on platforms where a reset controller is not present.

This change is in preparation for supporting the RZ/T2H SoC, which
does not have reset.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
v1->v2:
- No changes.
---
 drivers/watchdog/rzv2h_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c
index cb584ac5860f..f0e2bf786acc 100644
--- a/drivers/watchdog/rzv2h_wdt.c
+++ b/drivers/watchdog/rzv2h_wdt.c
@@ -240,7 +240,7 @@ static int rzv2h_wdt_probe(struct platform_device *pdev)
 	if (IS_ERR(priv->oscclk))
 		return dev_err_probe(dev, PTR_ERR(priv->oscclk), "no oscclk");
 
-	priv->rstc = devm_reset_control_get_exclusive(dev, NULL);
+	priv->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
 	if (IS_ERR(priv->rstc))
 		return dev_err_probe(dev, PTR_ERR(priv->rstc),
 				     "failed to get cpg reset");
-- 
2.50.1

Re: [PATCH v2 6/9] watchdog: rzv2h_wdt: Make reset controller optional

Posted by Wolfram Sang 2 months ago

On Tue, Jul 29, 2025 at 04:59:12PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Use devm_reset_control_get_optional_exclusive() instead of
> devm_reset_control_get_exclusive() to allow the driver to operate
> on platforms where a reset controller is not present.
> 
> This change is in preparation for supporting the RZ/T2H SoC, which
> does not have reset.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

I'd suggest to merge this with patch 4.

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Re: [PATCH v2 6/9] watchdog: rzv2h_wdt: Make reset controller optional

Posted by Lad, Prabhakar 2 months ago

Hi Wolfram,

Thank you for the review.

On Fri, Aug 1, 2025 at 5:04 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> On Tue, Jul 29, 2025 at 04:59:12PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Use devm_reset_control_get_optional_exclusive() instead of
> > devm_reset_control_get_exclusive() to allow the driver to operate
> > on platforms where a reset controller is not present.
> >
> > This change is in preparation for supporting the RZ/T2H SoC, which
> > does not have reset.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> I'd suggest to merge this with patch 4.
>
Ok, I will squash it with patch 4/9.

> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>

Cheers,
Prabhakar