[PATCH] kernel/panic.c: fix checkpatch erros on style and initialization.

Dishank Jogi posted 1 patch 2 months, 1 week ago
kernel/panic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] kernel/panic.c: fix checkpatch erros on style and initialization.
Posted by Dishank Jogi 2 months, 1 week ago
---------------------------------------------
Fixes:
  - ERROR: do not initialise globals to false.
  - ERROR: space prohibited before open square bracket '['.
---------------------------------------------

Signed-off-by: Dishank Jogi <jogidishank503@gmail.com>
---
 kernel/panic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index b0b9a8bf4560..38b4ad6fcb2b 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -61,7 +61,7 @@ static DEFINE_SPINLOCK(pause_on_oops_lock);
 bool crash_kexec_post_notifiers;
 int panic_on_warn __read_mostly;
 unsigned long panic_on_taint;
-bool panic_on_taint_nousertaint = false;
+bool panic_on_taint_nousertaint;
 static unsigned int warn_limit __read_mostly;
 
 bool panic_triggering_all_cpu_backtrace;
@@ -509,7 +509,7 @@ void panic(const char *fmt, ...)
 EXPORT_SYMBOL(panic);
 
 #define TAINT_FLAG(taint, _c_true, _c_false, _module)			\
-	[ TAINT_##taint ] = {						\
+	[TAINT_##taint] = {						\
 		.c_true = _c_true, .c_false = _c_false,			\
 		.module = _module,					\
 		.desc = #taint,						\
-- 
2.43.0
Re: [PATCH] kernel/panic.c: fix checkpatch erros on style and initialization.
Posted by Markus Elfring 2 months, 1 week ago
> Fixes:

Does your wording approach contain a description conflict?

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n81

* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.16#n145


Please avoid a typo in the summary phrase.

Regards,
Markus