[PATCH v1 3/3] ARM: dts: aspeed: santabarbara: Adjust LED configuration

Fred Chen posted 3 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH v1 3/3] ARM: dts: aspeed: santabarbara: Adjust LED configuration
Posted by Fred Chen 2 months, 1 week ago
Add a new power fault LED on GPIOB5 and relocate the ID LED to GPIOQ4.
The ID LED is now driven by the CPLD, allowing it to reflect multiple
system states depending on CPLD logic.

Signed-off-by: Fred Chen <fredchen.openbmc@gmail.com>
---
 .../boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts  | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
index ed30f3bf61a4..c7eb30e5baad 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
@@ -94,7 +94,7 @@ led-0 {
 		};
 
 		led-1 {
-			label = "fp_id_amber";
+			label = "power_fault";
 			default-state = "off";
 			gpios = <&gpio0 ASPEED_GPIO(B, 5) GPIO_ACTIVE_HIGH>;
 		};
@@ -104,6 +104,12 @@ led-2 {
 			default-state = "off";
 			gpios = <&gpio0 ASPEED_GPIO(P, 4) GPIO_ACTIVE_HIGH>;
 		};
+
+		led-3 {
+			label = "fp_id_amber";
+			default-state = "off";
+			gpios = <&gpio0 ASPEED_GPIO(Q, 4) GPIO_ACTIVE_HIGH>;
+		};
 	};
 
 	memory@80000000 {
-- 
2.49.0
Re: [PATCH v1 3/3] ARM: dts: aspeed: santabarbara: Adjust LED configuration
Posted by Andrew Lunn 2 months, 1 week ago
On Tue, Jul 29, 2025 at 05:13:45PM +0800, Fred Chen wrote:
> Add a new power fault LED on GPIOB5 and relocate the ID LED to GPIOQ4.
> The ID LED is now driven by the CPLD, allowing it to reflect multiple
> system states depending on CPLD logic.

It would be good to add a comment about why this is not an ABI
breaking change.

	Andrew