crypto: ccp: Fix checks for SNP_VLEK_LOAD input buffer length

[PATCH] crypto: ccp: Fix checks for SNP_VLEK_LOAD input buffer length

Posted by Michael Roth 6 months, 1 week ago

The SNP_VLEK_LOAD IOCTL currently fails due to sev_cmd_buffer_len()
returning the default expected buffer length of 0 instead of the correct
value, which would be sizeof(struct sev_user_data_snp_vlek_load). Add
specific handling for SNP_VLEK_LOAD so the correct expected size is
returned.

Reported-by: Diego GonzalezVillalobos <Diego.GonzalezVillalobos@amd.com>
Cc: Diego GonzalezVillalobos <Diego.GonzalezVillalobos@amd.com>
Fixes: 332d2c1d713e ("crypto: ccp: Add the SNP_VLEK_LOAD command")
Signed-off-by: Michael Roth <michael.roth@amd.com>
---
 drivers/crypto/ccp/sev-dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
index 3451bada884e..7843973ba4c6 100644
--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -233,6 +233,7 @@ static int sev_cmd_buffer_len(int cmd)
 	case SEV_CMD_SNP_GUEST_REQUEST:		return sizeof(struct sev_data_snp_guest_request);
 	case SEV_CMD_SNP_CONFIG:		return sizeof(struct sev_user_data_snp_config);
 	case SEV_CMD_SNP_COMMIT:		return sizeof(struct sev_data_snp_commit);
+	case SEV_CMD_SNP_VLEK_LOAD:		return sizeof(struct sev_user_data_snp_vlek_load);
 	default:				return 0;
 	}
 
-- 
2.25.1

Re: [PATCH] crypto: ccp: Fix checks for SNP_VLEK_LOAD input buffer length

Posted by Borislav Petkov 6 months ago

I think this should go to Herbert who's collecting crypto stuff.

 To: x86@kernel.org is perhaps not really the right place :)

On Mon, Jul 28, 2025 at 06:43:03PM -0500, Michael Roth wrote:
> The SNP_VLEK_LOAD IOCTL currently fails due to sev_cmd_buffer_len()
> returning the default expected buffer length of 0 instead of the correct
> value, which would be sizeof(struct sev_user_data_snp_vlek_load). Add
> specific handling for SNP_VLEK_LOAD so the correct expected size is
> returned.
> 
> Reported-by: Diego GonzalezVillalobos <Diego.GonzalezVillalobos@amd.com>
> Cc: Diego GonzalezVillalobos <Diego.GonzalezVillalobos@amd.com>
> Fixes: 332d2c1d713e ("crypto: ccp: Add the SNP_VLEK_LOAD command")
> Signed-off-by: Michael Roth <michael.roth@amd.com>
> ---
>  drivers/crypto/ccp/sev-dev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index 3451bada884e..7843973ba4c6 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -233,6 +233,7 @@ static int sev_cmd_buffer_len(int cmd)
>  	case SEV_CMD_SNP_GUEST_REQUEST:		return sizeof(struct sev_data_snp_guest_request);
>  	case SEV_CMD_SNP_CONFIG:		return sizeof(struct sev_user_data_snp_config);
>  	case SEV_CMD_SNP_COMMIT:		return sizeof(struct sev_data_snp_commit);
> +	case SEV_CMD_SNP_VLEK_LOAD:		return sizeof(struct sev_user_data_snp_vlek_load);
>  	default:				return 0;
>  	}
>  
> -- 
> 2.25.1
> 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette