1. Patchew
  2. linux
  3. View series

[PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.

Dishank Jogi posted 1 patch 2 months, 1 week ago 
kernel/kcsan/core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
[PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
Posted by Dishank Jogi 2 months, 1 week ago 
---------------------------------------------------------

- Removed unnecessary trailing commas from DEFINE_TSAN_ATOMIC_RMW() macro
  calls within DEFINE_TSAN_ATOMIC_OPS() in kernel/kcsan/core.c

- It passes checkpatch.pl with no errors or warnings and
  introduces no functional changes.

---------------------------------------------------------

Signed-off-by: Dishank Jogi <jogidishank503@gmail.com>
---
 kernel/kcsan/core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/kernel/kcsan/core.c b/kernel/kcsan/core.c
index 8a7baf4e332e..f2ec7fa4a44d 100644
--- a/kernel/kcsan/core.c
+++ b/kernel/kcsan/core.c
@@ -1257,12 +1257,12 @@ static __always_inline void kcsan_atomic_builtin_memorder(int memorder)
 #define DEFINE_TSAN_ATOMIC_OPS(bits)                                                               \
 	DEFINE_TSAN_ATOMIC_LOAD_STORE(bits);                                                       \
 	DEFINE_TSAN_ATOMIC_RMW(exchange, bits, _n);                                                \
-	DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits, );                                                 \
-	DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits, );                                                 \
-	DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits, );                                                 \
-	DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits, );                                                  \
-	DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits, );                                                 \
-	DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits, );                                                \
+	DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
+	DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
+	DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
+	DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
+	DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
+	DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
 	DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strong, 0);                                               \
 	DEFINE_TSAN_ATOMIC_CMPXCHG(bits, weak, 1);                                                 \
 	DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)
-- 
2.43.0
Re: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
Posted by kernel test robot 2 months, 1 week ago 
Hi Dishank,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.16 next-20250728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dishank-Jogi/kcsan-clean-up-redundant-empty-macro-arguments-in-atomic-ops/20250728-184659
base:   linus/master
patch link:    https://lore.kernel.org/r/20250728104327.48469-1-jogidishank503%40gmail.com
patch subject: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
config: x86_64-buildonly-randconfig-002-20250729 (https://download.01.org/0day-ci/archive/20250729/202507290502.vaOga5pZ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250729/202507290502.vaOga5pZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507290502.vaOga5pZ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/DEFINE_TSAN_ATOMIC_RMW +1270 kernel/kcsan/core.c

0b8b0830ac1419 Marco Elver      2021-11-30  1169  
0f8ad5f2e93425 Marco Elver      2020-07-03  1170  #define DEFINE_TSAN_ATOMIC_LOAD_STORE(bits)                                                        \
0f8ad5f2e93425 Marco Elver      2020-07-03  1171  	u##bits __tsan_atomic##bits##_load(const u##bits *ptr, int memorder);                      \
0f8ad5f2e93425 Marco Elver      2020-07-03  1172  	u##bits __tsan_atomic##bits##_load(const u##bits *ptr, int memorder)                       \
0f8ad5f2e93425 Marco Elver      2020-07-03  1173  	{                                                                                          \
0b8b0830ac1419 Marco Elver      2021-11-30  1174  		kcsan_atomic_builtin_memorder(memorder);                                           \
9d1335cc1e97cc Marco Elver      2020-07-24  1175  		if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
55a55fec5015b3 Marco Elver      2021-08-09  1176  			check_access(ptr, bits / BITS_PER_BYTE, KCSAN_ACCESS_ATOMIC, _RET_IP_);    \
9d1335cc1e97cc Marco Elver      2020-07-24  1177  		}                                                                                  \
0f8ad5f2e93425 Marco Elver      2020-07-03  1178  		return __atomic_load_n(ptr, memorder);                                             \
0f8ad5f2e93425 Marco Elver      2020-07-03  1179  	}                                                                                          \
0f8ad5f2e93425 Marco Elver      2020-07-03  1180  	EXPORT_SYMBOL(__tsan_atomic##bits##_load);                                                 \
0f8ad5f2e93425 Marco Elver      2020-07-03  1181  	void __tsan_atomic##bits##_store(u##bits *ptr, u##bits v, int memorder);                   \
0f8ad5f2e93425 Marco Elver      2020-07-03  1182  	void __tsan_atomic##bits##_store(u##bits *ptr, u##bits v, int memorder)                    \
0f8ad5f2e93425 Marco Elver      2020-07-03  1183  	{                                                                                          \
0b8b0830ac1419 Marco Elver      2021-11-30  1184  		kcsan_atomic_builtin_memorder(memorder);                                           \
9d1335cc1e97cc Marco Elver      2020-07-24  1185  		if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
9d1335cc1e97cc Marco Elver      2020-07-24  1186  			check_access(ptr, bits / BITS_PER_BYTE,                                    \
55a55fec5015b3 Marco Elver      2021-08-09  1187  				     KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ATOMIC, _RET_IP_);          \
9d1335cc1e97cc Marco Elver      2020-07-24  1188  		}                                                                                  \
0f8ad5f2e93425 Marco Elver      2020-07-03  1189  		__atomic_store_n(ptr, v, memorder);                                                \
0f8ad5f2e93425 Marco Elver      2020-07-03  1190  	}                                                                                          \
0f8ad5f2e93425 Marco Elver      2020-07-03  1191  	EXPORT_SYMBOL(__tsan_atomic##bits##_store)
0f8ad5f2e93425 Marco Elver      2020-07-03  1192  
0f8ad5f2e93425 Marco Elver      2020-07-03  1193  #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
0f8ad5f2e93425 Marco Elver      2020-07-03  1194  	u##bits __tsan_atomic##bits##_##op(u##bits *ptr, u##bits v, int memorder);                 \
0f8ad5f2e93425 Marco Elver      2020-07-03  1195  	u##bits __tsan_atomic##bits##_##op(u##bits *ptr, u##bits v, int memorder)                  \
0f8ad5f2e93425 Marco Elver      2020-07-03  1196  	{                                                                                          \
0b8b0830ac1419 Marco Elver      2021-11-30  1197  		kcsan_atomic_builtin_memorder(memorder);                                           \
9d1335cc1e97cc Marco Elver      2020-07-24  1198  		if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
14e2ac8de0f91f Marco Elver      2020-07-24  1199  			check_access(ptr, bits / BITS_PER_BYTE,                                    \
9d1335cc1e97cc Marco Elver      2020-07-24  1200  				     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
55a55fec5015b3 Marco Elver      2021-08-09  1201  					     KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
9d1335cc1e97cc Marco Elver      2020-07-24  1202  		}                                                                                  \
0f8ad5f2e93425 Marco Elver      2020-07-03  1203  		return __atomic_##op##suffix(ptr, v, memorder);                                    \
0f8ad5f2e93425 Marco Elver      2020-07-03  1204  	}                                                                                          \
0f8ad5f2e93425 Marco Elver      2020-07-03  1205  	EXPORT_SYMBOL(__tsan_atomic##bits##_##op)
0f8ad5f2e93425 Marco Elver      2020-07-03  1206  
0f8ad5f2e93425 Marco Elver      2020-07-03  1207  /*
0f8ad5f2e93425 Marco Elver      2020-07-03  1208   * Note: CAS operations are always classified as write, even in case they
0f8ad5f2e93425 Marco Elver      2020-07-03  1209   * fail. We cannot perform check_access() after a write, as it might lead to
0f8ad5f2e93425 Marco Elver      2020-07-03  1210   * false positives, in cases such as:
0f8ad5f2e93425 Marco Elver      2020-07-03  1211   *
0f8ad5f2e93425 Marco Elver      2020-07-03  1212   *	T0: __atomic_compare_exchange_n(&p->flag, &old, 1, ...)
0f8ad5f2e93425 Marco Elver      2020-07-03  1213   *
0f8ad5f2e93425 Marco Elver      2020-07-03  1214   *	T1: if (__atomic_load_n(&p->flag, ...)) {
0f8ad5f2e93425 Marco Elver      2020-07-03  1215   *		modify *p;
0f8ad5f2e93425 Marco Elver      2020-07-03  1216   *		p->flag = 0;
0f8ad5f2e93425 Marco Elver      2020-07-03  1217   *	    }
0f8ad5f2e93425 Marco Elver      2020-07-03  1218   *
0f8ad5f2e93425 Marco Elver      2020-07-03  1219   * The only downside is that, if there are 3 threads, with one CAS that
0f8ad5f2e93425 Marco Elver      2020-07-03  1220   * succeeds, another CAS that fails, and an unmarked racing operation, we may
0f8ad5f2e93425 Marco Elver      2020-07-03  1221   * point at the wrong CAS as the source of the race. However, if we assume that
0f8ad5f2e93425 Marco Elver      2020-07-03  1222   * all CAS can succeed in some other execution, the data race is still valid.
0f8ad5f2e93425 Marco Elver      2020-07-03  1223   */
0f8ad5f2e93425 Marco Elver      2020-07-03  1224  #define DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strength, weak)                                           \
0f8ad5f2e93425 Marco Elver      2020-07-03  1225  	int __tsan_atomic##bits##_compare_exchange_##strength(u##bits *ptr, u##bits *exp,          \
0f8ad5f2e93425 Marco Elver      2020-07-03  1226  							      u##bits val, int mo, int fail_mo);   \
0f8ad5f2e93425 Marco Elver      2020-07-03  1227  	int __tsan_atomic##bits##_compare_exchange_##strength(u##bits *ptr, u##bits *exp,          \
0f8ad5f2e93425 Marco Elver      2020-07-03  1228  							      u##bits val, int mo, int fail_mo)    \
0f8ad5f2e93425 Marco Elver      2020-07-03  1229  	{                                                                                          \
0b8b0830ac1419 Marco Elver      2021-11-30  1230  		kcsan_atomic_builtin_memorder(mo);                                                 \
9d1335cc1e97cc Marco Elver      2020-07-24  1231  		if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
14e2ac8de0f91f Marco Elver      2020-07-24  1232  			check_access(ptr, bits / BITS_PER_BYTE,                                    \
9d1335cc1e97cc Marco Elver      2020-07-24  1233  				     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
55a55fec5015b3 Marco Elver      2021-08-09  1234  					     KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
9d1335cc1e97cc Marco Elver      2020-07-24  1235  		}                                                                                  \
0f8ad5f2e93425 Marco Elver      2020-07-03  1236  		return __atomic_compare_exchange_n(ptr, exp, val, weak, mo, fail_mo);              \
0f8ad5f2e93425 Marco Elver      2020-07-03  1237  	}                                                                                          \
0f8ad5f2e93425 Marco Elver      2020-07-03  1238  	EXPORT_SYMBOL(__tsan_atomic##bits##_compare_exchange_##strength)
0f8ad5f2e93425 Marco Elver      2020-07-03  1239  
0f8ad5f2e93425 Marco Elver      2020-07-03  1240  #define DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)                                                       \
0f8ad5f2e93425 Marco Elver      2020-07-03  1241  	u##bits __tsan_atomic##bits##_compare_exchange_val(u##bits *ptr, u##bits exp, u##bits val, \
0f8ad5f2e93425 Marco Elver      2020-07-03  1242  							   int mo, int fail_mo);                   \
0f8ad5f2e93425 Marco Elver      2020-07-03  1243  	u##bits __tsan_atomic##bits##_compare_exchange_val(u##bits *ptr, u##bits exp, u##bits val, \
0f8ad5f2e93425 Marco Elver      2020-07-03  1244  							   int mo, int fail_mo)                    \
0f8ad5f2e93425 Marco Elver      2020-07-03  1245  	{                                                                                          \
0b8b0830ac1419 Marco Elver      2021-11-30  1246  		kcsan_atomic_builtin_memorder(mo);                                                 \
9d1335cc1e97cc Marco Elver      2020-07-24  1247  		if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
14e2ac8de0f91f Marco Elver      2020-07-24  1248  			check_access(ptr, bits / BITS_PER_BYTE,                                    \
9d1335cc1e97cc Marco Elver      2020-07-24  1249  				     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
55a55fec5015b3 Marco Elver      2021-08-09  1250  					     KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
9d1335cc1e97cc Marco Elver      2020-07-24  1251  		}                                                                                  \
0f8ad5f2e93425 Marco Elver      2020-07-03  1252  		__atomic_compare_exchange_n(ptr, &exp, val, 0, mo, fail_mo);                       \
0f8ad5f2e93425 Marco Elver      2020-07-03  1253  		return exp;                                                                        \
0f8ad5f2e93425 Marco Elver      2020-07-03  1254  	}                                                                                          \
0f8ad5f2e93425 Marco Elver      2020-07-03  1255  	EXPORT_SYMBOL(__tsan_atomic##bits##_compare_exchange_val)
0f8ad5f2e93425 Marco Elver      2020-07-03  1256  
0f8ad5f2e93425 Marco Elver      2020-07-03  1257  #define DEFINE_TSAN_ATOMIC_OPS(bits)                                                               \
0f8ad5f2e93425 Marco Elver      2020-07-03  1258  	DEFINE_TSAN_ATOMIC_LOAD_STORE(bits);                                                       \
0f8ad5f2e93425 Marco Elver      2020-07-03  1259  	DEFINE_TSAN_ATOMIC_RMW(exchange, bits, _n);                                                \
c843b93f690ae6 Dishank Jogi     2025-07-28 @1260  	DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
c843b93f690ae6 Dishank Jogi     2025-07-28  1261  	DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
c843b93f690ae6 Dishank Jogi     2025-07-28  1262  	DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
c843b93f690ae6 Dishank Jogi     2025-07-28  1263  	DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
c843b93f690ae6 Dishank Jogi     2025-07-28  1264  	DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
c843b93f690ae6 Dishank Jogi     2025-07-28  1265  	DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
0f8ad5f2e93425 Marco Elver      2020-07-03  1266  	DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strong, 0);                                               \
0f8ad5f2e93425 Marco Elver      2020-07-03  1267  	DEFINE_TSAN_ATOMIC_CMPXCHG(bits, weak, 1);                                                 \
0f8ad5f2e93425 Marco Elver      2020-07-03  1268  	DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)
0f8ad5f2e93425 Marco Elver      2020-07-03  1269  
0f8ad5f2e93425 Marco Elver      2020-07-03 @1270  DEFINE_TSAN_ATOMIC_OPS(8);
0f8ad5f2e93425 Marco Elver      2020-07-03  1271  DEFINE_TSAN_ATOMIC_OPS(16);
0f8ad5f2e93425 Marco Elver      2020-07-03  1272  DEFINE_TSAN_ATOMIC_OPS(32);
353e7300a1db92 Christophe Leroy 2023-05-12  1273  #ifdef CONFIG_64BIT
0f8ad5f2e93425 Marco Elver      2020-07-03  1274  DEFINE_TSAN_ATOMIC_OPS(64);
353e7300a1db92 Christophe Leroy 2023-05-12  1275  #endif
0f8ad5f2e93425 Marco Elver      2020-07-03  1276  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
Posted by Jogi Dishank 2 months, 1 week ago 
Hello,

Please disregard this patch. I would like to formally withdraw this patch

Sorry for the noise.

Thanks.
Dishank Jogi

On Tue, 29 Jul 2025 at 03:14, kernel test robot <lkp@intel.com> wrote:
>
> Hi Dishank,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v6.16 next-20250728]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Dishank-Jogi/kcsan-clean-up-redundant-empty-macro-arguments-in-atomic-ops/20250728-184659
> base:   linus/master
> patch link:    https://lore.kernel.org/r/20250728104327.48469-1-jogidishank503%40gmail.com
> patch subject: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
> config: x86_64-buildonly-randconfig-002-20250729 (https://download.01.org/0day-ci/archive/20250729/202507290502.vaOga5pZ-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250729/202507290502.vaOga5pZ-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202507290502.vaOga5pZ-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1270 | DEFINE_TSAN_ATOMIC_OPS(8);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1271 | DEFINE_TSAN_ATOMIC_OPS(16);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1272 | DEFINE_TSAN_ATOMIC_OPS(32);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
> >> kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
>     1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
>          |
>    kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
>     1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>          |         ^~~~~~~~~~~~~~~~~~~~~~
>    kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
>     1274 | DEFINE_TSAN_ATOMIC_OPS(64);
>          | ^~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
>
>
> vim +/DEFINE_TSAN_ATOMIC_RMW +1270 kernel/kcsan/core.c
>
> 0b8b0830ac1419 Marco Elver      2021-11-30  1169
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1170  #define DEFINE_TSAN_ATOMIC_LOAD_STORE(bits)                                                        \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1171        u##bits __tsan_atomic##bits##_load(const u##bits *ptr, int memorder);                      \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1172        u##bits __tsan_atomic##bits##_load(const u##bits *ptr, int memorder)                       \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1173        {                                                                                          \
> 0b8b0830ac1419 Marco Elver      2021-11-30  1174                kcsan_atomic_builtin_memorder(memorder);                                           \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1175                if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
> 55a55fec5015b3 Marco Elver      2021-08-09  1176                        check_access(ptr, bits / BITS_PER_BYTE, KCSAN_ACCESS_ATOMIC, _RET_IP_);    \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1177                }                                                                                  \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1178                return __atomic_load_n(ptr, memorder);                                             \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1179        }                                                                                          \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1180        EXPORT_SYMBOL(__tsan_atomic##bits##_load);                                                 \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1181        void __tsan_atomic##bits##_store(u##bits *ptr, u##bits v, int memorder);                   \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1182        void __tsan_atomic##bits##_store(u##bits *ptr, u##bits v, int memorder)                    \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1183        {                                                                                          \
> 0b8b0830ac1419 Marco Elver      2021-11-30  1184                kcsan_atomic_builtin_memorder(memorder);                                           \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1185                if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1186                        check_access(ptr, bits / BITS_PER_BYTE,                                    \
> 55a55fec5015b3 Marco Elver      2021-08-09  1187                                     KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ATOMIC, _RET_IP_);          \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1188                }                                                                                  \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1189                __atomic_store_n(ptr, v, memorder);                                                \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1190        }                                                                                          \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1191        EXPORT_SYMBOL(__tsan_atomic##bits##_store)
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1192
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1193  #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1194        u##bits __tsan_atomic##bits##_##op(u##bits *ptr, u##bits v, int memorder);                 \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1195        u##bits __tsan_atomic##bits##_##op(u##bits *ptr, u##bits v, int memorder)                  \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1196        {                                                                                          \
> 0b8b0830ac1419 Marco Elver      2021-11-30  1197                kcsan_atomic_builtin_memorder(memorder);                                           \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1198                if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
> 14e2ac8de0f91f Marco Elver      2020-07-24  1199                        check_access(ptr, bits / BITS_PER_BYTE,                                    \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1200                                     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
> 55a55fec5015b3 Marco Elver      2021-08-09  1201                                             KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1202                }                                                                                  \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1203                return __atomic_##op##suffix(ptr, v, memorder);                                    \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1204        }                                                                                          \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1205        EXPORT_SYMBOL(__tsan_atomic##bits##_##op)
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1206
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1207  /*
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1208   * Note: CAS operations are always classified as write, even in case they
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1209   * fail. We cannot perform check_access() after a write, as it might lead to
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1210   * false positives, in cases such as:
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1211   *
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1212   *    T0: __atomic_compare_exchange_n(&p->flag, &old, 1, ...)
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1213   *
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1214   *    T1: if (__atomic_load_n(&p->flag, ...)) {
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1215   *            modify *p;
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1216   *            p->flag = 0;
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1217   *        }
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1218   *
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1219   * The only downside is that, if there are 3 threads, with one CAS that
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1220   * succeeds, another CAS that fails, and an unmarked racing operation, we may
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1221   * point at the wrong CAS as the source of the race. However, if we assume that
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1222   * all CAS can succeed in some other execution, the data race is still valid.
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1223   */
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1224  #define DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strength, weak)                                           \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1225        int __tsan_atomic##bits##_compare_exchange_##strength(u##bits *ptr, u##bits *exp,          \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1226                                                              u##bits val, int mo, int fail_mo);   \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1227        int __tsan_atomic##bits##_compare_exchange_##strength(u##bits *ptr, u##bits *exp,          \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1228                                                              u##bits val, int mo, int fail_mo)    \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1229        {                                                                                          \
> 0b8b0830ac1419 Marco Elver      2021-11-30  1230                kcsan_atomic_builtin_memorder(mo);                                                 \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1231                if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
> 14e2ac8de0f91f Marco Elver      2020-07-24  1232                        check_access(ptr, bits / BITS_PER_BYTE,                                    \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1233                                     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
> 55a55fec5015b3 Marco Elver      2021-08-09  1234                                             KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1235                }                                                                                  \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1236                return __atomic_compare_exchange_n(ptr, exp, val, weak, mo, fail_mo);              \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1237        }                                                                                          \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1238        EXPORT_SYMBOL(__tsan_atomic##bits##_compare_exchange_##strength)
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1239
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1240  #define DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)                                                       \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1241        u##bits __tsan_atomic##bits##_compare_exchange_val(u##bits *ptr, u##bits exp, u##bits val, \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1242                                                           int mo, int fail_mo);                   \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1243        u##bits __tsan_atomic##bits##_compare_exchange_val(u##bits *ptr, u##bits exp, u##bits val, \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1244                                                           int mo, int fail_mo)                    \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1245        {                                                                                          \
> 0b8b0830ac1419 Marco Elver      2021-11-30  1246                kcsan_atomic_builtin_memorder(mo);                                                 \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1247                if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
> 14e2ac8de0f91f Marco Elver      2020-07-24  1248                        check_access(ptr, bits / BITS_PER_BYTE,                                    \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1249                                     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
> 55a55fec5015b3 Marco Elver      2021-08-09  1250                                             KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
> 9d1335cc1e97cc Marco Elver      2020-07-24  1251                }                                                                                  \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1252                __atomic_compare_exchange_n(ptr, &exp, val, 0, mo, fail_mo);                       \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1253                return exp;                                                                        \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1254        }                                                                                          \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1255        EXPORT_SYMBOL(__tsan_atomic##bits##_compare_exchange_val)
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1256
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1257  #define DEFINE_TSAN_ATOMIC_OPS(bits)                                                               \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1258        DEFINE_TSAN_ATOMIC_LOAD_STORE(bits);                                                       \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1259        DEFINE_TSAN_ATOMIC_RMW(exchange, bits, _n);                                                \
> c843b93f690ae6 Dishank Jogi     2025-07-28 @1260        DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
> c843b93f690ae6 Dishank Jogi     2025-07-28  1261        DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
> c843b93f690ae6 Dishank Jogi     2025-07-28  1262        DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
> c843b93f690ae6 Dishank Jogi     2025-07-28  1263        DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
> c843b93f690ae6 Dishank Jogi     2025-07-28  1264        DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
> c843b93f690ae6 Dishank Jogi     2025-07-28  1265        DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1266        DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strong, 0);                                               \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1267        DEFINE_TSAN_ATOMIC_CMPXCHG(bits, weak, 1);                                                 \
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1268        DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1269
> 0f8ad5f2e93425 Marco Elver      2020-07-03 @1270  DEFINE_TSAN_ATOMIC_OPS(8);
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1271  DEFINE_TSAN_ATOMIC_OPS(16);
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1272  DEFINE_TSAN_ATOMIC_OPS(32);
> 353e7300a1db92 Christophe Leroy 2023-05-12  1273  #ifdef CONFIG_64BIT
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1274  DEFINE_TSAN_ATOMIC_OPS(64);
> 353e7300a1db92 Christophe Leroy 2023-05-12  1275  #endif
> 0f8ad5f2e93425 Marco Elver      2020-07-03  1276
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
Re: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
Posted by kernel test robot 2 months, 1 week ago 
Hi Dishank,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.16 next-20250728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dishank-Jogi/kcsan-clean-up-redundant-empty-macro-arguments-in-atomic-ops/20250728-184659
base:   linus/master
patch link:    https://lore.kernel.org/r/20250728104327.48469-1-jogidishank503%40gmail.com
patch subject: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
config: x86_64-buildonly-randconfig-002-20250729 (https://download.01.org/0day-ci/archive/20250729/202507290412.DayPyZpH-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250729/202507290412.DayPyZpH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507290412.DayPyZpH-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
>> kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1270:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1270 | DEFINE_TSAN_ATOMIC_OPS(8);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
>> kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1271:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1271 | DEFINE_TSAN_ATOMIC_OPS(16);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
>> kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1272:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1272 | DEFINE_TSAN_ATOMIC_OPS(32);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
>> kernel/kcsan/core.c:1260:9: warning: data definition has no type or storage class
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1260:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1260 |         DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1261:9: warning: data definition has no type or storage class
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1261:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1262:9: warning: data definition has no type or storage class
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1262:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1263:9: warning: data definition has no type or storage class
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1263:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1264:9: warning: data definition has no type or storage class
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1264:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1264 |         DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: error: macro "DEFINE_TSAN_ATOMIC_RMW" requires 3 arguments, but only 2 given
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~             
   kernel/kcsan/core.c:1193: note: macro "DEFINE_TSAN_ATOMIC_RMW" defined here
    1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
         | 
   kernel/kcsan/core.c:1265:9: warning: data definition has no type or storage class
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);
         | ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1265:9: error: type defaults to 'int' in declaration of 'DEFINE_TSAN_ATOMIC_RMW' [-Werror=implicit-int]
    1265 |         DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
         |         ^~~~~~~~~~~~~~~~~~~~~~
   kernel/kcsan/core.c:1274:1: note: in expansion of macro 'DEFINE_TSAN_ATOMIC_OPS'
    1274 | DEFINE_TSAN_ATOMIC_OPS(64);


vim +1260 kernel/kcsan/core.c

  1169	
  1170	#define DEFINE_TSAN_ATOMIC_LOAD_STORE(bits)                                                        \
  1171		u##bits __tsan_atomic##bits##_load(const u##bits *ptr, int memorder);                      \
  1172		u##bits __tsan_atomic##bits##_load(const u##bits *ptr, int memorder)                       \
  1173		{                                                                                          \
  1174			kcsan_atomic_builtin_memorder(memorder);                                           \
  1175			if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
  1176				check_access(ptr, bits / BITS_PER_BYTE, KCSAN_ACCESS_ATOMIC, _RET_IP_);    \
  1177			}                                                                                  \
  1178			return __atomic_load_n(ptr, memorder);                                             \
  1179		}                                                                                          \
  1180		EXPORT_SYMBOL(__tsan_atomic##bits##_load);                                                 \
  1181		void __tsan_atomic##bits##_store(u##bits *ptr, u##bits v, int memorder);                   \
  1182		void __tsan_atomic##bits##_store(u##bits *ptr, u##bits v, int memorder)                    \
  1183		{                                                                                          \
  1184			kcsan_atomic_builtin_memorder(memorder);                                           \
  1185			if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
  1186				check_access(ptr, bits / BITS_PER_BYTE,                                    \
  1187					     KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ATOMIC, _RET_IP_);          \
  1188			}                                                                                  \
  1189			__atomic_store_n(ptr, v, memorder);                                                \
  1190		}                                                                                          \
  1191		EXPORT_SYMBOL(__tsan_atomic##bits##_store)
  1192	
  1193	#define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
  1194		u##bits __tsan_atomic##bits##_##op(u##bits *ptr, u##bits v, int memorder);                 \
  1195		u##bits __tsan_atomic##bits##_##op(u##bits *ptr, u##bits v, int memorder)                  \
  1196		{                                                                                          \
  1197			kcsan_atomic_builtin_memorder(memorder);                                           \
  1198			if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
  1199				check_access(ptr, bits / BITS_PER_BYTE,                                    \
  1200					     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
  1201						     KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
  1202			}                                                                                  \
  1203			return __atomic_##op##suffix(ptr, v, memorder);                                    \
  1204		}                                                                                          \
  1205		EXPORT_SYMBOL(__tsan_atomic##bits##_##op)
  1206	
  1207	/*
  1208	 * Note: CAS operations are always classified as write, even in case they
  1209	 * fail. We cannot perform check_access() after a write, as it might lead to
  1210	 * false positives, in cases such as:
  1211	 *
  1212	 *	T0: __atomic_compare_exchange_n(&p->flag, &old, 1, ...)
  1213	 *
  1214	 *	T1: if (__atomic_load_n(&p->flag, ...)) {
  1215	 *		modify *p;
  1216	 *		p->flag = 0;
  1217	 *	    }
  1218	 *
  1219	 * The only downside is that, if there are 3 threads, with one CAS that
  1220	 * succeeds, another CAS that fails, and an unmarked racing operation, we may
  1221	 * point at the wrong CAS as the source of the race. However, if we assume that
  1222	 * all CAS can succeed in some other execution, the data race is still valid.
  1223	 */
  1224	#define DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strength, weak)                                           \
  1225		int __tsan_atomic##bits##_compare_exchange_##strength(u##bits *ptr, u##bits *exp,          \
  1226								      u##bits val, int mo, int fail_mo);   \
  1227		int __tsan_atomic##bits##_compare_exchange_##strength(u##bits *ptr, u##bits *exp,          \
  1228								      u##bits val, int mo, int fail_mo)    \
  1229		{                                                                                          \
  1230			kcsan_atomic_builtin_memorder(mo);                                                 \
  1231			if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
  1232				check_access(ptr, bits / BITS_PER_BYTE,                                    \
  1233					     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
  1234						     KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
  1235			}                                                                                  \
  1236			return __atomic_compare_exchange_n(ptr, exp, val, weak, mo, fail_mo);              \
  1237		}                                                                                          \
  1238		EXPORT_SYMBOL(__tsan_atomic##bits##_compare_exchange_##strength)
  1239	
  1240	#define DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)                                                       \
  1241		u##bits __tsan_atomic##bits##_compare_exchange_val(u##bits *ptr, u##bits exp, u##bits val, \
  1242								   int mo, int fail_mo);                   \
  1243		u##bits __tsan_atomic##bits##_compare_exchange_val(u##bits *ptr, u##bits exp, u##bits val, \
  1244								   int mo, int fail_mo)                    \
  1245		{                                                                                          \
  1246			kcsan_atomic_builtin_memorder(mo);                                                 \
  1247			if (!IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) {                                    \
  1248				check_access(ptr, bits / BITS_PER_BYTE,                                    \
  1249					     KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE |                  \
  1250						     KCSAN_ACCESS_ATOMIC, _RET_IP_);                       \
  1251			}                                                                                  \
  1252			__atomic_compare_exchange_n(ptr, &exp, val, 0, mo, fail_mo);                       \
  1253			return exp;                                                                        \
  1254		}                                                                                          \
  1255		EXPORT_SYMBOL(__tsan_atomic##bits##_compare_exchange_val)
  1256	
  1257	#define DEFINE_TSAN_ATOMIC_OPS(bits)                                                               \
  1258		DEFINE_TSAN_ATOMIC_LOAD_STORE(bits);                                                       \
  1259		DEFINE_TSAN_ATOMIC_RMW(exchange, bits, _n);                                                \
> 1260		DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
  1261		DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
  1262		DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
  1263		DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
  1264		DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
  1265		DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
  1266		DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strong, 0);                                               \
  1267		DEFINE_TSAN_ATOMIC_CMPXCHG(bits, weak, 1);                                                 \
  1268		DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)
  1269	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.
Posted by Marco Elver 2 months, 1 week ago 
On Mon, 28 Jul 2025 at 12:43, Dishank Jogi <jogidishank503@gmail.com> wrote:
>
> ---------------------------------------------------------
>
> - Removed unnecessary trailing commas from DEFINE_TSAN_ATOMIC_RMW() macro
>   calls within DEFINE_TSAN_ATOMIC_OPS() in kernel/kcsan/core.c
>
> - It passes checkpatch.pl with no errors or warnings and
>   introduces no functional changes.
>
> ---------------------------------------------------------
>
> Signed-off-by: Dishank Jogi <jogidishank503@gmail.com>

Nack.

Did you compile the kernel with this?

> ---
>  kernel/kcsan/core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/kcsan/core.c b/kernel/kcsan/core.c
> index 8a7baf4e332e..f2ec7fa4a44d 100644
> --- a/kernel/kcsan/core.c
> +++ b/kernel/kcsan/core.c
> @@ -1257,12 +1257,12 @@ static __always_inline void kcsan_atomic_builtin_memorder(int memorder)
>  #define DEFINE_TSAN_ATOMIC_OPS(bits)                                                               \
>         DEFINE_TSAN_ATOMIC_LOAD_STORE(bits);                                                       \
>         DEFINE_TSAN_ATOMIC_RMW(exchange, bits, _n);                                                \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits, );                                                  \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits, );                                                 \
> -       DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits, );                                                \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_add, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_xor, bits);                                                 \
> +       DEFINE_TSAN_ATOMIC_RMW(fetch_nand, bits);                                                \
>         DEFINE_TSAN_ATOMIC_CMPXCHG(bits, strong, 0);                                               \
>         DEFINE_TSAN_ATOMIC_CMPXCHG(bits, weak, 1);                                                 \
>         DEFINE_TSAN_ATOMIC_CMPXCHG_VAL(bits)
> --
> 2.43.0
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.