zorro: remove extra whitespace in macro definitions

[PATCH] zorro: remove extra whitespace in macro definitions

Posted by Dishank Jogi 6 months, 1 week ago

Cleaned up the formatting of MANUF and PRODUCT macro
definitions in 'drivers/zorro/names.c' by removing extra
spaces between macro names and their parameters.

No functional changes.

Signed-off-by: Dishank Jogi <jogidishank503@gmail.com>
---
 drivers/zorro/names.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/zorro/names.c b/drivers/zorro/names.c
index 077114ccc840..3e0e428a182e 100644
--- a/drivers/zorro/names.c
+++ b/drivers/zorro/names.c
@@ -36,21 +36,21 @@ struct zorro_manuf_info {
  * real memory.. Parse the same file multiple times
  * to get all the info.
  */
-#define MANUF( manuf, name )		static char __manufstr_##manuf[] __initdata = name;
+#define MANUF(manuf, name)		static char __manufstr_##manuf[] __initdata = name;
 #define ENDMANUF()
-#define PRODUCT( manuf, prod, name ) 	static char __prodstr_##manuf##prod[] __initdata = name;
+#define PRODUCT(manuf, prod, name) 	static char __prodstr_##manuf##prod[] __initdata = name;
 #include "devlist.h"
 
 
-#define MANUF( manuf, name )		static struct zorro_prod_info __prods_##manuf[] __initdata = {
+#define MANUF(manuf, name)		static struct zorro_prod_info __prods_##manuf[] __initdata = {
 #define ENDMANUF()			};
-#define PRODUCT( manuf, prod, name )	{ 0x##prod, 0, __prodstr_##manuf##prod },
+#define PRODUCT(manuf, prod, name)	{ 0x##prod, 0, __prodstr_##manuf##prod },
 #include "devlist.h"
 
 static struct zorro_manuf_info __initdata zorro_manuf_list[] = {
-#define MANUF( manuf, name )		{ 0x##manuf, ARRAY_SIZE(__prods_##manuf), __manufstr_##manuf, __prods_##manuf },
+#define MANUF(manuf, name)		{ 0x##manuf, ARRAY_SIZE(__prods_##manuf), __manufstr_##manuf, __prods_##manuf },
 #define ENDMANUF()
-#define PRODUCT( manuf, prod, name )
+#define PRODUCT(manuf, prod, name)
 #include "devlist.h"
 };
 
-- 
2.43.0

Re: [PATCH] zorro: remove extra whitespace in macro definitions

Posted by Geert Uytterhoeven 4 months, 3 weeks ago

Hi Dishank,

On Mon, 28 Jul 2025 at 09:15, Dishank Jogi <jogidishank503@gmail.com> wrote:
> Cleaned up the formatting of MANUF and PRODUCT macro
> definitions in 'drivers/zorro/names.c' by removing extra
> spaces between macro names and their parameters.
>
> No functional changes.
>
> Signed-off-by: Dishank Jogi <jogidishank503@gmail.com>

Thanks for your patch!

> --- a/drivers/zorro/names.c
> +++ b/drivers/zorro/names.c
> @@ -36,21 +36,21 @@ struct zorro_manuf_info {
>   * real memory.. Parse the same file multiple times
>   * to get all the info.
>   */
> -#define MANUF( manuf, name )           static char __manufstr_##manuf[] __initdata = name;
> +#define MANUF(manuf, name)             static char __manufstr_##manuf[] __initdata = name;
>  #define ENDMANUF()
> -#define PRODUCT( manuf, prod, name )   static char __prodstr_##manuf##prod[] __initdata = name;
> +#define PRODUCT(manuf, prod, name)     static char __prodstr_##manuf##prod[] __initdata = name;

You missed removing a bogus space.  I will fix that up while applying.

>  #include "devlist.h"
>
>
> -#define MANUF( manuf, name )           static struct zorro_prod_info __prods_##manuf[] __initdata = {
> +#define MANUF(manuf, name)             static struct zorro_prod_info __prods_##manuf[] __initdata = {
>  #define ENDMANUF()                     };
> -#define PRODUCT( manuf, prod, name )   { 0x##prod, 0, __prodstr_##manuf##prod },
> +#define PRODUCT(manuf, prod, name)     { 0x##prod, 0, __prodstr_##manuf##prod },
>  #include "devlist.h"
>
>  static struct zorro_manuf_info __initdata zorro_manuf_list[] = {
> -#define MANUF( manuf, name )           { 0x##manuf, ARRAY_SIZE(__prods_##manuf), __manufstr_##manuf, __prods_##manuf },
> +#define MANUF(manuf, name)             { 0x##manuf, ARRAY_SIZE(__prods_##manuf), __manufstr_##manuf, __prods_##manuf },
>  #define ENDMANUF()
> -#define PRODUCT( manuf, prod, name )
> +#define PRODUCT(manuf, prod, name)
>  #include "devlist.h"
>  };

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k tree for v6.18.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds