.../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3568-linkstar-h68k-1432v1.dts | 740 +++++++++++++++++++++ 3 files changed, 746 insertions(+)
Provide support for the Seeed LinkStar H68K-1432v1, previously unsupported in mainline Linux kernel. It is a compact single board travel router with the following features: - Rockchip rk3568 SoC; - Four Gib RAM; - Four ethernet ports: - Two 1 GigE ports; - Two 2.5 GigE ports (RTL8125); - Ethernet ports support Precision Time Protocol (PTP IEEE 1588); - Four USB ports: - Three USB 3.0 ports; - Two USB 2.0 ports; - Integrated WiFi: - MediaTek MT7921e - Audio and video outputs: - HDMI; - Headphone; - eMMC (32 Gib) and microSD storage; - Real-time clock (rk809) - Powered by: - USB Type-C; - Barrel connector (DC 12-24v); These patches: - Create a devicetree for the board; - Add a (dtb) Makefile entry for the board; - Add the board to dt-bindings; (/* Thank you Krzysztof Kozlowski for your latest round of comments. */) ChangeLog: v5: - Responsive to comments received from Krzysztof Kozlowski <krzk+dt@kernel.org> - https://lore.kernel.org/all/20250728-dashing-discerning-roadrunner-bc8b87@kuoka/ - https://lore.kernel.org/all/93c39b36-07c8-4883-bd23-7d0194c50a7a@kernel.org/ - https://lore.kernel.org/all/642df1ee-5e92-4f0a-bcdf-7e10dbc0d59b@kernel.org/ - https://lore.kernel.org/all/9ebd9797-8d92-4799-bb8d-59a796e6043c@linaro.org/ - Changes made are: - Revisions to commit messages: - Removed notes on base commit; - Fixed checkpatch warning; - Removed notes on device history; - Fleshed out the top-line summary of the dts patch; v4: - Responsive to comments received from Krzysztof Kozlowski <krzk+dt@kernel.org> - https://lore.kernel.org/all/20250725-muskox-of-authentic-gaiety-b8eda4@kuoka/ - https://lore.kernel.org/all/20250725-nocturnal-messy-cicada-dbcc10@kuoka/ - /* (Thank you Krzysztof!) */ - Changes made are: - Clarified the base commit working from; - Base patched against: - Commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 (tag: v6.16-rc1); - Revised commit message for devicetree to be clearer, contain more details about the hardware, and be more succinct; - Revised commit message for devicetree binding to be clearer, contain more details about the hardware, and be more succinct; v3: Responsive to comments received from: - Chukun Pan <amadeus@jmu.edu.cn> - Krzysztof Kozlowski <krzk+dt@kernel.org> - Rob Herring <robh@kernel.org> - Heiko Stuebner <heiko@sntech.de> /* (Thank you all!) */ Those changes are: - Removed copyright line of <amadeus@jmu.edu.cn> per their request; - Fixed indentations; - Replaced space indentations with tabs; - Packaging this patch set together properly using b4, fixing the threading; - Clarifying versioning and Changelog; v2: (https://lore.kernel.org/all/20250721201137.233166-1-xunil@tahomasoft.com/) Responding to comments received from Heiko Stuebner <heiko@sntech.de> Those changes are: - Splits the single commit into two, one for the yaml binding, and the other for the board devicetree plus Makefile addition; - Adds other recipients needed from get_maintainer.pl --nol and --nom; - Uses git send-email to send the patches, to avoid adding line breaks from the MUA; - Changes comment style to conform with style guide; - Removes several unneeded comments from the devicetree; - Changes LED naming scheme with more standard nomenclature; - Changes naming of regulators, prepending 'regulator', such as: ~ from: vcc12v_dcin: vcc12v-dcin {} ~ to: vcc12v_dcin: regulator-vcc12v-dcin {} - Removes unneeded tx_delay/rx_delay from rgmii-id v1: (https://lore.kernel.org/all/20250718075058.243a5619.xunil@tahomasoft.com/) - Initial patch to provide support for Seeed LinkStar H68K Signed-off-by: Erik Beck <xunil@tahomasoft.com> --- Erik Beck (2): arm64: dts: rockchip: add LinkStar-H68k-1432v1 dt-bindings: arm: rockchip: add LinkStar-H68k-1432v1 .../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../dts/rockchip/rk3568-linkstar-h68k-1432v1.dts | 740 +++++++++++++++++++++ 3 files changed, 746 insertions(+) --- base-commit: 5f33ebd2018ced2600b3fad2f8e2052498eb4072 change-id: 20250728-linkstarpatch_v5-71466e8b6837 Best regards, -- Erik Beck <xunil@tahomasoft.com>
On Mon, Jul 28, 2025 at 11:07:35AM -0400, Erik Beck wrote: v5: > - Responsive to comments received from Krzysztof Kozlowski <krzk+dt@kernel.org> > - https://lore.kernel.org/all/20250728-dashing-discerning-roadrunner-bc8b87@kuoka/ > - https://lore.kernel.org/all/93c39b36-07c8-4883-bd23-7d0194c50a7a@kernel.org/ > - https://lore.kernel.org/all/642df1ee-5e92-4f0a-bcdf-7e10dbc0d59b@kernel.org/ > - https://lore.kernel.org/all/9ebd9797-8d92-4799-bb8d-59a796e6043c@linaro.org/ > > - Changes made are: > - Revisions to commit messages: > - Removed notes on base commit; > - Fixed checkpatch warning; > - Removed notes on device history; > - Fleshed out the top-line summary of the dts patch; You did more - also changed order of patches. Best regards, Krzysztof
> On Jul 29, 2025, at 04:56, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Jul 28, 2025 at 11:07:35AM -0400, Erik Beck wrote: > v5: >> - Responsive to comments received from Krzysztof Kozlowski <krzk+dt@kernel.org> >> - https://lore.kernel.org/all/20250728-dashing-discerning-roadrunner-bc8b87@kuoka/ >> - https://lore.kernel.org/all/93c39b36-07c8-4883-bd23-7d0194c50a7a@kernel.org/ >> - https://lore.kernel.org/all/642df1ee-5e92-4f0a-bcdf-7e10dbc0d59b@kernel.org/ >> - https://lore.kernel.org/all/9ebd9797-8d92-4799-bb8d-59a796e6043c@linaro.org/ >> >> - Changes made are: >> - Revisions to commit messages: >> - Removed notes on base commit; >> - Fixed checkpatch warning; >> - Removed notes on device history; >> - Fleshed out the top-line summary of the dts patch; > > You did more - also changed order of patches. Oops, sorry about that; I struggled a bit with b4. Which order do you prefer? Thanks, Erik > > Best regards, > Krzysztof >
© 2016 - 2025 Red Hat, Inc.