[PATCH v3 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface

Tang Yizhou posted 3 patches 2 months, 1 week ago
[PATCH v3 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface
Posted by Tang Yizhou 2 months, 1 week ago
From: Tang Yizhou <yizhou.tang@shopee.com>

The symbol wb_window_usec cannot be found. Update the doc to reflect the
latest implementation, in other words, the debugfs interface
'curr_win_nsec'.

Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
---
 Documentation/ABI/stable/sysfs-block | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
index 4ba771b56b3b..a3cf841ebdff 100644
--- a/Documentation/ABI/stable/sysfs-block
+++ b/Documentation/ABI/stable/sysfs-block
@@ -731,7 +731,7 @@ Contact:	linux-block@vger.kernel.org
 Description:
 		[RW] If the device is registered for writeback throttling, then
 		this file shows the target minimum read latency. If this latency
-		is exceeded in a given window of time (see wb_window_usec), then
+		is exceeded in a given window of time (see curr_win_nsec), then
 		the writeback throttling will start scaling back writes. Writing
 		a value of '0' to this file disables the feature. Writing a
 		value of '-1' to this file resets the value to the default
-- 
2.25.1
Re: [PATCH v3 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface
Posted by Jan Kara 2 months, 1 week ago
On Mon 28-07-25 01:39:59, Tang Yizhou wrote:
> From: Tang Yizhou <yizhou.tang@shopee.com>
> 
> The symbol wb_window_usec cannot be found. Update the doc to reflect the
> latest implementation, in other words, the debugfs interface
> 'curr_win_nsec'.
> 
> Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>

Looks good! Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  Documentation/ABI/stable/sysfs-block | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
> index 4ba771b56b3b..a3cf841ebdff 100644
> --- a/Documentation/ABI/stable/sysfs-block
> +++ b/Documentation/ABI/stable/sysfs-block
> @@ -731,7 +731,7 @@ Contact:	linux-block@vger.kernel.org
>  Description:
>  		[RW] If the device is registered for writeback throttling, then
>  		this file shows the target minimum read latency. If this latency
> -		is exceeded in a given window of time (see wb_window_usec), then
> +		is exceeded in a given window of time (see curr_win_nsec), then
>  		the writeback throttling will start scaling back writes. Writing
>  		a value of '0' to this file disables the feature. Writing a
>  		value of '-1' to this file resets the value to the default
> -- 
> 2.25.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
Re: [PATCH v3 3/3] blk-wbt: doc: Update the doc of the wbt_lat_usec interface
Posted by Yu Kuai 2 months, 1 week ago
在 2025/07/28 1:39, Tang Yizhou 写道:
> From: Tang Yizhou <yizhou.tang@shopee.com>
> 
> The symbol wb_window_usec cannot be found. Update the doc to reflect the
> latest implementation, in other words, the debugfs interface
> 'curr_win_nsec'.
> 
> Signed-off-by: Tang Yizhou <yizhou.tang@shopee.com>
> ---
>   Documentation/ABI/stable/sysfs-block | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Thanks

> diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block
> index 4ba771b56b3b..a3cf841ebdff 100644
> --- a/Documentation/ABI/stable/sysfs-block
> +++ b/Documentation/ABI/stable/sysfs-block
> @@ -731,7 +731,7 @@ Contact:	linux-block@vger.kernel.org
>   Description:
>   		[RW] If the device is registered for writeback throttling, then
>   		this file shows the target minimum read latency. If this latency
> -		is exceeded in a given window of time (see wb_window_usec), then
> +		is exceeded in a given window of time (see curr_win_nsec), then
>   		the writeback throttling will start scaling back writes. Writing
>   		a value of '0' to this file disables the feature. Writing a
>   		value of '-1' to this file resets the value to the default
>