mm/vmscan: fix inverted polarity in lru_gen_seq_show()

[PATCH] mm/vmscan: fix inverted polarity in lru_gen_seq_show()

Posted by Danilo Krummrich 2 months, 1 week ago

Commit a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
started using debugfs_get_aux_num() to distinguish between the RW
"lru_gen" and the RO "lru_gen_full" file [1].

Willy reported the inverted polarity [2] and Al fixed it up in [3].

However, the patch in [1] was applied. Hence, fix this up accordingly.

Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [1]
Link: https://lore.kernel.org/all/aGZu3Z730FQtqxsE@casper.infradead.org/ [2]
Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [3]
Fixes: a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 mm/vmscan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0e661672cbb9..27c70848c0a0 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -5756,9 +5756,9 @@ static int __init init_lru_gen(void)
 	if (sysfs_create_group(mm_kobj, &lru_gen_attr_group))
 		pr_err("lru_gen: failed to create sysfs group\n");
 
-	debugfs_create_file_aux_num("lru_gen", 0644, NULL, NULL, 1,
+	debugfs_create_file_aux_num("lru_gen", 0644, NULL, NULL, false,
 				    &lru_gen_rw_fops);
-	debugfs_create_file_aux_num("lru_gen_full", 0444, NULL, NULL, 0,
+	debugfs_create_file_aux_num("lru_gen_full", 0444, NULL, NULL, true,
 				    &lru_gen_ro_fops);
 
 	return 0;

base-commit: 51a486feac0ca002bee6429f03da0a6c206d0dc5
-- 
2.50.0

Re: [PATCH] mm/vmscan: fix inverted polarity in lru_gen_seq_show()

Posted by Danilo Krummrich 1 month, 3 weeks ago

On Sun Jul 27, 2025 at 12:59 PM CEST, Danilo Krummrich wrote:
> Commit a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
> started using debugfs_get_aux_num() to distinguish between the RW
> "lru_gen" and the RO "lru_gen_full" file [1].
>
> Willy reported the inverted polarity [2] and Al fixed it up in [3].
>
> However, the patch in [1] was applied. Hence, fix this up accordingly.
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [1]
> Link: https://lore.kernel.org/all/aGZu3Z730FQtqxsE@casper.infradead.org/ [2]
> Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [3]
> Fixes: a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Applied to driver-core-linus, thanks!

Re: [PATCH] mm/vmscan: fix inverted polarity in lru_gen_seq_show()

Posted by Greg KH 1 month, 3 weeks ago

On Sun, Aug 10, 2025 at 07:59:32PM +0200, Danilo Krummrich wrote:
> On Sun Jul 27, 2025 at 12:59 PM CEST, Danilo Krummrich wrote:
> > Commit a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
> > started using debugfs_get_aux_num() to distinguish between the RW
> > "lru_gen" and the RO "lru_gen_full" file [1].
> >
> > Willy reported the inverted polarity [2] and Al fixed it up in [3].
> >
> > However, the patch in [1] was applied. Hence, fix this up accordingly.
> >
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Matthew Wilcox <willy@infradead.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [1]
> > Link: https://lore.kernel.org/all/aGZu3Z730FQtqxsE@casper.infradead.org/ [2]
> > Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [3]
> > Fixes: a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
> > Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> 
> Applied to driver-core-linus, thanks!

Sorry for the delay, thanks for queueing this up.

greg k-h

Re: [PATCH] mm/vmscan: fix inverted polarity in lru_gen_seq_show()

Posted by Greg KH 2 months, 1 week ago

On Sun, Jul 27, 2025 at 12:59:06PM +0200, Danilo Krummrich wrote:
> Commit a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
> started using debugfs_get_aux_num() to distinguish between the RW
> "lru_gen" and the RO "lru_gen_full" file [1].
> 
> Willy reported the inverted polarity [2] and Al fixed it up in [3].
> 
> However, the patch in [1] was applied. Hence, fix this up accordingly.
> 
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [1]
> Link: https://lore.kernel.org/all/aGZu3Z730FQtqxsE@casper.infradead.org/ [2]
> Link: https://lore.kernel.org/all/20250704040720.GP1880847@ZenIV/ [3]
> Fixes: a7694ff11aa9 ("vmscan: don't bother with debugfs_real_fops()")
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> ---
>  mm/vmscan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Nice, thanks for fixing this up:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>