[v2] Manpage updates for iowait toggle feature and one extra FFI fix

[PATCH liburing v2 0/3] Manpage updates for iowait toggle feature and one extra FFI fix

Posted by Ammar Faizi 2 months, 1 week ago

[ 
  v2: Keep using IOURINGINLINE on __io_uring_buf_ring_cq_advance
      because it is in the FFI map file.

  Now, only remove `IOURINGINLINE` from these two private helpers:
    - __io_uring_set_target_fixed_file
    - __io_uring_peek_cqe

  I have verified these two functions are not in liburing-ffi.map.
  I will be more careful next time verifying the FFI map file.
]

Hi Jens,

As previously discussed on Discord, here are two manpage updates
about the iowait toggle feature. And then I have one extra FFI
trivial fix. The FFI fix is safe to apply for the liburing 2.12
release.

  - Add `io_uring_set_iowait(3)` manpage.

  - Add `IORING_ENTER_NO_IOWAIT` flag to `io_uring_enter(2)`

  - Don't use `IOURINGINLINE` on private helpers in `liburing.h`.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Ammar Faizi (3):
  man: Add `io_uring_set_iowait(3)`
  man: Add `IORING_ENTER_NO_IOWAIT` flag
  liburing: Don't use `IOURINGINLINE` on private helpers

 man/io_uring_enter.2      | 16 ++++++++++-
 man/io_uring_set_iowait.3 | 57 +++++++++++++++++++++++++++++++++++++++
 src/include/liburing.h    |  4 +--
 3 files changed, 74 insertions(+), 3 deletions(-)
 create mode 100644 man/io_uring_set_iowait.3


base-commit: 6d3d27bc42733f5a407424c76aadcc84bd4b0cf0
-- 
Ammar Faizi

Re: [PATCH liburing v2 0/3] Manpage updates for iowait toggle feature and one extra FFI fix

Posted by Jens Axboe 2 months, 1 week ago

On Sun, 27 Jul 2025 08:02:48 +0700, Ammar Faizi wrote:
> [
>   v2: Keep using IOURINGINLINE on __io_uring_buf_ring_cq_advance
>       because it is in the FFI map file.
> 
>   Now, only remove `IOURINGINLINE` from these two private helpers:
>     - __io_uring_set_target_fixed_file
>     - __io_uring_peek_cqe
> 
> [...]

Applied, thanks!

[1/3] man: Add `io_uring_set_iowait(3)`
      commit: 56116db9c371c6d2574709476ba697c0eee59284
[2/3] man: Add `IORING_ENTER_NO_IOWAIT` flag
      commit: 6ce9ab3f928a0959b6959b939c4a7ade652abee9
[3/3] liburing: Don't use `IOURINGINLINE` on private helpers
      commit: f2b6fb85b79baf17f2c0ea24a357c652caa2d7ba

Best regards,
-- 
Jens Axboe

Re: [PATCH liburing v2 0/3] Manpage updates for iowait toggle feature and one extra FFI fix

Posted by Ammar Faizi 2 months, 1 week ago

On Sun, Jul 27, 2025 at 8:02 AM Ammar Faizi wrote:
> [
>   v2: Keep using IOURINGINLINE on __io_uring_buf_ring_cq_advance
>       because it is in the FFI map file.
>
>   Now, only remove `IOURINGINLINE` from these two private helpers:
>     - __io_uring_set_target_fixed_file
>     - __io_uring_peek_cqe
>
>   I have verified these two functions are not in liburing-ffi.map.
>   I will be more careful next time verifying the FFI map file.
> ]
>
> Hi Jens,

Doh, I missed the To header in v2. Good that it's accessible via the
lore kernel.

-- 
Ammar Faizi