Add device tree bindings.
This device:
- Has not been supported previously in the mainline Linux kernel;
- Is a single board travel router made by Seeed, using an rk3568;
- Has four ethernet ports;
- Has four USB ports;
- Has WiFi (MediaTek MT7921e);
- Has a real-time clock (rk809)
Base commit:
- commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 ("tag: v6.16-rc1");
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Erik Beck <xunil@tahomasoft.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 5772d905f390e53b44f9093d32b869a7e0655db6..7f3904b69293f31fdd4f6080fab5ce054c1abee2 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -1109,6 +1109,11 @@ properties:
- const: rockchip,rk3588-toybrick-x0
- const: rockchip,rk3588
+ - description: Seeed LinkStar H68K-1432v1 RK3568
+ items:
+ - const: seeed,rk3568-linkstar-h68k-1432v1
+ - const: rockchip,rk3568
+
- description: Sinovoip RK3308 Banana Pi P2 Pro
items:
- const: sinovoip,rk3308-bpi-p2pro
--
2.43.0
On 28/07/2025 02:03, Erik Beck wrote:
> Add device tree bindings.
>
> This device:
> - Has not been supported previously in the mainline Linux kernel;
Irrelevant, drop.
> - Is a single board travel router made by Seeed, using an rk3568;
> - Has four ethernet ports;
> - Has four USB ports;
> - Has WiFi (MediaTek MT7921e);
> - Has a real-time clock (rk809)
>
> Base commit:
> - commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 ("tag: v6.16-rc1");
Irrelevant, drop. This should NEVER be part of commit msg, because it
makes no sense once applied. It is not even true in that moment.
>
Best regards,
Krzysztof
On Mon, Jul 28, 2025 at 07:07:32AM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2025 02:03, Erik Beck wrote:
> > Add device tree bindings.
> >
> > This device:
> > - Has not been supported previously in the mainline Linux kernel;
>
> Irrelevant, drop.
>
> > - Is a single board travel router made by Seeed, using an rk3568;
> > - Has four ethernet ports;
> > - Has four USB ports;
> > - Has WiFi (MediaTek MT7921e);
> > - Has a real-time clock (rk809)
> >
> > Base commit:
> > - commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 ("tag: v6.16-rc1");
>
> Irrelevant, drop. This should NEVER be part of commit msg, because it
> makes no sense once applied. It is not even true in that moment.
Also now I see checkpatch warnings...
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
© 2016 - 2026 Red Hat, Inc.