Fix comment ordering.

[PATCH] Fix comment ordering.

Posted by Blake Jones 6 months, 2 weeks ago

Commit edf2cadf01e8f2620af25b337d15ebc584911b46 ("perf test: add test for
BPF metadata collection") overlooked a behavior of "perf test list",
causing it to print "SPDX-License-Identifier: GPL-2.0" as a description for
that test. This reorders the comments to fix that issue.

Signed-off-by: Blake Jones <blakejones@google.com>
---
 tools/perf/tests/shell/test_bpf_metadata.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/shell/test_bpf_metadata.sh b/tools/perf/tests/shell/test_bpf_metadata.sh
index bc9aef161664..69e3c2055134 100755
--- a/tools/perf/tests/shell/test_bpf_metadata.sh
+++ b/tools/perf/tests/shell/test_bpf_metadata.sh
@@ -1,7 +1,7 @@
 #!/bin/bash
-# SPDX-License-Identifier: GPL-2.0
+# BPF metadata collection test
 #
-# BPF metadata collection test.
+# SPDX-License-Identifier: GPL-2.0
 
 set -e
 
-- 
2.50.1.470.g6ba607880d-goog

Re: [PATCH] Fix comment ordering.

Posted by Namhyung Kim 6 months, 2 weeks ago

On Fri, 25 Jul 2025 17:40:23 -0700, Blake Jones wrote:
> Commit edf2cadf01e8f2620af25b337d15ebc584911b46 ("perf test: add test for
> BPF metadata collection") overlooked a behavior of "perf test list",
> causing it to print "SPDX-License-Identifier: GPL-2.0" as a description for
> that test. This reorders the comments to fix that issue.
> 
> 
Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH] Fix comment ordering.

Posted by Ian Rogers 6 months, 2 weeks ago

On Fri, Jul 25, 2025 at 5:40 PM Blake Jones <blakejones@google.com> wrote:
>
> Commit edf2cadf01e8f2620af25b337d15ebc584911b46 ("perf test: add test for
> BPF metadata collection") overlooked a behavior of "perf test list",
> causing it to print "SPDX-License-Identifier: GPL-2.0" as a description for
> that test. This reorders the comments to fix that issue.
>
> Signed-off-by: Blake Jones <blakejones@google.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks!
Ian

> ---
>  tools/perf/tests/shell/test_bpf_metadata.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/test_bpf_metadata.sh b/tools/perf/tests/shell/test_bpf_metadata.sh
> index bc9aef161664..69e3c2055134 100755
> --- a/tools/perf/tests/shell/test_bpf_metadata.sh
> +++ b/tools/perf/tests/shell/test_bpf_metadata.sh
> @@ -1,7 +1,7 @@
>  #!/bin/bash
> -# SPDX-License-Identifier: GPL-2.0
> +# BPF metadata collection test
>  #
> -# BPF metadata collection test.
> +# SPDX-License-Identifier: GPL-2.0
>
>  set -e
>
> --
> 2.50.1.470.g6ba607880d-goog
>