Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor
controlled by I2C interface. Main applications includes joysticks, control
elements (white goods, multifunction knops), or electric meters (anti
tampering).
The device can be configured in to different operating modes by optional
device-tree "mode" property. Also, the temperature sensing part requires
raw offset captured at 25°C and that can be specified by "temp-offset"
optional device-tree property.
Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf
Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
---
.../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
new file mode 100644
index 000000000000..0442cf41503b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
+
+maintainers:
+ - Dixit Parmar <dixitparmar19@gmail.com>
+
+properties:
+ $nodename:
+ pattern: '^magnetometer@[0-9a-f]+$'
+
+ compatible:
+ const: infineon,tlv493d-a1b6
+
+ reg:
+ maxItems: 1
+
+ vdd-supply:
+ description: 2.8V to 3.5V supply
+
+ mode:
+ description: Sensor operating mode. Must be one of the defined enum values.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum:
+ - 0 # Power Down Mode. No measurement.
+ - 1 # Fast Mode
+ - 2 # Low-Power Mode
+ - 3 # Ultra Low-Power Mode
+ - 4 # Master Controlled Mode
+ default: 4
+
+ temp-offset:
+ description: Raw temperature offset at 25°C to apply before applying scale and correction.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ default: 340
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+example:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ magnetometer@5e {
+ compatible = "infineon,tlv493d-a1b6";
+ reg = <0x5e>;
+ vdd = <&hall_vcc>;
+ };
+ };
--
2.43.0
On Sat, 26 Jul 2025 15:07:02 +0530, Dixit Parmar wrote: > Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor > controlled by I2C interface. Main applications includes joysticks, control > elements (white goods, multifunction knops), or electric meters (anti > tampering). > > The device can be configured in to different operating modes by optional > device-tree "mode" property. Also, the temperature sensing part requires > raw offset captured at 25°C and that can be specified by "temp-offset" > optional device-tree property. > > Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf > > Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com> > --- > .../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Warning: Duplicate compatible "infineon,tlv493d-a1b6" found in schemas matching "$id": http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml# http://devicetree.org/schemas/trivial-devices.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml: 'example' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] from schema $id: http://devicetree.org/meta-schemas/base.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250726-tlv493d-sensor-v6_16-rc5-v1-2-deac027e6f32@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Sun, Jul 27, 2025 at 03:27:39PM -0500, Rob Herring (Arm) wrote: > > On Sat, 26 Jul 2025 15:07:02 +0530, Dixit Parmar wrote: > > Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor > > controlled by I2C interface. Main applications includes joysticks, control > > elements (white goods, multifunction knops), or electric meters (anti > > tampering). > > > > The device can be configured in to different operating modes by optional > > device-tree "mode" property. Also, the temperature sensing part requires > > raw offset captured at 25°C and that can be specified by "temp-offset" > > optional device-tree property. > > > > Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf > > > > Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com> > > --- > > .../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > Ack. > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Warning: Duplicate compatible "infineon,tlv493d-a1b6" found in schemas matching "$id": > http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml# > http://devicetree.org/schemas/trivial-devices.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml: 'example' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] > from schema $id: http://devicetree.org/meta-schemas/base.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250726-tlv493d-sensor-v6_16-rc5-v1-2-deac027e6f32@gmail.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
On 26/07/2025 11:37, Dixit Parmar wrote: > Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor > controlled by I2C interface. Main applications includes joysticks, control > elements (white goods, multifunction knops), or electric meters (anti > tampering). You are duplicating existing binding, need to remove it as well. > > The device can be configured in to different operating modes by optional > device-tree "mode" property. Also, the temperature sensing part requires > raw offset captured at 25°C and that can be specified by "temp-offset" > optional device-tree property. > > Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf > > Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com> > --- > .../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml > new file mode 100644 > index 000000000000..0442cf41503b > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor > + > +maintainers: > + - Dixit Parmar <dixitparmar19@gmail.com> > + > +properties: > + $nodename: > + pattern: '^magnetometer@[0-9a-f]+$' > + > + compatible: > + const: infineon,tlv493d-a1b6 > + > + reg: > + maxItems: 1 > + > + vdd-supply: > + description: 2.8V to 3.5V supply > + > + mode: > + description: Sensor operating mode. Must be one of the defined enum values. Why is this board level property? I imagine you want to change it runtime. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: > + - 0 # Power Down Mode. No measurement. > + - 1 # Fast Mode > + - 2 # Low-Power Mode > + - 3 # Ultra Low-Power Mode > + - 4 # Master Controlled Mode > + default: 4 > + > + temp-offset: > + description: Raw temperature offset at 25°C to apply before applying scale and correction. Does not look wrapped according to Linux coding style. > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 340 Missing vendor prefix, missing unit suffix. I am also not sure what is the board design choice to offset it. > + > +required: > + - compatible > + - reg Missing supplies. Best regards, Krzysztof
On Sun, Jul 27, 2025 at 11:23:04AM +0200, Krzysztof Kozlowski wrote: > On 26/07/2025 11:37, Dixit Parmar wrote: > > Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor > > controlled by I2C interface. Main applications includes joysticks, control > > elements (white goods, multifunction knops), or electric meters (anti > > tampering). > > You are duplicating existing binding, need to remove it as well. > Yeah, looks like some previous stalled entry is there. I will remove it. > > > > The device can be configured in to different operating modes by optional > > device-tree "mode" property. Also, the temperature sensing part requires > > raw offset captured at 25°C and that can be specified by "temp-offset" > > optional device-tree property. > > > > Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf > > > > Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com> > > --- > > .../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++ > > 1 file changed, 57 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml > > new file mode 100644 > > index 000000000000..0442cf41503b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor > > + > > +maintainers: > > + - Dixit Parmar <dixitparmar19@gmail.com> > > + > > +properties: > > + $nodename: > > + pattern: '^magnetometer@[0-9a-f]+$' > > + > > + compatible: > > + const: infineon,tlv493d-a1b6 > > + > > + reg: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: 2.8V to 3.5V supply > > + > > + mode: > > + description: Sensor operating mode. Must be one of the defined enum values. > > Why is this board level property? I imagine you want to change it runtime. > Acked. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: > > + - 0 # Power Down Mode. No measurement. > > + - 1 # Fast Mode > > + - 2 # Low-Power Mode > > + - 3 # Ultra Low-Power Mode > > + - 4 # Master Controlled Mode > > + default: 4 > > + > > + temp-offset: > > + description: Raw temperature offset at 25°C to apply before applying scale and correction. > > Does not look wrapped according to Linux coding style. > As mentioned in previous thread, the property will get removed. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + default: 340 > > Missing vendor prefix, missing unit suffix. I am also not sure what is > the board design choice to offset it. > > > > > + > > +required: > > + - compatible > > + - reg > > Missing supplies. > Ack. > > > Best regards, > Krzysztof Thanks for the review, Dixit
Hi Dixit, kernel test robot noticed the following build warnings: [auto build test WARNING on d7b8f8e20813f0179d8ef519541a3527e7661d3a] url: https://github.com/intel-lab-lkp/linux/commits/Dixit-Parmar/iio-magnetometer-add-support-for-Infineon-TLV493D-3D-Magentic-sensor/20250726-173919 base: d7b8f8e20813f0179d8ef519541a3527e7661d3a patch link: https://lore.kernel.org/r/20250726-tlv493d-sensor-v6_16-rc5-v1-2-deac027e6f32%40gmail.com patch subject: [PATCH 2/2] dt-bindings: iio: magnetometer: document Infineon TLV493D 3D Magnetic sensor config: csky-randconfig-051-20250727 (https://download.01.org/0day-ci/archive/20250727/202507270929.aFInjuAM-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 11.5.0 dtschema version: 2025.6.2.dev4+g8f79ddd reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250727/202507270929.aFInjuAM-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202507270929.aFInjuAM-lkp@intel.com/ All warnings (new ones prefixed by >>): >> Warning: Duplicate compatible "infineon,tlv493d-a1b6" found in schemas matching "$id": http://devicetree.org/schemas/trivial-devices.yaml# http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml# -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
On 7/26/25 4:37 AM, Dixit Parmar wrote:
> Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor
> controlled by I2C interface. Main applications includes joysticks, control
> elements (white goods, multifunction knops), or electric meters (anti
> tampering).
>
> The device can be configured in to different operating modes by optional
> device-tree "mode" property. Also, the temperature sensing part requires
> raw offset captured at 25°C and that can be specified by "temp-offset"
> optional device-tree property.
>
> Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf
>
> Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
> ---
> .../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
> new file mode 100644
> index 000000000000..0442cf41503b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
> +
> +maintainers:
> + - Dixit Parmar <dixitparmar19@gmail.com>
> +
> +properties:
> + $nodename:
> + pattern: '^magnetometer@[0-9a-f]+$'
> +
> + compatible:
> + const: infineon,tlv493d-a1b6
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: 2.8V to 3.5V supply
The SDA pin can also be a /INT signal, so we need to have an
optional interrupts property as well.
> +
> + mode:
> + description: Sensor operating mode. Must be one of the defined enum values.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # Power Down Mode. No measurement.
> + - 1 # Fast Mode
> + - 2 # Low-Power Mode
> + - 3 # Ultra Low-Power Mode
> + - 4 # Master Controlled Mode
> + default: 4
This is not the sort of thing that really belongs in a devicetree.
We should be describing here how the chip is wired up, and only
control how it works based on that.
If there are any wiring conditions that could affect this setting,
they could go here. For example, if the power supply doesn't have
enough current, then we can only operate in one of the low power
modes. Otherwise generally we just stick to the best performing
mode. And specifying the power down mode here really doesn't make
sense - you could never use the sensor!
> +
> + temp-offset:
> + description: Raw temperature offset at 25°C to apply before applying scale and correction.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 340
This is another one that likely doesn't belong in the devicetree.
There is a standard *_calibbias attribute that can be used for
such a calibration if needed.
> +
> +required:
> + - compatible
> + - reg
Power supplies are usually required.
> +
> +additionalProperties: false
> +
> +example:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + magnetometer@5e {
> + compatible = "infineon,tlv493d-a1b6";
> + reg = <0x5e>;
> + vdd = <&hall_vcc>;
> + };
> + };
>
On Sat, Jul 26, 2025 at 03:43:56PM -0500, David Lechner wrote:
> On 7/26/25 4:37 AM, Dixit Parmar wrote:
> > Document the bindings for Infineon TLV493D Low-Power 3D Magnetic Sensor
> > controlled by I2C interface. Main applications includes joysticks, control
> > elements (white goods, multifunction knops), or electric meters (anti
> > tampering).
> >
> > The device can be configured in to different operating modes by optional
> > device-tree "mode" property. Also, the temperature sensing part requires
> > raw offset captured at 25°C and that can be specified by "temp-offset"
> > optional device-tree property.
> >
> > Datasheet: https://www.infineon.com/assets/row/public/documents/24/49/infineon-tlv493d-a1b6-datasheet-en.pdf
> >
> > Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
> > ---
> > .../iio/magnetometer/infineon,tlv493d.yaml | 57 ++++++++++++++++++++++
> > 1 file changed, 57 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
> > new file mode 100644
> > index 000000000000..0442cf41503b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/magnetometer/infineon,tlv493d.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Infineon Technologies TLV493D Low-Power 3D Magnetic Sensor
> > +
> > +maintainers:
> > + - Dixit Parmar <dixitparmar19@gmail.com>
> > +
> > +properties:
> > + $nodename:
> > + pattern: '^magnetometer@[0-9a-f]+$'
> > +
> > + compatible:
> > + const: infineon,tlv493d-a1b6
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + vdd-supply:
> > + description: 2.8V to 3.5V supply
>
> The SDA pin can also be a /INT signal, so we need to have an
> optional interrupts property as well.
>
Okay. Will add it.
> > +
> > + mode:
> > + description: Sensor operating mode. Must be one of the defined enum values.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum:
> > + - 0 # Power Down Mode. No measurement.
> > + - 1 # Fast Mode
> > + - 2 # Low-Power Mode
> > + - 3 # Ultra Low-Power Mode
> > + - 4 # Master Controlled Mode
> > + default: 4
>
> This is not the sort of thing that really belongs in a devicetree.
> We should be describing here how the chip is wired up, and only
> control how it works based on that.
>
> If there are any wiring conditions that could affect this setting,
> they could go here. For example, if the power supply doesn't have
> enough current, then we can only operate in one of the low power
> modes. Otherwise generally we just stick to the best performing
> mode. And specifying the power down mode here really doesn't make
> sense - you could never use the sensor!
>
Got it. Will remove it.
> > +
> > + temp-offset:
> > + description: Raw temperature offset at 25°C to apply before applying scale and correction.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + default: 340
>
> This is another one that likely doesn't belong in the devicetree.
> There is a standard *_calibbias attribute that can be used for
> such a calibration if needed.
>
Its factory setting so I thought if there is any deviation from that
than we can handle it like this but as you pointed out, its not the
right way, so will stick to 340 default factory value as per the
datasheet.
> > +
> > +required:
> > + - compatible
> > + - reg
>
> Power supplies are usually required.
>
Ack.
> > +
> > +additionalProperties: false
> > +
> > +example:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + magnetometer@5e {
> > + compatible = "infineon,tlv493d-a1b6";
> > + reg = <0x5e>;
> > + vdd = <&hall_vcc>;
> > + };
> > + };
> >
>
Thanks for the review,
Dixit
© 2016 - 2025 Red Hat, Inc.