This patch focuses on cleaning up indentation (spaces, tabs) in the
AtomISP driver under drivers/staging/media/atomisp/pci/isp/kernels/.
There are no functional changes.
This version splits the original cleanup patch into four smaller patches,
following review feedback from Dan Carpenter to keep changes focused and easier to review.
---
Changes in v11:
- Split the original patch into four logically grouped patches:
* Patch 1: Fix indentation and kernel-doc in the aa module
* Patch 2: Fix indentation in the anr module
* Patch 3: Replace array-style initializer with designated initializer in anr
* Patch 4: Fix indentation in the bh module
- Moved inline kernel-doc comment to the correct structure location in ia_css_aa2_types.h
- Dropped trailing commas from array and struct initializers, following
Dan Carpenter’s suggestion to keep the patch minimal and avoid unrelated
style changes.
- Thanks to Andy Shevchenko for his earlier reviews and for advocating the
use of trailing commas to reduce future diff churn. In this version,
I chose to prioritize minimalism and alignment with the main review direction.
- Updated commit messages accordingly.
- Link to v10: https://lore.kernel.org/r/20250718-new_atomisp-v10-1-54bdff660058@gmail.com
Changes in v10:
- Squashed previous aa/anr/bh patches into a single patch
- Rewrote commit message to reflect actual changes
- Removed unnecessary Suggested-by and Link tags as advised
- Added trailing comma to array initialization as suggested
- Link to v9: https://lore.kernel.org/r/20250711-new_atomisp-v9-0-a9dd62425ef6@gmail.com
Changes in v9:
- Reformatted struct comments to follow kernel-doc format
- Reverted macro definition changes that removed alignment
- Reverted multi-line array initializations to use brace-on-own-line style
- Added trailing comma in small array initializations
- Adjusted function declarations to follow kernel-style indentation
- Removed unnecessary churn in cases where code was already style-compliant
- Link to v8: https://lore.kernel.org/r/20250704-new_atomisp-v8-0-2a8560cbd9be@gmail.com
Changes in v8:
- Reorganized cleanup by subdirectory (one commit per directory)
- Focused only on indentation fixes (spaces, tabs)
- Removed all clang-format involvement
- No functional changes
- Link to v7: https://lore.kernel.org/all/20250629113050.58138-1-zaq14760@gmail.com/
Changes in v7:
- Split previous monolithic patch into multiple smaller patches
- Applied clang-format to entire driver excluding i2c directory
- Fixed checkpatch.pl-reported ERRORs (parentheses in macros, unnecessary return parentheses, zero-initialized globals, spaces after unary minus)
- Left WARNINGS untouched for future cleanup
- No functional logic changes
- Link to v6: https://lore.kernel.org/r/20250627-bar-v6-1-b22b5ea3ced0@gmail.com
Changes in v6:
- Applied clang-format across the entire AtomISP driver
- Fixed all checkpatch.pl-reported ERRORs
- Added explanation of tooling and scope
- No functional logic modified
- Moved 'Suggested-by' and 'Link' tags above Signed-off-by
- Link to v5: https://lore.kernel.org/r/20250625-bar-v5-1-db960608b607@gmail.com
Changes in v5:
- Replaced space-based indentation with tabs in output_1.0 directory
- Used checkpatch.pl and grep to identify formatting issues
- No functional changes made
- This patch is now focused solely on tab/space issues
- Link to v4: https://lore.kernel.org/r/20250624-bar-v4-1-9f9f9ae9f868@gmail.com
Changes in v4:
- Moved assignment operator '=' to the same line for static struct definitions
- Remove unnecessary line breaks in function definitions
- Update commit message to reflect all the coding style fixes
- Link to v3: https://lore.kernel.org/r/20250622-bar-v3-1-4cc91ef01c3a@gmail.com
Changes in v3:
- Removed extra spaces between type and asterisk (e.g., `*to`) in function
declarations, as pointed out by Andy Shevchenko
- Update commit message to reflect all the coding style fixes
- Link to v2: https://lore.kernel.org/r/20250621-bar-v2-1-4e6cfc779614@gmail.com
Changes in v2:
- Fix patch subject prefix to "staging: media: atomisp:" to comply with media CI style.
- No other functional changes.
- Link to v1: https://lore.kernel.org/r/20250621-bar-v1-1-5a3e7004462c@gmail.com
Thanks for your previous feedback.
Best regards,
LiangCheng Wang <zaq14760@gmail.com>
Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
---
LiangCheng Wang (4):
staging: media: atomisp: improve kernel-doc for ia_css_aa_config
staging: media: atomisp: fix indentation in anr files
staging: media: atomisp: use designated initializer in anr config
staging: media: atomisp: fix indentation in bh host files
.../pci/isp/kernels/aa/aa_2/ia_css_aa2_types.h | 8 ++++---
.../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.c | 26 +++++++++-------------
.../pci/isp/kernels/anr/anr_1.0/ia_css_anr.host.h | 20 ++++++-----------
.../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.c | 14 +++++-------
.../pci/isp/kernels/anr/anr_2/ia_css_anr2.host.h | 13 +++++------
.../pci/isp/kernels/bh/bh_2/ia_css_bh.host.c | 14 +++++-------
.../pci/isp/kernels/bh/bh_2/ia_css_bh.host.h | 14 +++++-------
7 files changed, 42 insertions(+), 67 deletions(-)
---
base-commit: 8c2e52ebbe885c7eeaabd3b7ddcdc1246fc400d2
change-id: 20250704-new_atomisp-e73f471f3078
Best regards,
--
LiangCheng Wang <zaq14760@gmail.com>