[PATCH 4/5] net: mtk_eth_soc: fix device leak at probe

Johan Hovold posted 5 patches 2 months, 1 week ago
[PATCH 4/5] net: mtk_eth_soc: fix device leak at probe
Posted by Johan Hovold 2 months, 1 week ago
The reference count to the WED devices has already been incremented when
looking them up using of_find_device_by_node() so drop the bogus
additional reference taken during probe.

Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
Cc: stable@vger.kernel.org	# 5.19
Cc: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/net/ethernet/mediatek/mtk_wed.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet/mediatek/mtk_wed.c
index 351dd152f4f3..4f3014fc389b 100644
--- a/drivers/net/ethernet/mediatek/mtk_wed.c
+++ b/drivers/net/ethernet/mediatek/mtk_wed.c
@@ -2794,7 +2794,6 @@ void mtk_wed_add_hw(struct device_node *np, struct mtk_eth *eth,
 	if (!pdev)
 		goto err_of_node_put;
 
-	get_device(&pdev->dev);
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0)
 		goto err_put_device;
-- 
2.49.1
Re: [PATCH 4/5] net: mtk_eth_soc: fix device leak at probe
Posted by Simon Horman 2 months, 1 week ago
On Fri, Jul 25, 2025 at 07:12:12PM +0200, Johan Hovold wrote:
> The reference count to the WED devices has already been incremented when
> looking them up using of_find_device_by_node() so drop the bogus
> additional reference taken during probe.
> 
> Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)")
> Cc: stable@vger.kernel.org	# 5.19
> Cc: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Simon Horman <horms@kernel.org>