[PATCH 1/6] dt-bindings: gpio: snps,dw-apb: Add support for Renesas RZ/N1

Herve Codina posted 6 patches 2 months, 1 week ago
There is a newer version of this series
[PATCH 1/6] dt-bindings: gpio: snps,dw-apb: Add support for Renesas RZ/N1
Posted by Herve Codina 2 months, 1 week ago
The RZ/N1 SoCs uses the Synopsys DesignWare IP to handle GPIO blocks.

Add RZ/N1 SoC and family compatible strings.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 .../devicetree/bindings/gpio/snps,dw-apb-gpio.yaml        | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
index ab2afc0e4153..ceb71b5ac688 100644
--- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
@@ -20,7 +20,13 @@ properties:
     pattern: "^gpio@[0-9a-f]+$"
 
   compatible:
-    const: snps,dw-apb-gpio
+    oneOf:
+      - const: snps,dw-apb-gpio
+      - items:
+          - enum:
+              - renesas,r9a06g032-gpio
+          - const: renesas,rzn1-gpio
+          - const: snps,dw-apb-gpio
 
   "#address-cells":
     const: 1
-- 
2.50.1
Re: [PATCH 1/6] dt-bindings: gpio: snps,dw-apb: Add support for Renesas RZ/N1
Posted by Rob Herring 2 months, 1 week ago
On Fri, Jul 25, 2025 at 05:26:10PM +0200, Herve Codina wrote:
> The RZ/N1 SoCs uses the Synopsys DesignWare IP to handle GPIO blocks.
> 
> Add RZ/N1 SoC and family compatible strings.

Why? Yes, that's policy, but so far we avoided it on this IP. Perhaps 
because it is simple enough. So what's different here?

> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
>  .../devicetree/bindings/gpio/snps,dw-apb-gpio.yaml        | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
> index ab2afc0e4153..ceb71b5ac688 100644
> --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml
> @@ -20,7 +20,13 @@ properties:
>      pattern: "^gpio@[0-9a-f]+$"
>  
>    compatible:
> -    const: snps,dw-apb-gpio
> +    oneOf:
> +      - const: snps,dw-apb-gpio
> +      - items:
> +          - enum:
> +              - renesas,r9a06g032-gpio
> +          - const: renesas,rzn1-gpio
> +          - const: snps,dw-apb-gpio
>  
>    "#address-cells":
>      const: 1
> -- 
> 2.50.1
>
Re: [PATCH 1/6] dt-bindings: gpio: snps,dw-apb: Add support for Renesas RZ/N1
Posted by Herve Codina 2 months, 1 week ago
Hi Rob,

On Tue, 29 Jul 2025 13:11:51 -0500
Rob Herring <robh@kernel.org> wrote:

> On Fri, Jul 25, 2025 at 05:26:10PM +0200, Herve Codina wrote:
> > The RZ/N1 SoCs uses the Synopsys DesignWare IP to handle GPIO blocks.
> > 
> > Add RZ/N1 SoC and family compatible strings.  
> 
> Why? Yes, that's policy, but so far we avoided it on this IP. Perhaps 
> because it is simple enough. So what's different here?

I've just followed Renesas policy.

Nothing other than this policy justifies the change and so, I can remove
the Renesas compatible strings. In other words, I can simply remove this
patch.

Best regards,
Hervé