rtc: pcf85063: hide an unused variable

[PATCH] rtc: pcf85063: hide an unused variable

Posted by Arnd Bergmann 2 months, 1 week ago

From: Arnd Bergmann <arnd@arndb.de>

The newly introduced configuration is only used by code that is
inside of an #ifdef block, cauing a warning when that block is
disabled by the configuration is still there:

drivers/rtc/rtc-pcf85063.c:566:37: error: 'config_rv8063' defined but not used [-Werror=unused-const-variable=]

Add the same #ifdef here.

Fixes: a3c7f7e16ea8 ("rtc: pcf85063: add support for RV8063")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/rtc/rtc-pcf85063.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index d9b67b959d18..41e4a5a16574 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -563,6 +563,7 @@ static const struct pcf85063_config config_rv8263 = {
 	.force_cap_7000 = 1,
 };
 
+#if IS_ENABLED(CONFIG_SPI_MASTER)
 static const struct pcf85063_config config_rv8063 = {
 	.regmap = {
 		.reg_bits = 8,
@@ -574,6 +575,7 @@ static const struct pcf85063_config config_rv8063 = {
 	.has_alarms = 1,
 	.force_cap_7000 = 1,
 };
+#endif
 
 static int pcf85063_probe(struct device *dev, struct regmap *regmap, int irq,
 			  const struct pcf85063_config *config)
-- 
2.39.5

Re: [PATCH] rtc: pcf85063: hide an unused variable

Posted by Alexander Sverdlin 1 month, 3 weeks ago

On Fri, 2025-07-25 at 11:07 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly introduced configuration is only used by code that is
> inside of an #ifdef block, cauing a warning when that block is
> disabled by the configuration is still there:
> 
> drivers/rtc/rtc-pcf85063.c:566:37: error: 'config_rv8063' defined but not used [-Werror=unused-const-variable=]
> 
> Add the same #ifdef here.
> 
> Fixes: a3c7f7e16ea8 ("rtc: pcf85063: add support for RV8063")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

> ---
>  drivers/rtc/rtc-pcf85063.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
> index d9b67b959d18..41e4a5a16574 100644
> --- a/drivers/rtc/rtc-pcf85063.c
> +++ b/drivers/rtc/rtc-pcf85063.c
> @@ -563,6 +563,7 @@ static const struct pcf85063_config config_rv8263 = {
>  	.force_cap_7000 = 1,
>  };
>  
> +#if IS_ENABLED(CONFIG_SPI_MASTER)
>  static const struct pcf85063_config config_rv8063 = {
>  	.regmap = {
>  		.reg_bits = 8,
> @@ -574,6 +575,7 @@ static const struct pcf85063_config config_rv8063 = {
>  	.has_alarms = 1,
>  	.force_cap_7000 = 1,
>  };
> +#endif
>  
>  static int pcf85063_probe(struct device *dev, struct regmap *regmap, int irq,
>  			  const struct pcf85063_config *config)

-- 
Alexander Sverdlin.