Enabling compile testing should not enable every individual driver (we
have "allyesconfig" for that).

Fixes: 4a434abc40d2 ("firmware: meson-sm: enable build as module")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/firmware/meson/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/meson/Kconfig b/drivers/firmware/meson/Kconfig
index f2fdd3756648..179f5d46d8dd 100644
--- a/drivers/firmware/meson/Kconfig
+++ b/drivers/firmware/meson/Kconfig
@@ -5,7 +5,7 @@
 config MESON_SM
 	tristate "Amlogic Secure Monitor driver"
 	depends on ARCH_MESON || COMPILE_TEST
-	default y
+	default ARCH_MESON
 	depends on ARM64_4K_PAGES
 	help
 	  Say y here to enable the Amlogic secure monitor driver
-- 
2.49.1

Hi,

On Fri, 25 Jul 2025 09:54:29 +0200, Johan Hovold wrote:
> Enabling compile testing should not enable every individual driver (we
> have "allyesconfig" for that).
> 
> 

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.18/drivers)

[1/1] firmware: firmware: meson-sm: fix compile-test default
      https://git.kernel.org/amlogic/c/0454346d1c5f7fccb3ef6e3103985de8ab3469f3

These changes has been applied on the intermediate git tree [1].

The v6.18/drivers branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil

On 25/07/2025 09:54, Johan Hovold wrote:
> Enabling compile testing should not enable every individual driver (we
> have "allyesconfig" for that).
> 
> Fixes: 4a434abc40d2 ("firmware: meson-sm: enable build as module")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>   drivers/firmware/meson/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/meson/Kconfig b/drivers/firmware/meson/Kconfig
> index f2fdd3756648..179f5d46d8dd 100644
> --- a/drivers/firmware/meson/Kconfig
> +++ b/drivers/firmware/meson/Kconfig
> @@ -5,7 +5,7 @@
>   config MESON_SM
>   	tristate "Amlogic Secure Monitor driver"
>   	depends on ARCH_MESON || COMPILE_TEST
> -	default y
> +	default ARCH_MESON
>   	depends on ARM64_4K_PAGES
>   	help
>   	  Say y here to enable the Amlogic secure monitor driver

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Hi Neil,

On Mon, Jul 28, 2025 at 05:42:00PM +0200, Neil Armstrong wrote:
> On 25/07/2025 09:54, Johan Hovold wrote:
> > Enabling compile testing should not enable every individual driver (we
> > have "allyesconfig" for that).
> > 
> > Fixes: 4a434abc40d2 ("firmware: meson-sm: enable build as module")
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >   drivers/firmware/meson/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/firmware/meson/Kconfig b/drivers/firmware/meson/Kconfig
> > index f2fdd3756648..179f5d46d8dd 100644
> > --- a/drivers/firmware/meson/Kconfig
> > +++ b/drivers/firmware/meson/Kconfig
> > @@ -5,7 +5,7 @@
> >   config MESON_SM
> >   	tristate "Amlogic Secure Monitor driver"
> >   	depends on ARCH_MESON || COMPILE_TEST
> > -	default y
> > +	default ARCH_MESON
> >   	depends on ARM64_4K_PAGES
> >   	help
> >   	  Say y here to enable the Amlogic secure monitor driver
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Could you pick this one up for 6.18 as well?

I noticed that there's a duplicate "firmware: " in Subject, perhaps you
can fix that up when applying?

Johan