The new STMicroelectronics SoC features a display controller similar to
the one used in previous SoCs. Because there is additional registers,
it is incompatible with existing IPs.
Add the new name to the list of compatible string.
Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
---
.../devicetree/bindings/display/st,stm32-ltdc.yaml | 37 +++++++++++++++++++---
1 file changed, 33 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
index d6ea4d62a2cfae26353c9f20a326a4329fed3a2f..546f57cb7a402b82e868aa05f874c65b8da19444 100644
--- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
+++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml
@@ -12,7 +12,9 @@ maintainers:
properties:
compatible:
- const: st,stm32-ltdc
+ enum:
+ - st,stm32-ltdc
+ - st,stm32mp25-ltdc
reg:
maxItems: 1
@@ -24,11 +26,12 @@ properties:
minItems: 1
clocks:
- maxItems: 1
+ minItems: 1
+ maxItems: 4
clock-names:
- items:
- - const: lcd
+ minItems: 1
+ maxItems: 4
resets:
maxItems: 1
@@ -51,6 +54,32 @@ required:
- resets
- port
+if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - st,stm32-ltdc
+then:
+ properties:
+ clocks:
+ maxItems: 1
+ clock-names:
+ maxItems: 1
+ items:
+ - const: lcd
+else:
+ properties:
+ clocks:
+ maxItems: 4
+ clock-names:
+ maxItems: 4
+ items:
+ - const: bus
+ - const: lcd
+ - const: ref
+ - const: lvds
+
additionalProperties: false
examples:
--
2.25.1On Fri, Jul 25, 2025 at 12:03:53PM +0200, Raphael Gallais-Pou wrote: > The new STMicroelectronics SoC features a display controller similar to > the one used in previous SoCs. Because there is additional registers, > it is incompatible with existing IPs. > > Add the new name to the list of compatible string. > > Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> > --- > .../devicetree/bindings/display/st,stm32-ltdc.yaml | 37 +++++++++++++++++++--- > 1 file changed, 33 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml > index d6ea4d62a2cfae26353c9f20a326a4329fed3a2f..546f57cb7a402b82e868aa05f874c65b8da19444 100644 > --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml > +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml > @@ -12,7 +12,9 @@ maintainers: > > properties: > compatible: > - const: st,stm32-ltdc > + enum: > + - st,stm32-ltdc > + - st,stm32mp25-ltdc > > reg: > maxItems: 1 > @@ -24,11 +26,12 @@ properties: > minItems: 1 > > clocks: > - maxItems: 1 > + minItems: 1 > + maxItems: 4 > > clock-names: > - items: > - - const: lcd > + minItems: 1 > + maxItems: 4 > > resets: > maxItems: 1 > @@ -51,6 +54,32 @@ required: > - resets > - port > > +if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32-ltdc > +then: > + properties: > + clocks: > + maxItems: 1 > + clock-names: > + maxItems: 1 > + items: > + - const: lcd > +else: > + properties: > + clocks: > + maxItems: 4 > + clock-names: > + maxItems: 4 > + items: > + - const: bus > + - const: lcd Why can't 'lcd' be 1st so you aren't changing positions? Keep the items list at the top level and just use minItems/maxItems in the if/then schemas. > + - const: ref > + - const: lvds > + > additionalProperties: false > > examples: > > -- > 2.25.1 >
On 7/25/25 21:49, Rob Herring wrote: > On Fri, Jul 25, 2025 at 12:03:53PM +0200, Raphael Gallais-Pou wrote: >> The new STMicroelectronics SoC features a display controller similar to >> the one used in previous SoCs. Because there is additional registers, >> it is incompatible with existing IPs. >> >> Add the new name to the list of compatible string. >> >> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> >> --- >> .../devicetree/bindings/display/st,stm32-ltdc.yaml | 37 +++++++++++++++++++--- >> 1 file changed, 33 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml >> index d6ea4d62a2cfae26353c9f20a326a4329fed3a2f..546f57cb7a402b82e868aa05f874c65b8da19444 100644 >> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml >> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml >> @@ -12,7 +12,9 @@ maintainers: >> >> properties: >> compatible: >> - const: st,stm32-ltdc >> + enum: >> + - st,stm32-ltdc >> + - st,stm32mp25-ltdc >> >> reg: >> maxItems: 1 >> @@ -24,11 +26,12 @@ properties: >> minItems: 1 >> >> clocks: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 4 >> >> clock-names: >> - items: >> - - const: lcd >> + minItems: 1 >> + maxItems: 4 >> >> resets: >> maxItems: 1 >> @@ -51,6 +54,32 @@ required: >> - resets >> - port >> >> +if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - st,stm32-ltdc >> +then: >> + properties: >> + clocks: >> + maxItems: 1 >> + clock-names: >> + maxItems: 1 >> + items: >> + - const: lcd >> +else: >> + properties: >> + clocks: >> + maxItems: 4 >> + clock-names: >> + maxItems: 4 >> + items: >> + - const: bus >> + - const: lcd > Why can't 'lcd' be 1st so you aren't changing positions? Keep the items > list at the top level and just use minItems/maxItems in the if/then > schemas. Hi Rob, I've set the name order to match the stm32mp255.dtsi device-tree, so that it does not confuse anybody regarding which clock goes with. Your comment is taken into account for the upcoming version. Thanks, Raphaël > >> + - const: ref >> + - const: lvds >> + >> additionalProperties: false >> >> examples: >> >> -- >> 2.25.1 >>
On Fri, 25 Jul 2025 12:03:53 +0200, Raphael Gallais-Pou wrote:
> The new STMicroelectronics SoC features a display controller similar to
> the one used in previous SoCs. Because there is additional registers,
> it is incompatible with existing IPs.
>
> Add the new name to the list of compatible string.
>
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> ---
> .../devicetree/bindings/display/st,stm32-ltdc.yaml | 37 +++++++++++++++++++---
> 1 file changed, 33 insertions(+), 4 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml:78:7: [warning] wrong indentation: expected 8 but found 6 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml: else:properties:clock-names: {'maxItems': 4, 'items': [{'const': 'bus'}, {'const': 'lcd'}, {'const': 'ref'}, {'const': 'lvds'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/st,stm32-ltdc.yaml: then:properties:clock-names: {'maxItems': 1, 'items': [{'const': 'lcd'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250725-drm-misc-next-v1-1-a59848e62cf9@foss.st.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
© 2016 - 2025 Red Hat, Inc.