drivers/crypto/caam/ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
From: Zhang Enpei <zhang.enpei@zte.com.cn>
Use devm_kmemdup_array() to avoid multiplication or possible overflows.
Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
---
drivers/crypto/caam/ctrl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index ce7b99019537..2250dce9c344 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -592,9 +592,9 @@ static int init_clocks(struct device *dev, const struct caam_imx_data *data)
int ret;
ctrlpriv->num_clks = data->num_clks;
- ctrlpriv->clks = devm_kmemdup(dev, data->clks,
- data->num_clks * sizeof(data->clks[0]),
- GFP_KERNEL);
+ ctrlpriv->clks = devm_kmemdup_array(dev, data->clks,
+ data->num_clks, sizeof(*data->clks),
+ GFP_KERNEL);
if (!ctrlpriv->clks)
return -ENOMEM;
--
2.25.1
On Wed, Jul 23, 2025 at 10:50:27AM +0800, zhang.enpei@zte.com.cn wrote: > From: Zhang Enpei <zhang.enpei@zte.com.cn> > > Use devm_kmemdup_array() to avoid multiplication or possible overflows. > > Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn> > --- > drivers/crypto/caam/ctrl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c > index ce7b99019537..2250dce9c344 100644 > --- a/drivers/crypto/caam/ctrl.c > +++ b/drivers/crypto/caam/ctrl.c > @@ -592,9 +592,9 @@ static int init_clocks(struct device *dev, const struct caam_imx_data *data) > int ret; > > ctrlpriv->num_clks = data->num_clks; > - ctrlpriv->clks = devm_kmemdup(dev, data->clks, > - data->num_clks * sizeof(data->clks[0]), > - GFP_KERNEL); > + ctrlpriv->clks = devm_kmemdup_array(dev, data->clks, > + data->num_clks, sizeof(*data->clks), > + GFP_KERNEL); > if (!ctrlpriv->clks) > return -ENOMEM; This patch doesn't apply because it is space-damaged. Please resubmit. Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 7/23/2025 5:51 AM, zhang.enpei@zte.com.cn wrote: > From: Zhang Enpei <zhang.enpei@zte.com.cn> > > Use devm_kmemdup_array() to avoid multiplication or possible overflows. > > Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn> Reviewed-by: Horia Geantă <horia.geanta@nxp.com> Thanks, Horia
Thanks for your review! I'm curious about whether this patch could be applied or not. If it could, when will it be merged? Regards, Zhang ------------------Original------------------ From: horia.geanta <horia.geanta@nxp.com> To: Zhang Enpei10344075; Cc: pankaj.gupta <pankaj.gupta@nxp.com>;gaurav.jain <gaurav.jain@nxp.com>;herbert <herbert@gondor.apana.org.au>;davem <davem@davemloft.net>;linux-crypto <linux-crypto@vger.kernel.org>;linux-kernel <linux-kernel@vger.kernel.org>;christophe.jaillet <christophe.jaillet@wanadoo.fr>; Date: 2025/07/25 16:01 Subject: Re: [PATCH v2] crypto: caam - switch to use devm_kmemdup_array() On 7/23/2025 5:51 AM, zhang.enpei@zte.com.cn wrote: > From: Zhang Enpei <zhang.enpei@zte.com.cn> > > Use devm_kmemdup_array() to avoid multiplication or possible overflows. > > Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn> Reviewed-by: Horia Geantă <horia.geanta@nxp.com> Thanks, Horia
On 8/21/2025 2:30 PM, zhang.enpei@zte.com.cn wrote: > Thanks for your review! > I'm curious about whether this patch could be applied or not. If it could, when will it be merged? > Looks like you've missed Herbert's reply: https://lore.kernel.org/linux-crypto/aKBNn7qgBVhJcLhq@gondor.apana.org.au/ Regards, Horia Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms080004020003080601010405" --------------ms080004020003080601010405 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 8/21/2025 2:30 PM, zhang.enpei@zte.com.cn wrote: > Thanks for your review! > I'm curious about whether this patch could be applied or not. If it cou= ld, when will it be merged? >=20 Looks like you've missed Herbert's reply: https://lore.kernel.org/linux-crypto/aKBNn7qgBVhJcLhq@gondor.apana.org.au= / Regards, Horia --------------ms080004020003080601010405 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC E2swggWiMIIDiqADAgECAghOEabvh+vRUTANBgkqhkiG9w0BAQsFADBlMSIwIAYDVQQDDBlO WFAgSW50ZXJuYWwgUG9saWN5IENBIEcyMQswCQYDVQQLDAJJVDERMA8GA1UECgwITlhQIEIu Vi4xEjAQBgNVBAcMCUVpbmRob3ZlbjELMAkGA1UEBhMCTkwwHhcNMjMwNDIxMDY0MzQ1WhcN MjgwNDE5MDY0MzQ1WjCBtjEcMBoGA1UEAwwTTlhQIEVudGVycHJpc2UgQ0EgNTELMAkGA1UE CwwCSVQxETAPBgNVBAoMCE5YUCBCLlYuMRIwEAYDVQQHDAlFaW5kaG92ZW4xFjAUBgNVBAgM DU5vb3JkLUJyYWJhbnQxEzARBgoJkiaJk/IsZAEZFgN3YmkxEzARBgoJkiaJk/IsZAEZFgNu eHAxEzARBgoJkiaJk/IsZAEZFgNjb20xCzAJBgNVBAYTAk5MMIIBIjANBgkqhkiG9w0BAQEF AAOCAQ8AMIIBCgKCAQEAwFq50pGD+tAPMI+ADpAEw4523YC7+sGhX8lxP4b2rXVs9mGLW9WE kYuf8F1vj8/K7E5ko+4rrCPhXCz/FhGjFS5+LBCEGDSPCiVAs9tbbCAK2LNITChFBXgqt5sU yXz6s3Y/QhMSQZWeb1kuHq/HiSPFPJGa7eAqGOw3tBXSYd+T4uUBs1BZhbmi4F31dTecrpE8 xIas9+pDg6EkcPngxx/WKm83n8xByvXfd0zYi2lZZZ+NjtKmiDJsStWjXGcfp0JBbBf1a1fT PYixgPkG/zBZkdtDCQFOZERpCdv0M4FUDNzZZqf2xf9x1jido9pqYGsb88RzTfua0jb5Btr0 qQIDAQABo4IBAjCB/zBSBggrBgEFBQcBAQRGMEQwQgYIKwYBBQUHMAKGNmh0dHA6Ly9ud3cu cGtpLm54cC5jb20vY2VydHMvTlhQSW50ZXJuYWxQb2xpY3lDQUcyLmNlcjAdBgNVHQ4EFgQU WJVg7k5072Uiqr3tGakreo4XnQcwEgYDVR0TAQH/BAgwBgEB/wIBADBFBgNVHR8EPjA8MDqg OKA2hjRodHRwOi8vbnd3LnBraS5ueHAuY29tL2NybC9OWFBJbnRlcm5hbFBvbGljeUNBRzIu Y3JsMB8GA1UdIwQYMBaAFHnhSQHge840OSlDGTJlYTwG2FWrMA4GA1UdDwEB/wQEAwIBBjAN BgkqhkiG9w0BAQsFAAOCAgEAEG1ofB/QfP71N1ICscF7tgvXSXbaLpDucwPAd/YALIl/xXFQ fY/H62Ozrqm7xf6rOUjRnSEjCLlw6xeRUhr2OWfhGXGIp+M9KacA69CM1V88OTb6KYBIerA1 4D4QgofeRjKbfbhw7mr9SaOXXzfQlge/A/t3aAythXB1sU+s3wTl0OvXO6YqAc+a+RT9Ho+B 81ls2FMViXzHELscCEXyEjNRi3F9y5Yogd0d3g1Ccr4LD4Zu3fg9UCIBJci6VCSft0maVyum VZEJS3KRBtNSZeUSu3tIOxdhhp/HZE5tltxPakZxy58I94IZ3sGEzpPElgETexKXtHz33l8k tP4BxIse4mLOGnNsvC9ABtoG3oBACgE1ksU4DfwLfuTCz6p0LopVGSpXI4LQzM4Z0iStgK5r hF0xCVGv9H8CrJyELoReEDjakp5vPkEm/v7kZvyFnFuS7glLscLn0A87aO15XNatXaToILVC SPiKI0pc033h5IGDa9lxWeAa5GNIvFRVZp6onIbCTjNvs6kFOGRrM3Rc/0Sw+JizAr5rDM0S O4yIO35EHq9wryGZAcEtcY5ePmRq5M8mZsx8j9u+Fez0smM7ZF72K/wpE4IyLviRurxhDfC7 lV7ewJsA+1jRfDCgJDzhSClh174sqLShkW9CZcdl8GIKGlw+TaGtY8AfJCkwggX8MIID5KAD AgECAgg4IAFWH4OCCTANBgkqhkiG9w0BAQsFADBaMRcwFQYDVQQDDA5OWFAgUk9PVCBDQSBH MjELMAkGA1UECwwCSVQxETAPBgNVBAoMCE5YUCBCLlYuMRIwEAYDVQQHDAlFaW5kaG92ZW4x CzAJBgNVBAYTAk5MMB4XDTIyMDkzMDA4MjUyOVoXDTMyMDkyOTA4MjUyOVowZTEiMCAGA1UE AwwZTlhQIEludGVybmFsIFBvbGljeSBDQSBHMjELMAkGA1UECwwCSVQxETAPBgNVBAoMCE5Y UCBCLlYuMRIwEAYDVQQHDAlFaW5kaG92ZW4xCzAJBgNVBAYTAk5MMIICIjANBgkqhkiG9w0B AQEFAAOCAg8AMIICCgKCAgEApcu/gliwg0dn1d35U0pZLMvwbNGN1WW/15pqzBcpG/ZBq5q+ ygq4/zkEqQAM3cZsSi2U2tjiKZOEfj4csyEJVZFQiwXMptsmErfk7BMoLtaIN79vFOd1bzdj W0HaSTb9GkJ7CTcb7z/FKKiwc2j53VVNDR1xVBnUNEaB1AzQOkp6hgupCgnlkw9X+/2+i7UC ipk2JWLspg9srFaH0vwrgMFxEfs41y6iBVD70R/4+suoatXvgFv3ltGZ3x/hak3N1hHkjJq3 oa1jSkLmp6KoQAqbcHTkeKomMOmPUJK1YqDkpdbGuuRkYU3IvCW5OZgldrkigcOTaMNUaeZU Av8P3TTtqN4jIp/Hls/26VR+CqdoAtmzypBEyvOFDtzqPqVzFXfkUl2HZ0JGTYEXUEfnI0sU JCyLpcLO1DjnwEp8A+ueolYIpLASupGzGMGZ5I5Ou1RoF2buesEgwb+WV7HRNAXTmezUh3rW Lm4fAoUwv1lysICOfGGJQ2VkNe5OXzObvzjl30FYdDWb6F+xIDyG0Awxft4cXZcpFOGR3FH4 ZZ5OH+UNl1IxnNwVpGSqmzEU7xnoTXlyVH3Q/jYDG27HSoILQp/yRMJXWx/Xn57ZVXNm63Yr Z35XsX91pMHDRoQdJBMKkya813dggmhEszSIBYKqoiFt1HaMK/KnPwSSLO8CAwEAAaOBujCB tzAdBgNVHQ4EFgQUeeFJAeB7zjQ5KUMZMmVhPAbYVaswEgYDVR0TAQH/BAgwBgEB/wIBATAU BgNVHSABAf8ECjAIMAYGBFUdIAAwOwYDVR0fBDQwMjAwoC6gLIYqaHR0cDovL253dy5wa2ku bnhwLmNvbS9jcmwvTlhQUm9vdENBRzIuY3JsMB8GA1UdIwQYMBaAFJBIUyMqeeqEmz0+uQ7o mXRAXqC2MA4GA1UdDwEB/wQEAwIBBjANBgkqhkiG9w0BAQsFAAOCAgEAeXZR8kIdv3q3/VJX sdc8y+8blR9OWqmxjAo40VqPOWLcxLP2PkH3pleOPO/7Eg26pQzIESYql5pxlw/tL7b4Hhjc YpFom8yECNChnIxWeh8L/EfMPmcxi8wts4Zuu9q3bWOJxAcu4zWySDzbR/F/y6tzuaLgOZOm YihKTvG4dbRYBsC+0QMkf+6mfmDuB0O/HXE6bP9yf8rYZ1QWIfDp4h0eMtRuPZ7DeJd15qEq v0AqeAWtuwAdXCQIBxYTYXHJxIwg7sxAMXdkFOXrGc8mCe6J+myQ0d449XIAFVTpBtKPBjUf AnulbDFY8bEmkEEgyPYSmMALe+gDhOIlL3dJ2jeOd/edEfaIGlMfUPEnfD1s2sDXPH8O3o9z WHWaU2bevYw+KUK86QiSa+wGussopb+n/cnBhgd9g1iNsO4V29YpaqaUQZVnKhL3EAhuceco NPiOJ2MMSboxLKmKtAGALdP2VC2gU7NxmatkzbU/FeZVApqWw/k6SPcO9ugisCOx93H77CHt 0kD6JWcMOn5/fQQmVvk34PESJrHCbYb11pdfzHsSPMwgih/CHik1cWP09mP8zS8qcucbUAlo NHlkkZl/V5eub/xroh4Dsbk2IybvrsQV32ABBfV6lfiitfvNOLdZ4NJ2nbPM8hBQpcj7bPE/ kadY1yb1jgaulfXkinwwggfBMIIGqaADAgECAhMtAAtwr99sk/xklXltAAEAC3CvMA0GCSqG SIb3DQEBCwUAMIG2MRwwGgYDVQQDDBNOWFAgRW50ZXJwcmlzZSBDQSA1MQswCQYDVQQLDAJJ VDERMA8GA1UECgwITlhQIEIuVi4xEjAQBgNVBAcMCUVpbmRob3ZlbjEWMBQGA1UECAwNTm9v cmQtQnJhYmFudDETMBEGCgmSJomT8ixkARkWA3diaTETMBEGCgmSJomT8ixkARkWA254cDET MBEGCgmSJomT8ixkARkWA2NvbTELMAkGA1UEBhMCTkwwHhcNMjQwMjI2MTMxMDU3WhcNMjYw MjI1MTMxMDU3WjCBmjETMBEGCgmSJomT8ixkARkWA2NvbTETMBEGCgmSJomT8ixkARkWA254 cDETMBEGCgmSJomT8ixkARkWA3diaTEMMAoGA1UECxMDTlhQMQswCQYDVQQLEwJSTzEWMBQG A1UECxMNTWFuYWdlZCBVc2VyczETMBEGA1UECxMKRGV2ZWxvcGVyczERMA8GA1UEAxMIbnhh MTU0MTgwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDcgNVmjuq53/pMoGTLK6ES 4oWosNRv12ZTfgCAaNz7ZheB3rSWJmMvZVrec9JTcmdZXvP1gWBxvE19zerce3XFSFgpVp8U l7BtPRVfFuMMcL7Zy7dGjzJ4htT9/4TF0vk7DFEzVSCNA3oFBniptqmHWlbPjIt65XlMujSx +GXFi3yOXy10DfGIUgdrbaYARSSSKsOocVOoY6wu4BVUa9VryZzGa7oa+KkqE/Cevxd/Z3cZ bHz7slYweQCVFUEAxnm5Bz90S5RUacQ/pByT5E+t6TMTxa/k/hsh2Ae0z+icT0+zH9o7Nuol 5yrnwDLJrtHElavXdSGeU6xvopmEf1edAgMBAAGjggPgMIID3DA8BgkrBgEEAYI3FQcELzAt BiUrBgEEAYI3FQiFgsB+gY70VYbthTiC65lLmpJWP4Of3RqFqL5FAgFkAgE8MB0GA1UdJQQW MBQGCCsGAQUFBwMEBggrBgEFBQcDAjAOBgNVHQ8BAf8EBAMCB4AwDAYDVR0TAQH/BAIwADAn BgkrBgEEAYI3FQoEGjAYMAoGCCsGAQUFBwMEMAoGCCsGAQUFBwMCMFEGCSsGAQQBgjcZAgRE MEKgQAYKKwYBBAGCNxkCAaAyBDBTLTEtNS0yMS0xOTE1MjA3MDEzLTI2MTUwNDAzNjgtMzA3 NjkyOTQ1OC02Mjg2ODQwRQYDVR0RBD4wPKAkBgorBgEEAYI3FAIDoBYMFGhvcmlhLmdlYW50 YUBueHAuY29tgRRob3JpYS5nZWFudGFAbnhwLmNvbTAdBgNVHQ4EFgQUN+8qebkVelZHBHe/ VDwfs6l+N+IwHwYDVR0jBBgwFoAUWJVg7k5072Uiqr3tGakreo4XnQcwggFGBgNVHR8EggE9 MIIBOTCCATWgggExoIIBLYaByGxkYXA6Ly8vQ049TlhQJTIwRW50ZXJwcmlzZSUyMENBJTIw NSxDTj1ubGFtc3BraTAwMDUsQ049Q0RQLENOPVB1YmxpYyUyMEtleSUyMFNlcnZpY2VzLENO PVNlcnZpY2VzLENOPUNvbmZpZ3VyYXRpb24sREM9d2JpLERDPW54cCxEQz1jb20/Y2VydGlm aWNhdGVSZXZvY2F0aW9uTGlzdD9iYXNlP29iamVjdENsYXNzPWNSTERpc3RyaWJ1dGlvblBv aW50hi9odHRwOi8vbnd3LnBraS5ueHAuY29tL2NybC9OWFBFbnRlcnByaXNlQ0E1LmNybIYv aHR0cDovL3d3dy5wa2kubnhwLmNvbS9jcmwvTlhQRW50ZXJwcmlzZUNBNS5jcmwwggEQBggr BgEFBQcBAQSCAQIwgf8wgbsGCCsGAQUFBzAChoGubGRhcDovLy9DTj1OWFAlMjBFbnRlcnBy aXNlJTIwQ0ElMjA1LENOPUFJQSxDTj1QdWJsaWMlMjBLZXklMjBTZXJ2aWNlcyxDTj1TZXJ2 aWNlcyxDTj1Db25maWd1cmF0aW9uLERDPXdiaSxEQz1ueHAsREM9Y29tP2NBQ2VydGlmaWNh dGU/YmFzZT9vYmplY3RDbGFzcz1jZXJ0aWZpY2F0aW9uQXV0aG9yaXR5MD8GCCsGAQUFBzAC hjNodHRwOi8vbnd3LnBraS5ueHAuY29tL2NlcnRzL05YUC1FbnRlcnByaXNlLUNBNS5jZXIw DQYJKoZIhvcNAQELBQADggEBAFQXV89Rj3o0Lr77a2x8uB3eVNV/srEBvA+6fY/o09egSi5L 7roOttkx14ru4zCHKxyEqCL5z1gLUcDdBglKGoqhB53N5I83NZltwDxiGW13gVzevGAwu1uJ ubPDznGLRaSfxPyE0zkapNbrRz7q4PmH63CDxFkR2BuHb56L3+1sWj9AtfnqyXRWS231mSGB sBTr0WCk5sXm8j3U1Ax9TBd2w3VpmePN6drPUx3kWzEP3ONLUiRiz/n3E+EVz/YtD93CQHui t40we5nP0/6gpoz4mtXg/Yun7IAbDUOglhcaz+LmjYUzRhkjArPsaHGD4wLXW1Y8iQqTCEdw vYXZ8bkxggPCMIIDvgIBATCBzjCBtjEcMBoGA1UEAwwTTlhQIEVudGVycHJpc2UgQ0EgNTEL MAkGA1UECwwCSVQxETAPBgNVBAoMCE5YUCBCLlYuMRIwEAYDVQQHDAlFaW5kaG92ZW4xFjAU BgNVBAgMDU5vb3JkLUJyYWJhbnQxEzARBgoJkiaJk/IsZAEZFgN3YmkxEzARBgoJkiaJk/Is ZAEZFgNueHAxEzARBgoJkiaJk/IsZAEZFgNjb20xCzAJBgNVBAYTAk5MAhMtAAtwr99sk/xk lXltAAEAC3CvMA0GCWCGSAFlAwQCAQUAoIIBxDAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcB MBwGCSqGSIb3DQEJBTEPFw0yNTA4MjExMjA2NDBaMC8GCSqGSIb3DQEJBDEiBCC3ONVJ8wqY BiGbu5m6vvKvj6GsMLNZADeaf39cgeNWYjCCAVcGCSqGSIb3DQEJDzGCAUgwggFEMAsGCWCG SAFlAwQBKjALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwDQYIKoZIhvcNAwICAQUwDQYIKoZI hvcNAwICAQUwBwYFKw4DAgcwDQYIKoZIhvcNAwICAQUwBwYFKw4DAhowCwYJYIZIAWUDBAIB MAsGCWCGSAFlAwQCAjALBglghkgBZQMEAgMwCwYJYIZIAWUDBAIEMAsGCWCGSAFlAwQCBzAL BglghkgBZQMEAggwCwYJYIZIAWUDBAIJMAsGCWCGSAFlAwQCCjALBgkqhkiG9w0BAQEwCwYJ K4EFEIZIPwACMAgGBiuBBAELADAIBgYrgQQBCwEwCAYGK4EEAQsCMAgGBiuBBAELAzALBgkr gQUQhkg/AAMwCAYGK4EEAQ4AMAgGBiuBBAEOATAIBgYrgQQBDgIwCAYGK4EEAQ4DMA0GCSqG SIb3DQEBAQUABIIBAI9VpVpug1vlCTrloaMDkWRRzu0ZGiQh81hoZoH8WbgxY9nVMhVh5Lrw AZXWxNp6r35CPhoKW5VkM8aaZ2m0hS/XxEypDNmCY0Tz1sVHKyBzSiPkub8rgMUu7LpER3c4 WxDylFl4Tu0kM8YKt5pQEwauvG1wlIZYU+On0lZJFTbro7AB4GX+/MVDrdvVBBH/PT0T1TG6 z9wWcgbYSfhnbThrthVj6ZNOfTnH0wKri3Y5njlKZhGBYmUQ3Ox4EEDd8e3ulBCE80eJP+Mr xwrC/PhpodJyHzxhttJgqjan+DWBZytwMOakVPSaFtVq87kzcaPFPzLtDlbzIpGuGqXwE5EA AAAAAAA= --------------ms080004020003080601010405--
© 2016 - 2025 Red Hat, Inc.