arm64: dts: qcom: qcs615-ride: remove redundant gpio header file

[PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file

Posted by yuanjie yang 2 months, 2 weeks ago

From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>

Remove redundant gpio header file in QCS615 RIDE DTS.

Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>

---
 arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index fdad6388f6f7..55b9a62cafae 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -6,7 +6,6 @@
 
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
-#include <dt-bindings/gpio/gpio.h>
 #include "sm6150.dtsi"
 #include "pm8150.dtsi"
 / {

base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
-- 
2.34.1

Re: [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file

Posted by Krzysztof Kozlowski 2 months, 2 weeks ago

On 23/07/2025 10:43, yuanjie yang wrote:
> From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> 
> Remove redundant gpio header file in QCS615 RIDE DTS.

I do not see it redundant at all. Just look at the file - it is used.

Otherwise provide arguments WHY you claim this is redundant.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file

Posted by yuanjiey 2 months, 2 weeks ago

On Wed, Jul 23, 2025 at 10:49:10AM +0200, Krzysztof Kozlowski wrote:
> On 23/07/2025 10:43, yuanjie yang wrote:
> > From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> > 
> > Remove redundant gpio header file in QCS615 RIDE DTS.
> 
> I do not see it redundant at all. Just look at the file - it is used.
qcs615-ride.dts: file

line:
7:#include <dt-bindings/gpio/gpio.h>
8:#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
9:#include <dt-bindings/gpio/gpio.h>

I see line 7 and line 9 include the same <dt-bindings/gpio/gpio.h>,
I think we can remove one header file. 

> Otherwise provide arguments WHY you claim this is redundant.
> 
> Best regards,
> Krzysztof

Thanks,
Yuanjie

Re: [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file

Posted by Krzysztof Kozlowski 2 months, 2 weeks ago

On 23/07/2025 10:55, yuanjiey wrote:
> On Wed, Jul 23, 2025 at 10:49:10AM +0200, Krzysztof Kozlowski wrote:
>> On 23/07/2025 10:43, yuanjie yang wrote:
>>> From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
>>>
>>> Remove redundant gpio header file in QCS615 RIDE DTS.
>>
>> I do not see it redundant at all. Just look at the file - it is used.
> qcs615-ride.dts: file
> 
> line:
> 7:#include <dt-bindings/gpio/gpio.h>
> 8:#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> 9:#include <dt-bindings/gpio/gpio.h>
> 
> I see line 7 and line 9 include the same <dt-bindings/gpio/gpio.h>,
> I think we can remove one header file. 
> 
So say that it is there twice...

Best regards,
Krzysztof