[PATCH v9 0/2] add PCI hotplug and PCIe link tracepoint

Shuai Xue posted 2 patches 2 months, 2 weeks ago
drivers/pci/hotplug/pciehp_ctrl.c |  33 +++++++--
drivers/pci/hotplug/pciehp_hpc.c  |   5 +-
drivers/pci/pci.c                 |   2 +-
drivers/pci/pci.h                 |  12 ++-
drivers/pci/pcie/bwctrl.c         |   4 +-
drivers/pci/probe.c               |  10 ++-
include/linux/pci.h               |   1 +
include/trace/events/pci.h        | 119 ++++++++++++++++++++++++++++++
include/uapi/linux/pci.h          |   7 ++
9 files changed, 177 insertions(+), 16 deletions(-)
create mode 100644 include/trace/events/pci.h
[PATCH v9 0/2] add PCI hotplug and PCIe link tracepoint
Posted by Shuai Xue 2 months, 2 weeks ago
changes since v8:
- rewrite commit log from Bjorn
- move pci_hp_event to a common place (include/trace/events/pci.h) per Ilpo
- rename hotplug event strings per Bjorn and Lukas
- add PCIe link tracepoint per Bjorn, Lukas, and Ilpo

Hotplug events are critical indicators for analyzing hardware health, and
surprise link downs can significantly impact system performance and reliability.
In addition, PCIe link speed degradation directly impacts system performance and
often indicates hardware issues such as faulty devices, physical layer problems,
or configuration errors.

This patch set add PCI hotplug and PCIe link tracepoint to help analyze PCI
hotplug events and PCIe link speed degradation.

Shuai Xue (2):
  PCI: trace: Add a generic RAS tracepoint for hotplug event
  PCI: trace: Add a RAS tracepoint to monitor link speed changes

 drivers/pci/hotplug/pciehp_ctrl.c |  33 +++++++--
 drivers/pci/hotplug/pciehp_hpc.c  |   5 +-
 drivers/pci/pci.c                 |   2 +-
 drivers/pci/pci.h                 |  12 ++-
 drivers/pci/pcie/bwctrl.c         |   4 +-
 drivers/pci/probe.c               |  10 ++-
 include/linux/pci.h               |   1 +
 include/trace/events/pci.h        | 119 ++++++++++++++++++++++++++++++
 include/uapi/linux/pci.h          |   7 ++
 9 files changed, 177 insertions(+), 16 deletions(-)
 create mode 100644 include/trace/events/pci.h

-- 
2.39.3
Re: [PATCH v9 0/2] add PCI hotplug and PCIe link tracepoint
Posted by Bjorn Helgaas 2 weeks, 3 days ago
On Wed, Jul 23, 2025 at 11:31:06AM +0800, Shuai Xue wrote:
> changes since v8:
> - rewrite commit log from Bjorn
> - move pci_hp_event to a common place (include/trace/events/pci.h) per Ilpo
> - rename hotplug event strings per Bjorn and Lukas
> - add PCIe link tracepoint per Bjorn, Lukas, and Ilpo
> 
> Hotplug events are critical indicators for analyzing hardware health, and
> surprise link downs can significantly impact system performance and reliability.
> In addition, PCIe link speed degradation directly impacts system performance and
> often indicates hardware issues such as faulty devices, physical layer problems,
> or configuration errors.
> 
> This patch set add PCI hotplug and PCIe link tracepoint to help analyze PCI
> hotplug events and PCIe link speed degradation.
> 
> Shuai Xue (2):
>   PCI: trace: Add a generic RAS tracepoint for hotplug event
>   PCI: trace: Add a RAS tracepoint to monitor link speed changes
> 
>  drivers/pci/hotplug/pciehp_ctrl.c |  33 +++++++--
>  drivers/pci/hotplug/pciehp_hpc.c  |   5 +-
>  drivers/pci/pci.c                 |   2 +-
>  drivers/pci/pci.h                 |  12 ++-
>  drivers/pci/pcie/bwctrl.c         |   4 +-
>  drivers/pci/probe.c               |  10 ++-
>  include/linux/pci.h               |   1 +
>  include/trace/events/pci.h        | 119 ++++++++++++++++++++++++++++++
>  include/uapi/linux/pci.h          |   7 ++
>  9 files changed, 177 insertions(+), 16 deletions(-)
>  create mode 100644 include/trace/events/pci.h

Hi Shuai,

I lost track of what happened with this series.  It seemed like we
were pretty close but there were some trivial issues, and I don't
think we ever merged it.  Did I miss something, or are you waiting on
me?

Bjorn
Re: [PATCH v9 0/2] add PCI hotplug and PCIe link tracepoint
Posted by Shuai Xue 2 weeks, 3 days ago

在 2025/9/19 07:06, Bjorn Helgaas 写道:
> On Wed, Jul 23, 2025 at 11:31:06AM +0800, Shuai Xue wrote:
>> changes since v8:
>> - rewrite commit log from Bjorn
>> - move pci_hp_event to a common place (include/trace/events/pci.h) per Ilpo
>> - rename hotplug event strings per Bjorn and Lukas
>> - add PCIe link tracepoint per Bjorn, Lukas, and Ilpo
>>
>> Hotplug events are critical indicators for analyzing hardware health, and
>> surprise link downs can significantly impact system performance and reliability.
>> In addition, PCIe link speed degradation directly impacts system performance and
>> often indicates hardware issues such as faulty devices, physical layer problems,
>> or configuration errors.
>>
>> This patch set add PCI hotplug and PCIe link tracepoint to help analyze PCI
>> hotplug events and PCIe link speed degradation.
>>
>> Shuai Xue (2):
>>    PCI: trace: Add a generic RAS tracepoint for hotplug event
>>    PCI: trace: Add a RAS tracepoint to monitor link speed changes
>>
>>   drivers/pci/hotplug/pciehp_ctrl.c |  33 +++++++--
>>   drivers/pci/hotplug/pciehp_hpc.c  |   5 +-
>>   drivers/pci/pci.c                 |   2 +-
>>   drivers/pci/pci.h                 |  12 ++-
>>   drivers/pci/pcie/bwctrl.c         |   4 +-
>>   drivers/pci/probe.c               |  10 ++-
>>   include/linux/pci.h               |   1 +
>>   include/trace/events/pci.h        | 119 ++++++++++++++++++++++++++++++
>>   include/uapi/linux/pci.h          |   7 ++
>>   9 files changed, 177 insertions(+), 16 deletions(-)
>>   create mode 100644 include/trace/events/pci.h
> 
> Hi Shuai,
> 
> I lost track of what happened with this series.  It seemed like we
> were pretty close but there were some trivial issues, and I don't
> think we ever merged it.  Did I miss something, or are you waiting on
> me?
> 
> Bjorn

Hi Bjorn,

Thank you for following up on this series. I apologize for the lack of
updates.

You're right that we were close to merging - I've been tied up with
other urgent work and haven't had a chance to address the remaining
minor issues.

I'll prepare and send out a new version this week with all the requested
changes.

Thanks for your patience.

Best regards,
Shuai