soc: qcom: ubwc: Add missing UBWC config for SM7225

[PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225

Posted by Luca Weiss 2 months, 2 weeks ago

SM7225 is a variation of SM6350, and also needs an entry in the table.

Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Note, due to other bugs on next-20250723 I couldn't fully test that
DPU/GPU are working, but this seems to be required in any case...
---
 drivers/soc/qcom/ubwc_config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index bd0a98aad9f3b222abcf0a7af85a318caffa9841..9fdd169f87a78a486bea8823083bef08bc5b9521 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -246,6 +246,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
 	{ .compatible = "qcom,sm6375", .data = &sm6350_data, },
 	{ .compatible = "qcom,sm7125", .data = &sc7180_data },
 	{ .compatible = "qcom,sm7150", .data = &sm7150_data, },
+	{ .compatible = "qcom,sm7225", .data = &sm6350_data, },
 	{ .compatible = "qcom,sm8150", .data = &sm8150_data, },
 	{ .compatible = "qcom,sm8250", .data = &sm8250_data, },
 	{ .compatible = "qcom,sm8350", .data = &sm8350_data, },

---
base-commit: ac3f0fb04c50a909908fd375686c5ad6b27bee98
change-id: 20250723-ubwc-sm7225-19be7c2e7bdd

Best regards,
-- 
Luca Weiss <luca.weiss@fairphone.com>

Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225

Posted by Dmitry Baryshkov 2 months, 2 weeks ago

On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
> SM7225 is a variation of SM6350, and also needs an entry in the table.
> 
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Note, due to other bugs on next-20250723 I couldn't fully test that
> DPU/GPU are working, but this seems to be required in any case...
> ---
>  drivers/soc/qcom/ubwc_config.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225

Posted by Bjorn Andersson 1 month, 3 weeks ago

On Wed, Jul 23, 2025 at 10:03:15PM +0300, Dmitry Baryshkov wrote:
> On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
> > SM7225 is a variation of SM6350, and also needs an entry in the table.
> > 
> > Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > ---
> > Note, due to other bugs on next-20250723 I couldn't fully test that
> > DPU/GPU are working, but this seems to be required in any case...
> > ---
> >  drivers/soc/qcom/ubwc_config.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> 

@Dmitry will you pick this as well through your tree, so we avoid (the
trivial) conflict.

Acked-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> 
> -- 
> With best wishes
> Dmitry

Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225

Posted by Dmitry Baryshkov 1 month, 3 weeks ago

On Mon, Aug 11, 2025 at 01:32:00PM -0500, Bjorn Andersson wrote:
> On Wed, Jul 23, 2025 at 10:03:15PM +0300, Dmitry Baryshkov wrote:
> > On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
> > > SM7225 is a variation of SM6350, and also needs an entry in the table.
> > > 
> > > Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> > > ---
> > > Note, due to other bugs on next-20250723 I couldn't fully test that
> > > DPU/GPU are working, but this seems to be required in any case...
> > > ---
> > >  drivers/soc/qcom/ubwc_config.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > 
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > 
> 
> @Dmitry will you pick this as well through your tree, so we avoid (the
> trivial) conflict.

Yes

> 
> Acked-by: Bjorn Andersson <andersson@kernel.org>
> 
> Regards,
> Bjorn
> 
> > 
> > -- 
> > With best wishes
> > Dmitry

-- 
With best wishes
Dmitry

Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225

Posted by Luca Weiss 1 month, 3 weeks ago

On Tue Aug 12, 2025 at 1:10 PM CEST, Dmitry Baryshkov wrote:
> On Mon, Aug 11, 2025 at 01:32:00PM -0500, Bjorn Andersson wrote:
>> On Wed, Jul 23, 2025 at 10:03:15PM +0300, Dmitry Baryshkov wrote:
>> > On Wed, Jul 23, 2025 at 04:19:22PM +0200, Luca Weiss wrote:
>> > > SM7225 is a variation of SM6350, and also needs an entry in the table.
>> > > 
>> > > Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
>> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> > > ---
>> > > Note, due to other bugs on next-20250723 I couldn't fully test that
>> > > DPU/GPU are working, but this seems to be required in any case...
>> > > ---
>> > >  drivers/soc/qcom/ubwc_config.c | 1 +
>> > >  1 file changed, 1 insertion(+)
>> > > 
>> > 
>> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> > 
>> 
>> @Dmitry will you pick this as well through your tree, so we avoid (the
>> trivial) conflict.
>
> Yes

Could you maybe amend this patch to also add sm7325?

Or check if any other compatibles were left out in ubwc_config.c which
are used upstream, I didn't check...

Regards
Luca

>
>> 
>> Acked-by: Bjorn Andersson <andersson@kernel.org>
>> 
>> Regards,
>> Bjorn
>> 
>> > 
>> > -- 
>> > With best wishes
>> > Dmitry

Re: [PATCH] soc: qcom: ubwc: Add missing UBWC config for SM7225

Posted by Luca Weiss 2 months, 2 weeks ago

On Wed Jul 23, 2025 at 4:19 PM CEST, Luca Weiss wrote:
> SM7225 is a variation of SM6350, and also needs an entry in the table.

And now a second after sending I checked sm7325 and that's also
missing...

>
> Fixes: 1924272b9ce1 ("soc: qcom: Add UBWC config provider")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Note, due to other bugs on next-20250723 I couldn't fully test that
> DPU/GPU are working, but this seems to be required in any case...
> ---
>  drivers/soc/qcom/ubwc_config.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
> index bd0a98aad9f3b222abcf0a7af85a318caffa9841..9fdd169f87a78a486bea8823083bef08bc5b9521 100644
> --- a/drivers/soc/qcom/ubwc_config.c
> +++ b/drivers/soc/qcom/ubwc_config.c
> @@ -246,6 +246,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
>  	{ .compatible = "qcom,sm6375", .data = &sm6350_data, },
>  	{ .compatible = "qcom,sm7125", .data = &sc7180_data },
>  	{ .compatible = "qcom,sm7150", .data = &sm7150_data, },
> +	{ .compatible = "qcom,sm7225", .data = &sm6350_data, },
>  	{ .compatible = "qcom,sm8150", .data = &sm8150_data, },
>  	{ .compatible = "qcom,sm8250", .data = &sm8250_data, },
>  	{ .compatible = "qcom,sm8350", .data = &sm8350_data, },
>
> ---
> base-commit: ac3f0fb04c50a909908fd375686c5ad6b27bee98
> change-id: 20250723-ubwc-sm7225-19be7c2e7bdd
>
> Best regards,