Commit d7659acca7a3 ("rust: add pin-init crate build infrastructure")
did not add dependencies to `pin_init_internal`, resulting in broken
navigation. Thus add them now.

Signed-off-by: Tamir Duberstein <tamird@kernel.org>
---
 scripts/generate_rust_analyzer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
index 451d00dfc08d..229acd4cf1fb 100755
--- a/scripts/generate_rust_analyzer.py
+++ b/scripts/generate_rust_analyzer.py
@@ -102,7 +102,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
     append_crate(
         "pin_init_internal",
         srctree / "rust" / "pin-init" / "internal" / "src" / "lib.rs",
-        [],
+        ["std", "proc_macro"],
         cfg=["kernel"],
         is_proc_macro=True,
     )

-- 
2.50.1

On Thu Jul 24, 2025 at 12:39 AM KST, Tamir Duberstein wrote:
> Commit d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> did not add dependencies to `pin_init_internal`, resulting in broken
> navigation. Thus add them now.
>
> Signed-off-by: Tamir Duberstein <tamird@kernel.org>
> ---
>  scripts/generate_rust_analyzer.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 451d00dfc08d..229acd4cf1fb 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -102,7 +102,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
>      append_crate(
>          "pin_init_internal",
>          srctree / "rust" / "pin-init" / "internal" / "src" / "lib.rs",
> -        [],
> +        ["std", "proc_macro"],
>          cfg=["kernel"],
>          is_proc_macro=True,
>      )

Reviewed-by: Jesung Yang <y.j3ms.n@gmail.com>

Best regards,
Jesung

On Thu Jul 24, 2025 at 12:39 AM KST, Tamir Duberstein wrote:
> Commit d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> did not add dependencies to `pin_init_internal`, resulting in broken
> navigation. Thus add them now.
>
> Signed-off-by: Tamir Duberstein <tamird@kernel.org>
> ---
>  scripts/generate_rust_analyzer.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 451d00dfc08d..229acd4cf1fb 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -102,7 +102,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
>      append_crate(
>          "pin_init_internal",
>          srctree / "rust" / "pin-init" / "internal" / "src" / "lib.rs",
> -        [],
> +        ["std", "proc_macro"],
>          cfg=["kernel"],
>          is_proc_macro=True,
>      )

The recent `syn` rewrite of pin-init [1] covers this as well. How do we
usually handle this kind of overlap?

[1] https://lore.kernel.org/rust-for-linux/20260111122554.2662175-4-lossin@kernel.org/

Best regards,
Jesung

On Wed, Jan 14, 2026 at 10:26 AM Jesung Yang <y.j3ms.n@gmail.com> wrote:
>
> The recent `syn` rewrite of pin-init [1] covers this as well. How do we
> usually handle this kind of overlap?
>
> [1] https://lore.kernel.org/rust-for-linux/20260111122554.2662175-4-lossin@kernel.org/

It should be fine, when applying that other series later on we will
get a conflict to be resolved, but that's it.

I wonder, though -- should these be applied as fixes? After all, even
the commit hash is provided there, so we could add a Fixes too. They
could also be backported if needed.

Thanks!

Cheers,
Miguel

On Wed, Jan 14, 2026 at 11:29 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> I wonder, though -- should these be applied as fixes? After all, even
> the commit hash is provided there, so we could add a Fixes too. They
> could also be backported if needed.

Ah, yeah, you already said that in the other two.

In that case, we can take the three of them into `rust-fixes` directly.

Cheers,
Miguel

On Wed, Jan 14, 2026 at 5:32 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Wed, Jan 14, 2026 at 11:29 AM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> >
> > I wonder, though -- should these be applied as fixes? After all, even
> > the commit hash is provided there, so we could add a Fixes too. They
> > could also be backported if needed.
>
> Ah, yeah, you already said that in the other two.
>
> In that case, we can take the three of them into `rust-fixes` directly.
>
> Cheers,
> Miguel

Sounds good to me. Miguel: do you need me to send a new version with
the Fixes tags, or can they be added in a reply or at apply time?

On Wed, Jan 14, 2026 at 3:57 PM Tamir Duberstein <tamird@kernel.org> wrote:
>
> Sounds good to me. Miguel: do you need me to send a new version with
> the Fixes tags, or can they be added in a reply or at apply time?

Yeah, they can be added in replies in general -- I will add them, no
worries, thanks!

Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
Cc: stable@vger.kernel.org

Cheers,
Miguel