Minor fixes in this series. The main one is fixing navigation in
pin_init_internal.

This is my first series using tamird@kernel.org; please excude any
hiccups.

Signed-off-by: Tamir Duberstein <tamird@kernel.org>
---
Tamir Duberstein (3):
      scripts: generate_rust_analyzer: Add compiler_builtins -> core dep
      scripts: generate_rust_analyzer: Add pin_init -> compiler_builtins dep
      scripts: generate_rust_analyzer: Add pin_init_internal deps

 scripts/generate_rust_analyzer.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
base-commit: dff64b072708ffef23c117fa1ee1ea59eb417807
change-id: 20250723-rust-analyzer-pin-init-925467269001

Best regards,
--  
Tamir Duberstein <tamird@kernel.org>

On Wed, Jul 23, 2025 at 5:39 PM Tamir Duberstein <tamird@kernel.org> wrote:
>
> Minor fixes in this series. The main one is fixing navigation in
> pin_init_internal.
>
> This is my first series using tamird@kernel.org; please excude any
> hiccups.
>
> Signed-off-by: Tamir Duberstein <tamird@kernel.org>

Applied to `rust-fixes` (with Fixes and Cc stable) -- thanks everyone!

    [ Tamir elaborates:

      "before this series, go-to-symbol from pin_init_internal to e.g.
       proc_macro::TokenStream doesn't work."

         - Miguel ]

Cheers,
Miguel

@Benno would you mind having a look at this series?

On Wed, Jul 23, 2025 at 11:39 AM Tamir Duberstein <tamird@kernel.org> wrote:
>
> Minor fixes in this series. The main one is fixing navigation in
> pin_init_internal.
>
> This is my first series using tamird@kernel.org; please excude any
> hiccups.
>
> Signed-off-by: Tamir Duberstein <tamird@kernel.org>
> ---
> Tamir Duberstein (3):
>       scripts: generate_rust_analyzer: Add compiler_builtins -> core dep
>       scripts: generate_rust_analyzer: Add pin_init -> compiler_builtins dep
>       scripts: generate_rust_analyzer: Add pin_init_internal deps
>
>  scripts/generate_rust_analyzer.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> ---
> base-commit: dff64b072708ffef23c117fa1ee1ea59eb417807
> change-id: 20250723-rust-analyzer-pin-init-925467269001
>
> Best regards,
> --
> Tamir Duberstein <tamird@kernel.org>
>

On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
> @Benno would you mind having a look at this series?

Oh wow this is an old series! Sorry for missing it.

I'm not maintaining the build system for pin-init, but from my side the
changes look okay. The commit messages are missing some context though:
why do we need these dependency edges? etc. If you fix that you can add

Acked-by: Benno Lossin <lossin@kernel.org>

Also note that this might be different in the new build system.

Cheers,
Benno

> On Wed, Jul 23, 2025 at 11:39 AM Tamir Duberstein <tamird@kernel.org> wrote:
>>
>> Minor fixes in this series. The main one is fixing navigation in
>> pin_init_internal.
>>
>> This is my first series using tamird@kernel.org; please excude any
>> hiccups.
>>
>> Signed-off-by: Tamir Duberstein <tamird@kernel.org>
>> ---
>> Tamir Duberstein (3):
>>       scripts: generate_rust_analyzer: Add compiler_builtins -> core dep
>>       scripts: generate_rust_analyzer: Add pin_init -> compiler_builtins dep
>>       scripts: generate_rust_analyzer: Add pin_init_internal deps
>>
>>  scripts/generate_rust_analyzer.py | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> ---
>> base-commit: dff64b072708ffef23c117fa1ee1ea59eb417807
>> change-id: 20250723-rust-analyzer-pin-init-925467269001
>>
>> Best regards,
>> --
>> Tamir Duberstein <tamird@kernel.org>
>>

On Fri, Jan 2, 2026 at 3:05 PM Benno Lossin <lossin@kernel.org> wrote:
>
> On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
> > @Benno would you mind having a look at this series?
>
> Oh wow this is an old series! Sorry for missing it.
>
> I'm not maintaining the build system for pin-init, but from my side the
> changes look okay. The commit messages are missing some context though:
> why do we need these dependency edges? etc. If you fix that you can add
>
> Acked-by: Benno Lossin <lossin@kernel.org>
>
> Also note that this might be different in the new build system.

Thanks for the review! I think the commits all include answers to
"why": the first two make RA match the actual build and the final one
does the same and also fixes navigation in pin_init_internal; before
this series, go-to-symbol from pin_init_internal to e.g.
proc_macro::TokenStream doesn't work.

On Fri Jan 2, 2026 at 9:34 PM CET, Tamir Duberstein wrote:
> On Fri, Jan 2, 2026 at 3:05 PM Benno Lossin <lossin@kernel.org> wrote:
>>
>> On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
>> > @Benno would you mind having a look at this series?
>>
>> Oh wow this is an old series! Sorry for missing it.
>>
>> I'm not maintaining the build system for pin-init, but from my side the
>> changes look okay. The commit messages are missing some context though:
>> why do we need these dependency edges? etc. If you fix that you can add
>>
>> Acked-by: Benno Lossin <lossin@kernel.org>
>>
>> Also note that this might be different in the new build system.
>
> Thanks for the review! I think the commits all include answers to
> "why": the first two make RA match the actual build and the final one
> does the same and also fixes navigation in pin_init_internal; before
> this series, go-to-symbol from pin_init_internal to e.g.
> proc_macro::TokenStream doesn't work.

Ah I missed the explanation since its so few words.

Cheers,
Benno

On Sat, Jan 3, 2026 at 4:59 AM Benno Lossin <lossin@kernel.org> wrote:
>
> On Fri Jan 2, 2026 at 9:34 PM CET, Tamir Duberstein wrote:
> > On Fri, Jan 2, 2026 at 3:05 PM Benno Lossin <lossin@kernel.org> wrote:
> >>
> >> On Fri Jan 2, 2026 at 4:25 PM CET, Tamir Duberstein wrote:
> >> > @Benno would you mind having a look at this series?
> >>
> >> Oh wow this is an old series! Sorry for missing it.
> >>
> >> I'm not maintaining the build system for pin-init, but from my side the
> >> changes look okay. The commit messages are missing some context though:
> >> why do we need these dependency edges? etc. If you fix that you can add
> >>
> >> Acked-by: Benno Lossin <lossin@kernel.org>
> >>
> >> Also note that this might be different in the new build system.
> >
> > Thanks for the review! I think the commits all include answers to
> > "why": the first two make RA match the actual build and the final one
> > does the same and also fixes navigation in pin_init_internal; before
> > this series, go-to-symbol from pin_init_internal to e.g.
> > proc_macro::TokenStream doesn't work.
>
> Ah I missed the explanation since its so few words.
>
> Cheers,
> Benno

Ack, thanks.

@Miguel could you please take this through rust-next? Assuming that is
OK with Benno, which is my interpretation of his earlier replies.

On Sat, Jan 3, 2026 at 4:20 PM Tamir Duberstein <tamird@kernel.org> wrote:
>
> Ack, thanks.
>
> @Miguel could you please take this through rust-next? Assuming that is
> OK with Benno, which is my interpretation of his earlier replies.

Sounds good to me, of course.

Cc'ing Jesung, in case he didn't see this one and wants to give it a look/test.

Cheers,
Miguel