From: Qiang Yu <qiang.yu@oss.qualcomm.com>
Enable the pwrctrl driver, which is utilized to manage the power supplies
of the devices connected to the PCI slots. This ensures that the voltage
rails of the standard PCI slots on some platforms eg. X1E80100-QCP can be
correctly turned on/off if they are described under PCIe port device tree
node.
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
Signed-off-by: Wenbin Yao <quic_wenbyao@quicinc.com>
---
drivers/pci/controller/dwc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index ff6b6d9e1..deafc512b 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -298,6 +298,7 @@ config PCIE_QCOM
select CRC8
select PCIE_QCOM_COMMON
select PCI_HOST_COMMON
+ select PCI_PWRCTRL_SLOT
help
Say Y here to enable PCIe controller support on Qualcomm SoCs. The
PCIe controller uses the DesignWare core plus Qualcomm-specific
--
2.34.1On Tue, Jul 22, 2025 at 05:11:49PM GMT, Wenbin Yao wrote: > From: Qiang Yu <qiang.yu@oss.qualcomm.com> > > Enable the pwrctrl driver, which is utilized to manage the power supplies > of the devices connected to the PCI slots. This ensures that the voltage > rails of the standard PCI slots on some platforms eg. X1E80100-QCP can be > correctly turned on/off if they are described under PCIe port device tree > node. > > Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com> > Signed-off-by: Wenbin Yao <quic_wenbyao@quicinc.com> > --- > drivers/pci/controller/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index ff6b6d9e1..deafc512b 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -298,6 +298,7 @@ config PCIE_QCOM > select CRC8 > select PCIE_QCOM_COMMON > select PCI_HOST_COMMON > + select PCI_PWRCTRL_SLOT I guess you also need 'if HAVE_PWRCTRL' - Mani -- மணிவண்ணன் சதாசிவம்
On 7/23/2025 10:34 PM, Manivannan Sadhasivam wrote: > On Tue, Jul 22, 2025 at 05:11:49PM GMT, Wenbin Yao wrote: >> From: Qiang Yu <qiang.yu@oss.qualcomm.com> >> >> Enable the pwrctrl driver, which is utilized to manage the power supplies >> of the devices connected to the PCI slots. This ensures that the voltage >> rails of the standard PCI slots on some platforms eg. X1E80100-QCP can be >> correctly turned on/off if they are described under PCIe port device tree >> node. >> >> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com> >> Signed-off-by: Wenbin Yao <quic_wenbyao@quicinc.com> >> --- >> drivers/pci/controller/dwc/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig >> index ff6b6d9e1..deafc512b 100644 >> --- a/drivers/pci/controller/dwc/Kconfig >> +++ b/drivers/pci/controller/dwc/Kconfig >> @@ -298,6 +298,7 @@ config PCIE_QCOM >> select CRC8 >> select PCIE_QCOM_COMMON >> select PCI_HOST_COMMON >> + select PCI_PWRCTRL_SLOT > I guess you also need 'if HAVE_PWRCTRL' > > - Mani PCIE_QCOM depends on PCI and (ARCH_QCOM || COMPILE_TEST), ARCH_QCOM selects HAVE_PWRCTRL. > -- With best wishes Wenbin
In subject: PCI: qcom: Enable PCI Power Control Slot driver This is not a generic dwc change; it's specific to qcom, so I want the subject to reflect that. We can fix this when applying unless other changes are needed. On Tue, Jul 22, 2025 at 05:11:49PM +0800, Wenbin Yao wrote: > From: Qiang Yu <qiang.yu@oss.qualcomm.com> > > Enable the pwrctrl driver, which is utilized to manage the power supplies > of the devices connected to the PCI slots. This ensures that the voltage > rails of the standard PCI slots on some platforms eg. X1E80100-QCP can be > correctly turned on/off if they are described under PCIe port device tree > node. > > Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com> > Signed-off-by: Wenbin Yao <quic_wenbyao@quicinc.com> > --- > drivers/pci/controller/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > index ff6b6d9e1..deafc512b 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -298,6 +298,7 @@ config PCIE_QCOM > select CRC8 > select PCIE_QCOM_COMMON > select PCI_HOST_COMMON > + select PCI_PWRCTRL_SLOT > help > Say Y here to enable PCIe controller support on Qualcomm SoCs. The > PCIe controller uses the DesignWare core plus Qualcomm-specific > -- > 2.34.1 >
On 7/23/2025 7:22 AM, Bjorn Helgaas wrote: > In subject: > > PCI: qcom: Enable PCI Power Control Slot driver > > This is not a generic dwc change; it's specific to qcom, so I want the > subject to reflect that. > > We can fix this when applying unless other changes are needed. OK， will fix it. > > On Tue, Jul 22, 2025 at 05:11:49PM +0800, Wenbin Yao wrote: >> From: Qiang Yu <qiang.yu@oss.qualcomm.com> >> >> Enable the pwrctrl driver, which is utilized to manage the power supplies >> of the devices connected to the PCI slots. This ensures that the voltage >> rails of the standard PCI slots on some platforms eg. X1E80100-QCP can be >> correctly turned on/off if they are described under PCIe port device tree >> node. >> >> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com> >> Signed-off-by: Wenbin Yao <quic_wenbyao@quicinc.com> >> --- >> drivers/pci/controller/dwc/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig >> index ff6b6d9e1..deafc512b 100644 >> --- a/drivers/pci/controller/dwc/Kconfig >> +++ b/drivers/pci/controller/dwc/Kconfig >> @@ -298,6 +298,7 @@ config PCIE_QCOM >> select CRC8 >> select PCIE_QCOM_COMMON >> select PCI_HOST_COMMON >> + select PCI_PWRCTRL_SLOT >> help >> Say Y here to enable PCIe controller support on Qualcomm SoCs. The >> PCIe controller uses the DesignWare core plus Qualcomm-specific >> -- >> 2.34.1 >> -- With best wishes Wenbin
On 7/24/2025 10:52 AM, Wenbin Yao (Consultant) wrote: > On 7/23/2025 7:22 AM, Bjorn Helgaas wrote: >> In subject: >> >> PCI: qcom: Enable PCI Power Control Slot driver >> >> This is not a generic dwc change; it's specific to qcom, so I want the >> subject to reflect that. >> >> We can fix this when applying unless other changes are needed. > > OK， will fix it. Hi Bjorn, we have nothing to update, will not send new version, could you please pick up patches and fix this when applying if there is no further comments? - Qiang Yu> >> >> On Tue, Jul 22, 2025 at 05:11:49PM +0800, Wenbin Yao wrote: >>> From: Qiang Yu <qiang.yu@oss.qualcomm.com> >>> >>> Enable the pwrctrl driver, which is utilized to manage the power supplies >>> of the devices connected to the PCI slots. This ensures that the voltage >>> rails of the standard PCI slots on some platforms eg. X1E80100-QCP can be >>> correctly turned on/off if they are described under PCIe port device tree >>> node. >>> >>> Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com> >>> Signed-off-by: Wenbin Yao <quic_wenbyao@quicinc.com> >>> --- >>> drivers/pci/controller/dwc/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig >>> index ff6b6d9e1..deafc512b 100644 >>> --- a/drivers/pci/controller/dwc/Kconfig >>> +++ b/drivers/pci/controller/dwc/Kconfig >>> @@ -298,6 +298,7 @@ config PCIE_QCOM >>> select CRC8 >>> select PCIE_QCOM_COMMON >>> select PCI_HOST_COMMON >>> + select PCI_PWRCTRL_SLOT >>> help >>> Say Y here to enable PCIe controller support on Qualcomm SoCs. The >>> PCIe controller uses the DesignWare core plus Qualcomm-specific >>> -- >>> 2.34.1 >>>
© 2016 - 2025 Red Hat, Inc.