[PATCH 1/2] MIPS: mobileye: dts: eyeq5: rename the emmc controller

Benoît Monin posted 2 patches 2 months, 2 weeks ago
[PATCH 1/2] MIPS: mobileye: dts: eyeq5: rename the emmc controller
Posted by Benoît Monin 2 months, 2 weeks ago
The name should match the pattern defined in the mmc-controller binding.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507220336.JhvVLL7k-lkp@intel.com/
Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
---
 arch/mips/boot/dts/mobileye/eyeq5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/mobileye/eyeq5.dtsi b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
index 699eeb30ced8159b6a0b5d75541f1e6cb6ef4e5e..36a73e8a63a1ab32d1c300d17c4491b175428cdf 100644
--- a/arch/mips/boot/dts/mobileye/eyeq5.dtsi
+++ b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
@@ -254,7 +254,7 @@ timer {
 			};
 		};
 
-		emmc: sdhci@2200000 {
+		emmc: mmc@2200000 {
 			compatible = "mobileye,eyeq-sd4hc", "cdns,sd4hc";
 			reg = <0 0x2200000 0x0 0x1000>;
 			interrupt-parent = <&gic>;

-- 
2.50.1

Re: [PATCH 1/2] MIPS: mobileye: dts: eyeq5: rename the emmc controller
Posted by Krzysztof Kozlowski 2 months, 2 weeks ago
On 22/07/2025 17:15, Benoît Monin wrote:
> The name should match the pattern defined in the mmc-controller binding.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507220336.JhvVLL7k-lkp@intel.com/
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>

The important point of that binding here:
https://lore.kernel.org/linux-devicetree/9b34b471d1e71cf47c503aed7145fab896767ba7.1750156323.git.benoit.monin@bootlin.com/

was to USE it for testing it. Before you send such work, you are
supposed to check your code with the toolset.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof